emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Matt Huszagh <huszaghmatt@gmail.com>
To: "Fraga, Eric" <e.fraga@ucl.ac.uk>
Cc: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: Removing horizontal space in latex fragments
Date: Thu, 5 Dec 2019 23:42:22 -0800	[thread overview]
Message-ID: <CA+X8ke7XiZV5pLR9k8oMdpXNB89B6YX=PRPDmqE+DT9ef_4gog@mail.gmail.com> (raw)
In-Reply-To: <xuu6h82e9zsl.fsf@ucl.ac.uk>


[-- Attachment #1.1: Type: text/plain, Size: 725 bytes --]

Thanks for the reply Eric. The thing I like about the newlines is that the
generated tex files are slightly easier to read. However, this is really
minor. I've created 2 separate patches: one keeping the newlines and the
other without. I'm happy to defer to you or anyone else in regard to which
is preferable.

On Thu, Dec 5, 2019 at 2:24 PM Fraga, Eric <e.fraga@ucl.ac.uk> wrote:

> On Thursday,  5 Dec 2019 at 11:03, Matt Huszagh wrote:
> > Is anyone else interested in this modification? Should I submit it as a
> > patch?
>
> I think so.  And I am not sure all those \n's are necessary.  Without
> them, you can probably also remove many of the %s.
> --
> Eric S Fraga via Emacs 27.0.50, Org release_9.2.6-544-gd215c3
>

[-- Attachment #1.2: Type: text/html, Size: 1051 bytes --]

[-- Attachment #2: remove-newlines.patch --]
[-- Type: application/octet-stream, Size: 1421 bytes --]

From baf9812cb050c804d4d12bf3e2819bd4a5987722 Mon Sep 17 00:00:00 2001
From: Matt Huszagh <huszaghmatt@gmail.com>
Date: Thu, 5 Dec 2019 23:16:39 -0800
Subject: [PATCH] org.el: Remove leading/trailing whitespace from latex
 fragment

* lisp/org.el (org-create-formula-image): Ensure user input ends
with a % character to remove trailing whitespace. Also, remove
newlines from macro calls.
---
 lisp/org.el | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/lisp/org.el b/lisp/org.el
index 9b84592ba..4e3dbe4c3 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -16554,13 +16554,18 @@ a HTML file."
 	(setq bg (org-latex-color :background))
       (setq bg (org-latex-color-format
 		(if (string= bg "Transparent") "white" bg))))
+    ;; remove tex \par at end of snippet to avoid trailing
+    ;; whitespace
+    (if (string= (substring string -1 nil) "\n")
+        (aset string (- (length string) 1) ?%)
+      (setq string (concat string "%")))
     (with-temp-file texfile
       (insert latex-header)
       (insert "\n\\begin{document}\n"
-	      "\\definecolor{fg}{rgb}{" fg "}\n"
-	      "\\definecolor{bg}{rgb}{" bg "}\n"
-	      "\n\\pagecolor{bg}\n"
-	      "\n{\\color{fg}\n"
+	      "\\definecolor{fg}{rgb}{" fg "}"
+	      "\\definecolor{bg}{rgb}{" bg "}"
+	      "\\pagecolor{bg}"
+	      "{\\color{fg}\n"
 	      string
 	      "\n}\n"
 	      "\n\\end{document}\n"))
-- 
2.24.0


[-- Attachment #3: keep-newlines.patch --]
[-- Type: application/octet-stream, Size: 1399 bytes --]

From bdb93a13a43d90ad6e66449797111e836a67a219 Mon Sep 17 00:00:00 2001
From: Matt Huszagh <huszaghmatt@gmail.com>
Date: Thu, 5 Dec 2019 23:25:32 -0800
Subject: [PATCH] org.el: Remove leading/trailing whitespace from latex
 fragment

* lisp/org.el (org-create-formula-image): Ensure user input ends
with a % character to remove trailing whitespace. Also, add %
characters between macros and newlines purely visual.
---
 lisp/org.el | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/lisp/org.el b/lisp/org.el
index 9b84592ba..ae686e330 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -16554,12 +16554,17 @@ a HTML file."
 	(setq bg (org-latex-color :background))
       (setq bg (org-latex-color-format
 		(if (string= bg "Transparent") "white" bg))))
+    ;; remove tex \par at end of snippet to avoid trailing
+    ;; whitespace
+    (if (string= (substring string -1 nil) "\n")
+        (aset string (- (length string) 1) ?%)
+      (setq string (concat string "%")))
     (with-temp-file texfile
       (insert latex-header)
       (insert "\n\\begin{document}\n"
-	      "\\definecolor{fg}{rgb}{" fg "}\n"
-	      "\\definecolor{bg}{rgb}{" bg "}\n"
-	      "\n\\pagecolor{bg}\n"
+	      "\\definecolor{fg}{rgb}{" fg "}%\n"
+	      "\\definecolor{bg}{rgb}{" bg "}%\n"
+	      "\n\\pagecolor{bg}%\n"
 	      "\n{\\color{fg}\n"
 	      string
 	      "\n}\n"
-- 
2.24.0


  reply	other threads:[~2019-12-06 14:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-05 19:03 Removing horizontal space in latex fragments Matt Huszagh
2019-12-05 22:24 ` Fraga, Eric
2019-12-06  7:42   ` Matt Huszagh [this message]
2019-12-06 13:24     ` Fraga, Eric
2019-12-14 14:57     ` Nicolas Goaziou
2019-12-15  3:48       ` Matt Huszagh
2019-12-15  9:04         ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+X8ke7XiZV5pLR9k8oMdpXNB89B6YX=PRPDmqE+DT9ef_4gog@mail.gmail.com' \
    --to=huszaghmatt@gmail.com \
    --cc=e.fraga@ucl.ac.uk \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).