From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Dudebout Subject: [PATCH] org-agenda: make log and clockreport modes local Date: Wed, 21 Feb 2018 21:42:19 -0500 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="94eb2c1ab2642b0dc10565c3fefc" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49235) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eogr4-0006cS-2y for emacs-orgmode@gnu.org; Wed, 21 Feb 2018 21:44:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eogq0-00020Y-0q for emacs-orgmode@gnu.org; Wed, 21 Feb 2018 21:43:29 -0500 Received: from mail-lf0-x234.google.com ([2a00:1450:4010:c07::234]:43879) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eogpy-0001vv-Vc for emacs-orgmode@gnu.org; Wed, 21 Feb 2018 21:42:23 -0500 Received: by mail-lf0-x234.google.com with SMTP id q69so5248706lfi.10 for ; Wed, 21 Feb 2018 18:42:22 -0800 (PST) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org --94eb2c1ab2642b0dc10565c3fefc Content-Type: multipart/alternative; boundary="94eb2c1ab2642b0dbd0565c3fefa" --94eb2c1ab2642b0dbd0565c3fefa Content-Type: text/plain; charset="UTF-8" `org-agenda-show-log' indicates if the the current agenda buffer has log-mode enabled. When building a new agenda buffer, it gets its value from `org-agenda-start-with-log-mode'. It is is semantically a buffer local variable: when creating a new agenda buffer you expect it to be set to the value in `org-agenda-start-with-log-mode'. However, 2e9c2d71 while fixing an issue with sticky agendas rendered the variable `org-agenda-log-mode' effectively global: toggling log mode in a given agenda buffer modifies the global default for all agenda buffers. The same reasoning holds for clockreport mode. This change ensures that a log or clockreport mode change made in one agenda buffer does not propagate to other agenda buffers, existing or new. The change is however preserved on org-agenda-redo in the initial agenda buffer, whether using sticky agendas or not. Nicolas --94eb2c1ab2642b0dbd0565c3fefa Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
`org-agenda-show-log' indicates if the the curren= t agenda buffer has
log-mode enabled.=C2=A0 When building a new agenda b= uffer, it gets its
value from `org-agenda-start-with-log-mode'.=C2= =A0 It is is semantically a
buffer local variable: when creating a new a= genda buffer you expect it
to be set to the value in `org-agenda-start-w= ith-log-mode'.=C2=A0 However,
2e9c2d71 while fixing an issue with st= icky agendas rendered the
variable `org-agenda-log-mode' effectively= global: toggling log mode
in a given agenda buffer modifies the global = default for all agenda
buffers.=C2=A0 The same reasoning holds for clock= report mode.

This change ensures that a log or clockreport mode chan= ge made in one
agenda buffer does not propagate to other agenda buffers,= existing or
new.=C2=A0 The change is however preserved on org-agenda-re= do in the
initial agenda buffer, whether using sticky agendas or not.
Nicolas



--94eb2c1ab2642b0dbd0565c3fefa-- --94eb2c1ab2642b0dc10565c3fefc Content-Type: application/octet-stream; name="0001-org-agenda-make-log-and-clockreport-modes-local.patch" Content-Disposition: attachment; filename="0001-org-agenda-make-log-and-clockreport-modes-local.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jdxwjiwi0 RnJvbSA3MzYxNTAxOWFkYzVmNTUyMTVjZDBjZWRkZTcyYWVhOTc2MjRlY2U0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOaWNvbGFzIER1ZGVib3V0IDxuaWNvbGFzLmR1ZGVib3V0QGdt YWlsLmNvbT4KRGF0ZTogV2VkLCAyMSBGZWIgMjAxOCAyMDo0MzoyNCAtMDUwMApTdWJqZWN0OiBb UEFUQ0hdIG9yZy1hZ2VuZGE6IG1ha2UgbG9nIGFuZCBjbG9ja3JlcG9ydCBtb2RlcyBsb2NhbAoK KiBsaXNwL29yZy1hZ2VuZGEuZWwgKG9yZy1hZ2VuZGEtbW9kZSk6IE9ubHkgc2V0IGBvcmctYWdl bmRhLXNob3ctbG9nJwogIGFuZCBgb3JnLWFnZW5kYS1jbG9jay1yZXBvcnQtbW9kZScgdG8gdGhl aXIgZGVmYXVsdCB2YWx1ZXMgd2hlbgogIGNvbnN0cnVjdGluZyBhbiBhZ2VuZGEgYnVmZmVyLCBh bmQgbm90IHdoZW4gcmVkb2luZyBpdC4KKiBsaXNwL29yZy1hZ2VuZGEuZWwgKG9yZy1hZ2VuZGEt bG9nLW1vZGUsCiAgb3JnLWFnZW5kYS1jbG9ja3JlcG9ydC1tb2RlKTogRG8gbm90IHNldCB0aGUg Z2xvYmFsIGRlZmF1bHQgdmFsdWUKICBgb3JnLWFnZW5kYS1zdGFydC13aXRoLWxvZy1tb2RlJyAo cmVzcGVjdGl2ZWx5CiAgYG9yZy1hZ2VuZGEtc3RhcnQtd2l0aC1jbG9ja3JlcG9ydC1tb2RlJykg d2l0aCB0aGUgY3VycmVudCB2YWx1ZSBvZgogIGBvcmctYWdlbmRhLWxvZy1tb2RlJyAocmVzcGVj dGl2ZWx5IGBvcmctYWdlbmRhLWNsb2NrcmVwb3J0LW1vZGUnKSwKICB3aGljaCwgd2l0aCBzdGlj a3kgYWdlbmRhcyBpcyBldmVuIGJ1ZmZlciBsb2NhbC4KCmBvcmctYWdlbmRhLXNob3ctbG9nJyBp bmRpY2F0ZXMgaWYgdGhlIHRoZSBjdXJyZW50IGFnZW5kYSBidWZmZXIgaGFzCmxvZy1tb2RlIGVu YWJsZWQuICBXaGVuIGJ1aWxkaW5nIGEgbmV3IGFnZW5kYSBidWZmZXIsIGl0IGdldHMgaXRzCnZh bHVlIGZyb20gYG9yZy1hZ2VuZGEtc3RhcnQtd2l0aC1sb2ctbW9kZScuICBJdCBpcyBpcyBzZW1h bnRpY2FsbHkgYQpidWZmZXIgbG9jYWwgdmFyaWFibGU6IHdoZW4gY3JlYXRpbmcgYSBuZXcgYWdl bmRhIGJ1ZmZlciB5b3UgZXhwZWN0IGl0CnRvIGJlIHNldCB0byB0aGUgdmFsdWUgaW4gYG9yZy1h Z2VuZGEtc3RhcnQtd2l0aC1sb2ctbW9kZScuICBIb3dldmVyLAoyZTljMmQ3MSB3aGlsZSBmaXhp bmcgYW4gaXNzdWUgd2l0aCBzdGlja3kgYWdlbmRhcyByZW5kZXJlZCB0aGUKdmFyaWFibGUgYG9y Zy1hZ2VuZGEtbG9nLW1vZGUnIGVmZmVjdGl2ZWx5IGdsb2JhbDogdG9nZ2xpbmcgbG9nIG1vZGUK aW4gYSBnaXZlbiBhZ2VuZGEgYnVmZmVyIG1vZGlmaWVzIHRoZSBnbG9iYWwgZGVmYXVsdCBmb3Ig YWxsIGFnZW5kYQpidWZmZXJzLiAgVGhlIHNhbWUgcmVhc29uaW5nIGhvbGRzIGZvciBjbG9ja3Jl cG9ydCBtb2RlLgoKVGhpcyBjaGFuZ2UgZW5zdXJlcyB0aGF0IGEgbG9nIG9yIGNsb2NrcmVwb3J0 IG1vZGUgY2hhbmdlIG1hZGUgaW4gb25lCmFnZW5kYSBidWZmZXIgZG9lcyBub3QgcHJvcGFnYXRl IHRvIG90aGVyIGFnZW5kYSBidWZmZXJzLCBleGlzdGluZyBvcgpuZXcuICBUaGUgY2hhbmdlIGlz IGhvd2V2ZXIgcHJlc2VydmVkIG9uIG9yZy1hZ2VuZGEtcmVkbyBpbiB0aGUKaW5pdGlhbCBhZ2Vu ZGEgYnVmZmVyLCB3aGV0aGVyIHVzaW5nIHN0aWNreSBhZ2VuZGFzIG9yIG5vdC4KLS0tCiBsaXNw L29yZy1hZ2VuZGEuZWwgfCA4ICsrKy0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25z KCspLCA1IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3Avb3JnLWFnZW5kYS5lbCBiL2xp c3Avb3JnLWFnZW5kYS5lbAppbmRleCA2N2Y1OTA3MzEuLjgxYzM3ZjZiYSAxMDA2NDQKLS0tIGEv bGlzcC9vcmctYWdlbmRhLmVsCisrKyBiL2xpc3Avb3JnLWFnZW5kYS5lbApAQCAtMjIzMCw5ICsy MjMwLDkgQEAgVGhlIGZvbGxvd2luZyBjb21tYW5kcyBhcmUgYXZhaWxhYmxlOgogCSAgICBuaWwg dCkKICAgKHVubGVzcyBvcmctYWdlbmRhLWtlZXAtbW9kZXMKICAgICAoc2V0cSBvcmctYWdlbmRh LWZvbGxvdy1tb2RlIG9yZy1hZ2VuZGEtc3RhcnQtd2l0aC1mb2xsb3ctbW9kZQotCSAgb3JnLWFn ZW5kYS1lbnRyeS10ZXh0LW1vZGUgb3JnLWFnZW5kYS1zdGFydC13aXRoLWVudHJ5LXRleHQtbW9k ZSkpCi0gIChzZXRxIG9yZy1hZ2VuZGEtc2hvdy1sb2cgb3JnLWFnZW5kYS1zdGFydC13aXRoLWxv Zy1tb2RlKQotICAoc2V0cSBvcmctYWdlbmRhLWNsb2NrcmVwb3J0LW1vZGUgb3JnLWFnZW5kYS1z dGFydC13aXRoLWNsb2NrcmVwb3J0LW1vZGUpCisJICBvcmctYWdlbmRhLWVudHJ5LXRleHQtbW9k ZSBvcmctYWdlbmRhLXN0YXJ0LXdpdGgtZW50cnktdGV4dC1tb2RlCisJICBvcmctYWdlbmRhLXNo b3ctbG9nIG9yZy1hZ2VuZGEtc3RhcnQtd2l0aC1sb2ctbW9kZQorCSAgb3JnLWFnZW5kYS1jbG9j a3JlcG9ydC1tb2RlIG9yZy1hZ2VuZGEtc3RhcnQtd2l0aC1jbG9ja3JlcG9ydC1tb2RlKSkKICAg KGFkZC10by1pbnZpc2liaWxpdHktc3BlYyAnKG9yZy1maWx0ZXJlZCkpCiAgIChhZGQtdG8taW52 aXNpYmlsaXR5LXNwZWMgJyhvcmctbGluaykpCiAgIChlYXN5LW1lbnUtY2hhbmdlCkBAIC04MjA0 LDcgKzgyMDQsNiBAQCBzbyB0aGF0IHRoZSBkYXRlIFNEIHdpbGwgYmUgaW4gdGhhdCByYW5nZS4i CiAgIChpbnRlcmFjdGl2ZSkKICAgKG9yZy1hZ2VuZGEtY2hlY2stdHlwZSB0ICdhZ2VuZGEpCiAg IChzZXRxIG9yZy1hZ2VuZGEtY2xvY2tyZXBvcnQtbW9kZSAobm90IG9yZy1hZ2VuZGEtY2xvY2ty ZXBvcnQtbW9kZSkpCi0gIChzZXRxIG9yZy1hZ2VuZGEtc3RhcnQtd2l0aC1jbG9ja3JlcG9ydC1t b2RlIG9yZy1hZ2VuZGEtY2xvY2tyZXBvcnQtbW9kZSkKICAgKG9yZy1hZ2VuZGEtc2V0LW1vZGUt bmFtZSkKICAgKG9yZy1hZ2VuZGEtcmVkbykKICAgKG1lc3NhZ2UgIkNsb2NrdGFibGUgbW9kZSBp cyAlcyIKQEAgLTgyMjgsNyArODIyNyw2IEBAIGxvZyBpdGVtcywgbm90aGluZyBlbHNlLiIKIAkg ICAgICBuaWwgJ2Nsb2NrY2hlY2spKQogCSAoc3BlY2lhbCAnKGNsb3NlZCBjbG9jayBzdGF0ZSkp CiAJICh0IChub3Qgb3JnLWFnZW5kYS1zaG93LWxvZykpKSkKLSAgKHNldHEgb3JnLWFnZW5kYS1z dGFydC13aXRoLWxvZy1tb2RlIG9yZy1hZ2VuZGEtc2hvdy1sb2cpCiAgIChvcmctYWdlbmRhLXNl dC1tb2RlLW5hbWUpCiAgIChvcmctYWdlbmRhLXJlZG8pCiAgIChtZXNzYWdlICJMb2cgbW9kZSBp cyAlcyIgKGlmIG9yZy1hZ2VuZGEtc2hvdy1sb2cgIm9uIiAib2ZmIikpKQotLSAKMi4xNi4xCgo= --94eb2c1ab2642b0dc10565c3fefc--