Hi again! The FSA-assignment is now complete. New patches are attached
and comments below.

On Sat, Jan 31, 2015 at 9:41 AM, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:

>> I suppose an FSF-assignment signature is needed before it can be
>> included.

> Indeed.

Marked as done now, as stated above :-)

>> - Grouptags don't have to be unique on a headline if added with [ ]
>>   instead of with { }: ,---- | #+TAGS: [ group : include1 included2 ]
>>   `----

> I'd rather not introduce yet another syntax for group tags. IIUC, the
> current one (with curly braces) can be extended.

> Also, I don't get the "have to be unique on a headline" part.

The reason for the use of [ ] is because { } already has another purpose
- it is used to make the tags within { } exclusive.

this example

,----
| #+TAGS: { group : include1 include2 }
`----

will only allow one of the tags on any specific headline. [ ] solves
this. Note that grouptags doesn't care if { } or [ ] is used. The only
difference is the exclusiveness. I.e both

,----
| #+TAGS: [ group : include1 include2 ]
| #+TAGS: { group : include1 include2 }
`----

will work. With some limitations on the second example due to the way {
} works since before.

>>   A new variable is defined `ORG-GROUP-TAGS-MAX-DEPTH' that is used
>>   to limit the depth of recursion when expanding tags. It defaults to
>>   2.

> I don't think this variable is necessary. However, a check for
> circular inclusions would be necessary.

Indeed. The variable is removed and the function `org-tags-expand' now
handles circular definitions with grace ;-)

Best regards
Gustav Wikström