From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Hendy Subject: Re: [BUG] ox-taskjuggler: unable to use depends {gapduration} Date: Wed, 5 Nov 2014 18:41:02 -0600 Message-ID: References: <871tpiys4f.fsf@sbs.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41502) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XmB8L-0003Mz-5j for emacs-orgmode@gnu.org; Wed, 05 Nov 2014 19:41:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XmB8J-0002NM-VN for emacs-orgmode@gnu.org; Wed, 05 Nov 2014 19:41:05 -0500 Received: from mail-lb0-x232.google.com ([2a00:1450:4010:c04::232]:35545) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XmB8J-0002N7-Ir for emacs-orgmode@gnu.org; Wed, 05 Nov 2014 19:41:03 -0500 Received: by mail-lb0-f178.google.com with SMTP id f15so41369lbj.23 for ; Wed, 05 Nov 2014 16:41:02 -0800 (PST) In-Reply-To: <871tpiys4f.fsf@sbs.ch> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Christian Egli Cc: emacs-orgmode On Wed, Nov 5, 2014 at 2:21 AM, Christian Egli wrot= e: > John Hendy writes: > >> I ran into an odd issue with a taskjuggler task tree I'm working on >> when trying to apply a gapduration attribute to a task dependency. >> Typically, I can just pass any valid taskjuggler attribute through >> using properties, but my export was producing an error when trying to >> use: >> >> :depends: task {gapduration 1h} >> >> Oddly, the output is as follows (task section): >> >> #+begin_src test.tjp >> >> task test "test" { >> task task1 "task1" { >> milestone >> start 2014-11-05-08:00 >> } >> task task2 "task2" { >> depends !task1 t :taskjuggl >> duration 1h >> } >> #+end_src >> >> For some reason it's grabbing the taskjuggler tag! I tried with the >> example in ox-taskjuggler.el with the same result. >> >> Is this a bug or am I mis-interpreting how this would work? > > No it is indeed a bug. At first I thought this was simply no longer > working in the new exporter but I was wrong. Nicolas of course > implemented it and way more. But there is a subtle bug. I actually found > it because I wondered about the funny "t :taskjuggl" in the output. > Here's the fix. > > diff --git a/contrib/lisp/ox-taskjuggler.el b/contrib/lisp/ox-taskjuggler= .el > index 807d702..9e977f6 100644 > --- a/contrib/lisp/ox-taskjuggler.el > +++ b/contrib/lisp/ox-taskjuggler.el > @@ -600,7 +600,7 @@ doesn't include leading \"depends\"." > (let ((id (org-element-property :TASK_ID dep))) > (and id > (string-match (concat id " +\\({.*?}\\)") dep-s= tr) > - (org-match-string-no-properties 1)))) > + (org-match-string-no-properties 1 dep-str)))) > path) > ;; Compute number of exclamation marks by looking for the > ;; common ancestor between TASK and DEP. > For some reason, I couldn't apply the patch... since it was just one line, I manually changed it myself and can report that this appears to work now. I re-added the {gapduration x} lines to my :depends: properties and they're being properly applied now. Thanks a ton for the quick turnaround! If/when you apply this, could you post back and I'll checkout a fresh version of ox-taskjuggler to take the official commit? Best regards, John > Nicolas, I can push this myself but I haven't pushed to the repo in > years. What is the current way? Do I just push to master? > > Thanks > Christian > -- > Christian Egli > Swiss Library for the Blind, Visually Impaired and Print Disabled > Grubenstrasse 12, CH-8045 Z=C3=BCrich, Switzerland > >