emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: John Hendy <jw.hendy@gmail.com>
To: "Thomas S. Dye" <tsd@tsdye.com>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: Assistance with patching instructions on Worg
Date: Fri, 31 Jan 2014 15:58:31 -0600	[thread overview]
Message-ID: <CA+M2ft9cheEfG5KHpFHq7=dv7Jz3p65UjzddG9J50wDzbT1hSA@mail.gmail.com> (raw)
In-Reply-To: <m1zjmbkehr.fsf@tsdye.com>

On Fri, Jan 31, 2014 at 3:50 PM, Thomas S. Dye <tsd@tsdye.com> wrote:
> Hi John,
>
> John Hendy <jw.hendy@gmail.com> writes:
>
>> Greetings,
>>
>>
>> I've only contributed to Worg, not the Org manual. I want to submit a
>> change to the documentation per an earlier discussion.[1] I'm
>> attempting to follow the Worg suggestion for submitting patches.[2]
>>
>> Here was my process
>>
>> cd ~/.elisp/org.git
>> git pull
>> make clean && make
>>
>> git branch org-src-preserve-whitespace
>> git checkout org-src-preserve-whitespace
>>
>> emacs doc/org.texi
>>
>> [make changes to documentation]
>>
>> git commit -m "Update documentation to org-src-preserve-indentation."
>>
>> git format-patch master
>
> Here is what I do:
>
>  1. commit your changes to your local copy of the org-mode repository
>
>  2. run the following command to wrap up the latest commit on your
>        local copy of the repository into a file which can be attached
>        to email messages
>
>            git format-patch -o ~/temp/ HEAD~1
>
>        after the command finished you will notice a new file in ~/temp
>        with a name like 0001-commit-message-stuff.patch
>

I can try that, though I'll have to try and figure out how to "un git
commit -am" my file so that I can see if it works with just having
done "git commit -m". Otherwise, I'll just futz with another file and
try your process.

Based on the Worg instructions... is your way preferred, or was
anything wrong with my process such that Worg's instructions *should
have* worked? It seems that they wouldn't work as-is, so if that's the
case, I'll update Worg with the best practice per the list's input.


John

> hth,
> Tom
>
> --
> Thomas S. Dye
> http://www.tsdye.com

  reply	other threads:[~2014-01-31 21:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-31 21:33 Assistance with patching instructions on Worg John Hendy
2014-01-31 21:50 ` Thomas S. Dye
2014-01-31 21:58   ` John Hendy [this message]
2014-01-31 22:23 ` Josiah Schwab
2014-01-31 22:34   ` John Hendy
2014-01-31 22:51     ` Nick Dokos
2014-01-31 22:57     ` Josiah Schwab
2014-01-31 22:59       ` John Hendy
2014-02-02 15:27         ` John Hendy
2014-02-02 17:28           ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+M2ft9cheEfG5KHpFHq7=dv7Jz3p65UjzddG9J50wDzbT1hSA@mail.gmail.com' \
    --to=jw.hendy@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=tsd@tsdye.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).