* [BUG] org-cycle on hidden inline task makes also other inline tasks visible
@ 2013-09-05 11:33 Jonas Hörsch
2013-09-06 1:23 ` John Hendy
2013-10-29 16:46 ` [PATCH] " Jonas Hörsch
0 siblings, 2 replies; 6+ messages in thread
From: Jonas Hörsch @ 2013-09-05 11:33 UTC (permalink / raw)
To: emacs-orgmode
[-- Attachment #1.1: Type: text/plain, Size: 524 bytes --]
hello everyone,
just found a strange behaviour of inline tasks:
calling org-cycle in a situation like
* Heading1
*************** inline1...
*************** inline2...
*************** inline3...
* Heading2
*************** inline4...
with point on the inline2 heading results in
* Heading1
*************** inline1...
*************** inline2
*************** END
*************** inline3
*************** END
* Heading2
*************** inline4...
tested with emacs -Q on org-mode's master branch of sep 3rd.
cheers,
jonas
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: min.org --]
[-- Type: text/x-org, Size: 201 bytes --]
* Heading1
*************** inline1
*************** END
*************** inline2
*************** END
*************** inline3
*************** END
* Heading2
*************** inline4
*************** END
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [BUG] org-cycle on hidden inline task makes also other inline tasks visible
2013-09-05 11:33 [BUG] org-cycle on hidden inline task makes also other inline tasks visible Jonas Hörsch
@ 2013-09-06 1:23 ` John Hendy
2013-10-29 16:46 ` [PATCH] " Jonas Hörsch
1 sibling, 0 replies; 6+ messages in thread
From: John Hendy @ 2013-09-06 1:23 UTC (permalink / raw)
To: Jonas Hörsch; +Cc: emacs-orgmode
On Thu, Sep 5, 2013 at 6:33 AM, Jonas Hörsch <coroa@online.de> wrote:
> hello everyone,
>
> just found a strange behaviour of inline tasks:
>
> calling org-cycle in a situation like
>
> * Heading1
> *************** inline1...
> *************** inline2...
> *************** inline3...
> * Heading2
> *************** inline4...
>
> with point on the inline2 heading results in
>
> * Heading1
> *************** inline1...
> *************** inline2
> *************** END
> *************** inline3
> *************** END
> * Heading2
> *************** inline4...
>
I can confirm on 8.0.7. Unfolding an inline task appears to unfold all
inline headlines below it.
John
> tested with emacs -Q on org-mode's master branch of sep 3rd.
>
> cheers,
> jonas
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] Re: [BUG] org-cycle on hidden inline task makes also other inline tasks visible
2013-09-05 11:33 [BUG] org-cycle on hidden inline task makes also other inline tasks visible Jonas Hörsch
2013-09-06 1:23 ` John Hendy
@ 2013-10-29 16:46 ` Jonas Hörsch
2013-10-29 20:02 ` Nicolas Goaziou
1 sibling, 1 reply; 6+ messages in thread
From: Jonas Hörsch @ 2013-10-29 16:46 UTC (permalink / raw)
To: emacs-orgmode
[-- Attachment #1.1: Type: text/plain, Size: 178 bytes --]
hi,
ok, this has been bothering me long enough. the attached patch fixes the
issue [1] for me.
cheers,
jonas
Footnotes:
[1] http://thread.gmane.org/gmane.emacs.orgmode/76034
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-org-inlinetask-FIX-correct-inlinetask-cycling.patch --]
[-- Type: text/x-patch, Size: 1170 bytes --]
From 3073cb181f607a0cc65031fe68e86cf73347e152 Mon Sep 17 00:00:00 2001
From: Jonas Hoersch <coroa@online.de>
Date: Tue, 29 Oct 2013 17:07:49 +0100
Subject: [PATCH] org-inlinetask: [FIX] correct inlinetask cycling
org-show-entry can't be used to expand a folded inlinetask, as it relies
on org-outline-regexp to find the end of the entry, which has been
altered to exclude inline-tasks by org-cycle.
instead show the inline task directly using the bounds already computed
by org-inlinetask-toggle-visibility.
---
lisp/org-inlinetask.el | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lisp/org-inlinetask.el b/lisp/org-inlinetask.el
index 112d3df..ca7572b 100644
--- a/lisp/org-inlinetask.el
+++ b/lisp/org-inlinetask.el
@@ -315,7 +315,8 @@ If the task has an end part, also demote it."
((= end start))
;; Inlinetask was folded: expand it.
((get-char-property (1+ start) 'invisible)
- (org-show-entry))
+ (outline-flag-region start end nil)
+ (org-cycle-hide-drawers 'children))
(t (outline-flag-region start end t)))))
(defun org-inlinetask-remove-END-maybe ()
--
1.8.4
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Re: [BUG] org-cycle on hidden inline task makes also other inline tasks visible
2013-10-29 16:46 ` [PATCH] " Jonas Hörsch
@ 2013-10-29 20:02 ` Nicolas Goaziou
2013-10-29 22:38 ` Jonas Hörsch
0 siblings, 1 reply; 6+ messages in thread
From: Nicolas Goaziou @ 2013-10-29 20:02 UTC (permalink / raw)
To: Jonas Hörsch; +Cc: emacs-orgmode
Hello,
coroa@online.de (Jonas Hörsch) writes:
> ok, this has been bothering me long enough. the attached patch fixes the
> issue [1] for me.
Thank you for your patch.
> From 3073cb181f607a0cc65031fe68e86cf73347e152 Mon Sep 17 00:00:00 2001
> From: Jonas Hoersch <coroa@online.de>
> Date: Tue, 29 Oct 2013 17:07:49 +0100
> Subject: [PATCH] org-inlinetask: [FIX] correct inlinetask cycling
You need to detail which function is modified and how. E.g.:
* lisp/org-inlinetask.el (org-inlinetask-toggle-visibility): Don't use
`org-show-entry' as it cannot fold an inlinetask properly.
> org-show-entry can't be used to expand a folded inlinetask, as it relies
> on org-outline-regexp to find the end of the entry, which has been
> altered to exclude inline-tasks by org-cycle.
>
> instead show the inline task directly using the bounds already computed
> by org-inlinetask-toggle-visibility.
Also, if you haven't signed FSF papers, you need to add TINYCHANGE at
the end of the message.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Re: [BUG] org-cycle on hidden inline task makes also other inline tasks visible
2013-10-29 20:02 ` Nicolas Goaziou
@ 2013-10-29 22:38 ` Jonas Hörsch
2013-10-29 23:36 ` Nicolas Goaziou
0 siblings, 1 reply; 6+ messages in thread
From: Jonas Hörsch @ 2013-10-29 22:38 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: emacs-orgmode
[-- Attachment #1.1: Type: text/plain, Size: 255 bytes --]
Hej,
On Tue, Oct 29 2013, Nicolas Goaziou wrote:
> You need to detail which function is modified and how.
>
> Also, if you haven't signed FSF papers, you need to add TINYCHANGE at
> the end of the message.
thanks for bearing with me. is this alright?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-org-inlinetask-fix-inlinetask-unfolding.patch --]
[-- Type: text/x-patch, Size: 1010 bytes --]
From 1c6e67b06d0eb22c6d79387c8c6d07c23500f91d Mon Sep 17 00:00:00 2001
From: Jonas Hoersch <coroa@online.de>
Date: Tue, 29 Oct 2013 17:07:49 +0100
Subject: [PATCH] org-inlinetask: fix inlinetask unfolding
* lisp/org-inlinetask.el (org-inlinetask-toggle-visibility): Don't use
`org-show-entry` as it cannot unfold an inlinetask properly.
TINYCHANGE
---
lisp/org-inlinetask.el | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lisp/org-inlinetask.el b/lisp/org-inlinetask.el
index 112d3df..ca7572b 100644
--- a/lisp/org-inlinetask.el
+++ b/lisp/org-inlinetask.el
@@ -315,7 +315,8 @@ If the task has an end part, also demote it."
((= end start))
;; Inlinetask was folded: expand it.
((get-char-property (1+ start) 'invisible)
- (org-show-entry))
+ (outline-flag-region start end nil)
+ (org-cycle-hide-drawers 'children))
(t (outline-flag-region start end t)))))
(defun org-inlinetask-remove-END-maybe ()
--
1.8.4
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Re: [BUG] org-cycle on hidden inline task makes also other inline tasks visible
2013-10-29 22:38 ` Jonas Hörsch
@ 2013-10-29 23:36 ` Nicolas Goaziou
0 siblings, 0 replies; 6+ messages in thread
From: Nicolas Goaziou @ 2013-10-29 23:36 UTC (permalink / raw)
To: Jonas Hörsch; +Cc: emacs-orgmode
Jonas Hörsch <coroa@online.de> writes:
> On Tue, Oct 29 2013, Nicolas Goaziou wrote:
>
>> You need to detail which function is modified and how.
>>
>> Also, if you haven't signed FSF papers, you need to add TINYCHANGE at
>> the end of the message.
>
> thanks for bearing with me. is this alright?
It is. I applied your patch. Thank you.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-10-29 23:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-05 11:33 [BUG] org-cycle on hidden inline task makes also other inline tasks visible Jonas Hörsch
2013-09-06 1:23 ` John Hendy
2013-10-29 16:46 ` [PATCH] " Jonas Hörsch
2013-10-29 20:02 ` Nicolas Goaziou
2013-10-29 22:38 ` Jonas Hörsch
2013-10-29 23:36 ` Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).