From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id sAIZIIyGkWIwNwAAbAwnHQ (envelope-from ) for ; Sat, 28 May 2022 04:18:52 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 0OsUIIyGkWL1/wAA9RJhRA (envelope-from ) for ; Sat, 28 May 2022 04:18:52 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 40F673EDF1 for ; Sat, 28 May 2022 04:18:52 +0200 (CEST) Received: from localhost ([::1]:51218 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1num2V-00016R-5c for larch@yhetil.org; Fri, 27 May 2022 22:18:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57702) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1num1r-00016F-Jk for emacs-orgmode@gnu.org; Fri, 27 May 2022 22:18:11 -0400 Received: from mail-yb1-xb2b.google.com ([2607:f8b0:4864:20::b2b]:33785) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1num1p-0002CT-Vp for emacs-orgmode@gnu.org; Fri, 27 May 2022 22:18:11 -0400 Received: by mail-yb1-xb2b.google.com with SMTP id v106so3632919ybi.0 for ; Fri, 27 May 2022 19:18:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=13EnbUOp2om//VF7KJfMTgvCxkrdH6/CeX5zxTe5XU0=; b=CFDxFE/vaw8BkypKatz7qPIviiPmiJzb14iV2dRR3u8mK+Sa+YUDuz9riK2IJrB4mE Z7oGrLxHdapo4SEEXLaSuKmdMGQoMe5NbPQo1OkgwVEO93FdRKTKNsac9xzgq9egCgd4 /ZzIeRUahcJ3r12qQknBzHgCFclCzNwiXpo15/Vf//514/i0p0niJ2XqFsQKfYH+a179 etQPb7r8DriHjdLWnX76Xl0lXjAC47hpGeF5+HnSNgnM7dEB5hF3smt6F6plyw8/w9ZL ZXMgEhHScv+VwbCTnyAO/5LmoRlsPN6700oSpUd6oOSkcN7AS8aJpMsccCRCzHi+umBW ++ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=13EnbUOp2om//VF7KJfMTgvCxkrdH6/CeX5zxTe5XU0=; b=YqhIH5f6qyP59GDVcfsIK/XSi3ZF/iJcu0axc8QfJWI1WNsVv7Wuh96IlZRctDgANj 0mkJ2zI9XSlcwf1iM2/UOALSyAFdNUYkSoZWc27zp1Opof+88hVqt4sgFvVl9r2PkHJQ flKMSNX8lWmIPUrVkE34GcahU4rCsED6pzib2eNPLm0Rp5VW2KqHganjoVfbOlisoX3Y 7xm1aOhm/JYhdaEP0ha9mXpm++yHDzCzlUujYgXC5RZ6YoTnf9UWZAY/6H4RLvn+sIKU MdDwZEcHrLCgJojPfkp6fmmJydga2WcT2Dfi6oyB3WKiA9Cu9UGRx8AgdNJ3vFSn++nf CfYQ== X-Gm-Message-State: AOAM530FjuidUuMfEieOxdDMRWBF//gId+a24HkWtWRIKCMSkSd+SaKU VmBK2dPkAiNDUvY5o5kIu8dQR4jYe2epbJZOxhOVZBP1NCE= X-Google-Smtp-Source: ABdhPJyPZF08vjiLt9YyZ+zlW63SspNQjoo2ph/6bOslgLXvP52P1HV7oYQu4bivvfmaSvUFU8faDuzo8W0yLuf/Hak= X-Received: by 2002:a5b:14f:0:b0:656:b905:7cb4 with SMTP id c15-20020a5b014f000000b00656b9057cb4mr11409743ybp.386.1653704288329; Fri, 27 May 2022 19:18:08 -0700 (PDT) MIME-Version: 1.0 References: <87y2cvloay.fsf@gnu.org> <149145640c25d2ae191ab87c7056e372f9904370.1643454546.git.yantar92@gmail.com> <87sfpphkfc.fsf@localhost> In-Reply-To: <87sfpphkfc.fsf@localhost> From: Tom Gillespie Date: Fri, 27 May 2022 19:17:57 -0700 Message-ID: Subject: Re: [BUG] 67275f4 broke evil-search Re: [PATCH 10/35] Implement link folding To: Ihor Radchenko Cc: emacs-orgmode Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::b2b; envelope-from=tgbugs@gmail.com; helo=mail-yb1-xb2b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1653704332; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=13EnbUOp2om//VF7KJfMTgvCxkrdH6/CeX5zxTe5XU0=; b=VTrlvqm6lEliA/nW56hzQVuboQL8fOcrv3lV3QHArdj+f/Q6A60Du10/BIIOKZSE9kvSz7 IfG9Tg3LX7SZAvtJA+GqJBm7iwMLDmGpQJNNvNIQ2OV7QdxBLx4zGFL0c/1BU4zpNQf8bi 5JGRPCkV/Cs6dKTEBkyTBKdstTr1r9+4yhdYTDOIubNIZGYzd3oSTLyfdbkire0Qsyv/hX aRL33KTGSsQGqeDy4GwJpbmJZyO43BZClP4Y5skbnc7n9tVOuTj899BOX8WWKOR0uYMxjk 4KGPnG+tX/lrfR4QuuijQmx7iGsADUlqeyPtlL9e3I6GC+ZjUnCZ/xGPGp0dFQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1653704332; a=rsa-sha256; cv=none; b=NHRiyP6HOGD/zToQbsUPRSTR4pKYpOA6BmepHIiiCLrMM6sowzKHf5g7OOKD/07sgUfKGJ 8V/bQWG7Txw6iAV/FO3fk6CCp1xX2hXe1SstRD5f/CDao5UrBr7N5q9OfQAueq1g3oQOrK k1HqXulQbKsbPPvPhw6basFK4bgRW/IGcDlEjnZsWQ8q7rJCuzEy0l+OL+VN+1vJlmYvQd WToSNIXMtUhfJLrHRGjhxzpydx14pG/tifgu7+gr195LBCZIHl/2WEnICLxvgXGmIZurbh 8qUUQZQE+rc7jAHG2OUefBoU6iStHQebdFThWYFaOpkcS7i4eucQ0eND5odgkw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="CFDxFE/v"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.54 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="CFDxFE/v"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 40F673EDF1 X-Spam-Score: -2.54 X-Migadu-Scanner: scn1.migadu.com X-TUID: KVDFo3HVhbou > It appears to respect isearch-filter-predicate, but not > isearch-mode-end-hook. This is true only when isearch is used as the module via (evil-select-search-module 'evil-search-module 'isearch), and indeed, when using evil search in that way headings no longer refold. When using evil-search, things won't even unfold. I think that I have tracked the issue down to evil-ex-find-next in a call to isearch-range-invisible which returns nil for commits < 67275f4, and t for >=. When isearch-range-invisible returns nil the invisible overlay is made visible, when it returns t it stays closed. Might restoring the invisible overlay text property restore the old behavior? Is there a reason it was removed? Best, Tom