From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 0JiuGo541V92fgAA0tVLHw (envelope-from ) for ; Sun, 13 Dec 2020 02:12:30 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id GGd5Fo541V89JQAA1q6Kng (envelope-from ) for ; Sun, 13 Dec 2020 02:12:30 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 091D89402AC for ; Sun, 13 Dec 2020 02:12:30 +0000 (UTC) Received: from localhost ([::1]:54338 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1koGs8-0005VV-Uw for larch@yhetil.org; Sat, 12 Dec 2020 21:12:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53942) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1koGrY-0005VP-Qr for emacs-orgmode@gnu.org; Sat, 12 Dec 2020 21:11:52 -0500 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:41699) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1koGrX-0000zV-Fn; Sat, 12 Dec 2020 21:11:52 -0500 Received: by mail-wr1-x42f.google.com with SMTP id a12so12891846wrv.8; Sat, 12 Dec 2020 18:11:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oP8vamCOj5gJxbrHdFzxMmhTE2cq2VAQ/p0BM9GtkXQ=; b=K+wv+xovQE0Mbab2VGwdADu8HxYPEaPp9r6Qamd861tsx+WJn+Jz//WU1K2RdW+E2m OqZmmqXzhuOe32u997pPPSjfYCmxeSwSltPAmyrx42u96OOLQ69j2PU4GaY/Vr4bYYmB HqquBm+s5NMGgtOGjausovmpkuI8Hkq5zo6+vcJ+0IehSBmRVCcpxltQ4D+GfntQZ5US aOhFvZ+bMs1l5FBmmAz5Uumnr9oomgnJsc2p8EKxqXMWSt2QRIxGIMvGk7l4pvWr/V8M PXI4rpV+9PraLDgKR7zsLIOPMW7mBn4DZK7hVXTkTu0/DNv143MPzAE0IqKF8ctes3og j+zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oP8vamCOj5gJxbrHdFzxMmhTE2cq2VAQ/p0BM9GtkXQ=; b=HThZKokcMhG52PuvYnj1HzdP4/USmCKY4rbJFKaYvwOsED+pE7MLBxQoTy86Dh9wd1 K37aAf8EI0ECdowA1LV/wt99GaAYSWL/7NQF77IZp4UP6juL/2fvEoQGrCp6eA7L3M17 6+UrdIkNofUuMqcJtVc/ICflZalBJ5kVPzN3R6Q0Z2wEsuj5+oW3ZeKB9mrpa0IBfHP5 hfDxQHgQ352B4Gl4KSekxgRaQZsn0SEpi9sdBd+X2Y3O3vl0SeBIvjF1OQUZh3HJDcX2 DiBeCIyaqTSw/KjOr7xYuvDU30gPpc7VHvx4tLR6GXFEi9kuN4naDpJ2NQ8gxqxFDDtB BAvA== X-Gm-Message-State: AOAM533N2JI6p3kptGZeXF1e02HbmR+EcGl+v/7o/dzSFaRwKe383LGu TNZijGfxkgy5PBVZeLGnCEVFbsUwKcnOWjx6mcI= X-Google-Smtp-Source: ABdhPJyUbAIP7qif8bjLRg0jNvU8O5sTUsJ/CzC94mOuR0Lxf6z2gW3VS/EvZRo/5PcUCQKkTi7g0DuINWRrt2hSCz8= X-Received: by 2002:a5d:51c4:: with SMTP id n4mr21417257wrv.67.1607825509082; Sat, 12 Dec 2020 18:11:49 -0800 (PST) MIME-Version: 1.0 References: <87lfe2aosn.fsf@gnu.org> <877dpm7e3d.fsf@localhost> <87wnxm5xyh.fsf@localhost> In-Reply-To: <87wnxm5xyh.fsf@localhost> From: Tom Gillespie Date: Sat, 12 Dec 2020 21:11:37 -0500 Message-ID: Subject: Re: Bug fix attached: org-babel sql postgres, fix hardcode To: Ihor Radchenko Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=tgbugs@gmail.com; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bastien , emacs-orgmode , Alan Light Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.20 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=gmail.com header.s=20161025 header.b=K+wv+xov; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 091D89402AC X-Spam-Score: -1.20 X-Migadu-Scanner: scn1.migadu.com X-TUID: MqK+vvZEqYqB It looks like the two patches are sequential, there should probably be a rebase into a single patch. I would remove the comment in the second patch because it is a single command to jump to the default value and it might change in the future, so no reason to put it in a comment. One way to communicate about the source of that variable is to include (require 'sql) in ob-sql which is likely needed anyway due to the fact that sql-postgres-program is defined by sql.el and there will be a byte compiler error because the variable is undefined. Having the value of "psql" present as a backup in case sql-postgres-program is somehow nil seems reasonable. Best, Tom