From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id EL/YOXrn22TjHQAASxT56A (envelope-from ) for ; Tue, 15 Aug 2023 23:00:43 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id qEmiOXrn22R6dAAAauVa8A (envelope-from ) for ; Tue, 15 Aug 2023 23:00:42 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 74A10335F6 for ; Tue, 15 Aug 2023 23:00:42 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=BZDeC0XT; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1692133242; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=k4GxNP1QC7lepddldDfm0ny3QM6yCpgPky37U79AdWE=; b=HGdjQy4vN6sFvUo7E1gixtGpY0QyY5pm1NUWZWqA6S4L4W+Ji1jJTtwLkodeQGbRk8h7If zUBstP8TuFU/6dOGLbPiVoKxQ2R2USXSl/meTFkqEK++PnxX7NeZKPtzhtu5NGNJcjFiOG dL+C6rJ/RBjHQeLRY+sx7vlEj1tPFtOVqjNaGQrEMqcgqtRRE1DpyUmZaxOjSSIupzcs1D iRMUNsnX2O/HjA7ShUjfGWwsklFmerXQ7TEndkFBi/rtiYWmx4gLgKy9S0FVP95iGAkG1f dqqJGfMFgT7Zf0ivdeCEKS90r+dzQSdZRP0wp8QfU+dv7R4/vruPDxcpkZNPDw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=BZDeC0XT; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1692133242; a=rsa-sha256; cv=none; b=Y6ZcMT1KFGY59LzwK/I60KaLEPwB6YCaU9/OaOh+pOQoGr1U0aC7ZC8t38fVH2A8p2nq+S ltFTI1Kjc7JX4+aZ3NA1A3pZQhYwwQVC+YZ59TN1s9Cc0CN3bHYhkQOOeFzS/GjNxeK8vP YULWWg7ln/4ySnHinomkOzxgqYPGjDL7bXyYONIIoY8NqaelScCjawTIDXGbQg3a8ZNdiS tuQxANJQHdAoec5L2BV1+bfd46WuNNLcKZhyby6jKdUIzmCYKUVoOIBHh6QlNqOcQSl6GP PJUYSlES3F0DCJEGf2AIukXAJNxg93RVJLL5cdsjiSwNZ+Ti7cTyrgpXScnUgA== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qW18r-000810-2P; Tue, 15 Aug 2023 16:59:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qW18X-0007v9-VW for emacs-orgmode@gnu.org; Tue, 15 Aug 2023 16:59:37 -0400 Received: from mail-pg1-x534.google.com ([2607:f8b0:4864:20::534]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qW18U-00063X-Ce for emacs-orgmode@gnu.org; Tue, 15 Aug 2023 16:59:33 -0400 Received: by mail-pg1-x534.google.com with SMTP id 41be03b00d2f7-563f8e8a53dso3359521a12.3 for ; Tue, 15 Aug 2023 13:59:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692133160; x=1692737960; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=k4GxNP1QC7lepddldDfm0ny3QM6yCpgPky37U79AdWE=; b=BZDeC0XTCP1WlYZds6C5HXVjJooChSl5r4HhfovtjuG2QkzYv8PylEJgv9kSjyahBK bblZg8psqlJf+mZ7HAsc5peB3V0oHuz3+Q6zEX1YWH7GKrhVv5nMev62d7q+p1gBk/IZ c9iSXilf+kfygcCo65QGh+Cu6VUQDHH+CtLXziRunVepqz6cywA2Kv63Bbi/v7lq8scE 0JsKqQVCS5Snf+7BSSIh1/jfkG5dmeqgjxOzeSL7pbMDdNJT7LDRuGq9uCrnuIlHKxOr aPXXvpdQ4BWYBc98h/A1l5Zw4VbGnV1an+OgWLtfHdCWJihqy8OBFJlX5nE56O3tnrJv MYBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692133160; x=1692737960; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=k4GxNP1QC7lepddldDfm0ny3QM6yCpgPky37U79AdWE=; b=BDEMPNC4VAI4wmCYtRDjRqGGmVs/mVcw8BzCO9diISrHTu7FJUXmWMP9Tesjk44IHv gWdsRyr5SEcpWWCfocGXupnDS76rSG1U8XZjr8mlrqIrZJ6SY+DnRhx45zncPzV/e4OP ksknwqWhYV8pzC5Fw96gJm23lR8qpU9VJuSNcJcWyocddht/GPnpVm8F64XN/GFiBwSZ FNaBoJCEgTVr221Yu1q/Q75Afu4wGVYz+7NOG0pUgu6gJLWzS+lC5hbIbmLN0CudQKDa 5+k84zkntdJCJAYWQ0WoH1wBZ0zmLQjwCrB1EKrhhiaZVQCZfHG9IH+JYtBMjf1DtkIQ 8JAg== X-Gm-Message-State: AOJu0Yzmn/kMEuKRyisAOwGVJQLJhGpDNjRBCAqXVgQYr9X00jBl9LNU Bfrz0gGCoxOcGvtDgF8hcPQ1D2LKld89eTJRqBZzBmP3 X-Google-Smtp-Source: AGHT+IEnO+Z7fGQHL2ByNPdpPDlfuXKkC6AT+NpE29C1WsvCJn74OniaFsRFK2leLyNghbaS1YBxP9d5bXQy1ucYjyI= X-Received: by 2002:a17:90a:db87:b0:269:5b17:24b6 with SMTP id h7-20020a17090adb8700b002695b1724b6mr10410777pjv.9.1692133160019; Tue, 15 Aug 2023 13:59:20 -0700 (PDT) MIME-Version: 1.0 From: Tom Gillespie Date: Tue, 15 Aug 2023 13:59:08 -0700 Message-ID: Subject: [PATCH] ob-tangle.el: restore :tangle closure nil behavior To: emacs-orgmode Content-Type: multipart/mixed; boundary="000000000000ea7b970602fc7386" Received-SPF: pass client-ip=2607:f8b0:4864:20::534; envelope-from=tgbugs@gmail.com; helo=mail-pg1-x534.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -8.46 X-Spam-Score: -8.46 X-Migadu-Queue-Id: 74A10335F6 X-Migadu-Scanner: mx2.migadu.com X-TUID: wkITv8r6llSq --000000000000ea7b970602fc7386 Content-Type: text/plain; charset="UTF-8" Hi, Here's a patch to fix the :tangle header behavior when it is passed a closure that returns nil. Best, Tom --000000000000ea7b970602fc7386 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-ob-tangle.el-restore-tangle-closure-nil-behavior.patch" Content-Disposition: attachment; filename="0001-ob-tangle.el-restore-tangle-closure-nil-behavior.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_llcsckcj0 RnJvbSBmMWUxNWUwNjM0ZmZmZWQ0NjQ4YWExMTYyOGExNGUwYTY4YzNiMThkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUb20gR2lsbGVzcGllIDx0Z2J1Z3NAZ21haWwuY29tPgpEYXRl OiBUdWUsIDE1IEF1ZyAyMDIzIDEzOjQ2OjA4IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gb2ItdGFu Z2xlLmVsOiByZXN0b3JlIDp0YW5nbGUgY2xvc3VyZSBuaWwgYmVoYXZpb3IKCiogbGlzcC9vYi10 YW5nbGUuZWwgKG9yZy1iYWJlbC10YW5nbGUtY29sbGVjdC1ibG9ja3MpOgoqIGxpc3Avb2ItdGFu Z2xlLmVsIChvcmctYmFiZWwtdGFuZ2xlLS11bmJyYWNrZXRlZC1saW5rKToKKiBsaXNwL29iLXRh bmdsZS5lbCAob3JnLWJhYmVsLXRhbmdsZS1zaW5nbGUtYmxvY2spOiBzcmMtdGZpbGUgZml4CmNh c2Ugd2hlcmUgKGNkciAoYXNzcSA6dGFuZ2xlIHBhcmFtcykpIGNvdWxkIGJlIG5pbAoKVGhpcyBw YXRjaCByZXN0b3JlcyB0aGUgb3JpZ2luYWwgYmVoYXZpb3Igb2YgdGhlIDp0YW5nbGUgaGVhZGVy CmFyZ3VtZW50IHdoZW4gYSBjbG9zdXJlIHJldHVybmVkIG5pbCwgZS5nLiAjK2hlYWRlcjogOnRh bmdsZSAob3IpLApieSB1c2luZyAob3IgKGNkciAoYXNzcSA6dGFuZ2xlIHBhcmFtcykpICJubyIp LiBXaXRob3V0IHRoaXMgdGhlCmNhbGwgdG8gYGZpbGUtbmFtZS1kaXJlY3RvcnknIGluIGBvcmct YmFiZWwtdGFuZ2xlLS11bmJyYWNrZXRlZC1saW5rJwpjYW4gZmFpbCB3aXRoIGEgd3JvbmctdHlw ZS1hcmd1bWVudCBzdHJpbmdwIG5pbCBlcnJvci4KLS0tCiBsaXNwL29iLXRhbmdsZS5lbCB8IDgg KysrKy0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvbGlzcC9vYi10YW5nbGUuZWwgYi9saXNwL29iLXRhbmdsZS5lbAppbmRl eCA0NTY2ZTAzYWQuLjBkZjY0OWQ3ZSAxMDA2NDQKLS0tIGEvbGlzcC9vYi10YW5nbGUuZWwKKysr IGIvbGlzcC9vYi10YW5nbGUuZWwKQEAgLTQ3MywxNCArNDczLDE0IEBAIGNvZGUgYmxvY2tzIGJ5 IHRhcmdldCBmaWxlLiIKIAkJICAob3JnLWluLWFyY2hpdmVkLWhlYWRpbmctcCkpCiAJKGxldCog KChpbmZvIChvcmctYmFiZWwtZ2V0LXNyYy1ibG9jay1pbmZvICduby1ldmFsKSkKIAkgICAgICAg KHNyYy1sYW5nIChudGggMCBpbmZvKSkKLQkgICAgICAgKHNyYy10ZmlsZSAoY2RyIChhc3NxIDp0 YW5nbGUgKG50aCAyIGluZm8pKSkpKQorCSAgICAgICAoc3JjLXRmaWxlIChvciAoY2RyIChhc3Nx IDp0YW5nbGUgKG50aCAyIGluZm8pKSkgIm5vIikpKQogCSAgKHVubGVzcyAob3IgKHN0cmluZz0g c3JjLXRmaWxlICJubyIpCiAJCSAgICAgIChhbmQgdGFuZ2xlLWZpbGUgKG5vdCAoZXF1YWwgdGFu Z2xlLWZpbGUgc3JjLXRmaWxlKSkpCiAJCSAgICAgIChhbmQgbGFuZy1yZSAobm90IChzdHJpbmct bWF0Y2gtcCBsYW5nLXJlIHNyYy1sYW5nKSkpKQogCSAgICA7OyBBZGQgdGhlIHNwZWMgZm9yIHRo aXMgYmxvY2sgdG8gYmxvY2tzIHVuZGVyIGl0cyB0YW5nbGVkCiAJICAgIDs7IGZpbGUgbmFtZS4K IAkgICAgKGxldCogKChibG9jayAob3JnLWJhYmVsLXRhbmdsZS1zaW5nbGUtYmxvY2sgY291bnRl cikpCi0gICAgICAgICAgICAgICAgICAgKHNyYy10ZmlsZSAoY2RyIChhc3NxIDp0YW5nbGUgKG50 aCA0IGJsb2NrKSkpKQorICAgICAgICAgICAgICAgICAgIChzcmMtdGZpbGUgKG9yIChjZHIgKGFz c3EgOnRhbmdsZSAobnRoIDQgYmxvY2spKSkgIm5vIikpCiAJCSAgIChmaWxlLW5hbWUgKG9yZy1i YWJlbC1lZmZlY3RpdmUtdGFuZ2xlZC1maWxlbmFtZQogICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGJ1ZmZlci1mbiBzcmMtbGFuZyBzcmMtdGZpbGUpKQogCQkgICAoYnktZm4gKGFzc29j IGZpbGUtbmFtZSBibG9ja3MpKSkKQEAgLTUxMCw3ICs1MTAsNyBAQCBUaGUgUEFSQU1TIGFyZSB0 aGUgM3JkIGVsZW1lbnQgb2YgdGhlIGluZm8gZm9yIHRoZSBzYW1lIHNyYyBibG9jay4iCiAgICAg ICAgICAgICAgIChjb25jYXQgImZpbGU6IgogICAgICAgICAgICAgICAgICAgICAgIChmaWxlLXJl bGF0aXZlLW5hbWUgKHN1YnN0cmluZyBiYXJlIChtYXRjaC1lbmQgMCkpCiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoZmlsZS1uYW1lLWRpcmVjdG9yeQotICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChjZHIgKGFzc3EgOnRhbmdsZSBw YXJhbXMpKSkpKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChv ciAoY2RyIChhc3NxIDp0YW5nbGUgcGFyYW1zKSkgIm5vIikpKSkKICAgICAgICAgICAgIGJhcmUp KSkpKSkKIAogKGRlZnZhciBvcmctb3V0bGluZS1yZWdleHApIDsgZGVmaW5lZCBpbiBsaXNwL29y Zy5lbApAQCAtNTgwLDcgKzU4MCw3IEBAIG5vbi1uaWwsIHJldHVybiB0aGUgZnVsbCBhc3NvY2lh dGlvbiBsaXN0IHRvIGJlIHVzZWQgYnkKIAkJCSAobWF0Y2gtZW5kIDApCiAJCSAgICAgICAocG9p bnQtbWluKSkpKQogCSAgICAgIChwb2ludCkpKSkpCi0gICAgICAgICAoc3JjLXRmaWxlIChjZHIg KGFzc3EgOnRhbmdsZSBwYXJhbXMpKSkKKyAgICAgICAgIChzcmMtdGZpbGUgKG9yIChjZHIgKGFz c3EgOnRhbmdsZSBwYXJhbXMpKSAibm8iKSkKIAkgKHJlc3VsdAogCSAgKGxpc3Qgc3RhcnQtbGlu ZQogCQkoaWYgb3JnLWJhYmVsLXRhbmdsZS11c2UtcmVsYXRpdmUtZmlsZS1saW5rcwotLSAKMi40 MS4wCgo= --000000000000ea7b970602fc7386--