emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Tom Gillespie <tgbugs@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix verbatim block fontification to end blocks on headlines
Date: Tue, 17 Dec 2019 20:38:14 -0800	[thread overview]
Message-ID: <CA+G3_PMX+HjpykxPqffVngJnQVwY2xQivrJzX=JAoPo0-hZfFA@mail.gmail.com> (raw)
In-Reply-To: <CA+G3_PPaNj+ZdVPUsmasQEWk+1EPBV4Ms8c-fGSRLQY0aH07iw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 575 bytes --]

    Here is the updated patch, including the fix to only trigger on
actual headlines (and not bold or similar), the readability
improvement for beg-of-next-line and a fix to call point-max only once
per branch. I also switched all the regex over to use the rx macro. I
left out the tests because since they would entail quite a bit of
additional work that is out of scope for this patch. The rx changes
mean that the patch is now over the tiny change limit, I went ahead
and sent a request to assign@gnu.org so we don't have to wait around
if things look good. Best,

[-- Attachment #2: 0001-org.el-Fix-verbatim-block-fontification-to-end-block.patch --]
[-- Type: application/x-patch, Size: 5139 bytes --]

  parent reply	other threads:[~2019-12-18  4:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-12  3:35 [PATCH] Fix verbatim block fontification to end blocks on headlines Tom Gillespie
2019-12-12  8:40 ` Nicolas Goaziou
2019-12-12 10:27   ` Tom Gillespie
2019-12-12 12:20     ` Adam Porter
2019-12-18  4:38     ` Tom Gillespie [this message]
2019-12-19 13:09       ` Nicolas Goaziou
2019-12-26 18:47       ` Bastien
2019-12-13 23:25 Tom Gillespie
2019-12-14 14:45 ` Nicolas Goaziou
2020-02-12  8:38 ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+G3_PMX+HjpykxPqffVngJnQVwY2xQivrJzX=JAoPo0-hZfFA@mail.gmail.com' \
    --to=tgbugs@gmail.com \
    --cc=emacs-orgmode@gnu.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).