From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id gOxrExcmoWPoQgEAbAwnHQ (envelope-from ) for ; Tue, 20 Dec 2022 04:03:51 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id ILp8EhcmoWN4aAEAG6o9tA (envelope-from ) for ; Tue, 20 Dec 2022 04:03:51 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E17362DD55 for ; Tue, 20 Dec 2022 04:03:50 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7SX1-0000HQ-Ey; Mon, 19 Dec 2022 21:39:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7SWx-0000Bm-UC for emacs-orgmode@gnu.org; Mon, 19 Dec 2022 21:38:59 -0500 Received: from mail-yb1-xb2c.google.com ([2607:f8b0:4864:20::b2c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p7SWu-0003ai-Rq for emacs-orgmode@gnu.org; Mon, 19 Dec 2022 21:38:59 -0500 Received: by mail-yb1-xb2c.google.com with SMTP id c124so7284280ybb.13 for ; Mon, 19 Dec 2022 18:38:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=DvF2Wvq0toPomhWIH3y37Yboy8t1QgpTrvmalMoQV9I=; b=Q4iZzn/nQbHoq1PEIrh8nwgHGgpI9aZybGPM1tK1l+Sc2GzXCemDJdeac4/DMyMhAq sJBeocxByimEX6g/9UkbPWWvGKeQH6XEC1gh6ktHJqRcEcP5jKX/fm6T/flvo10m7ZQX /n96x5eZHUrfzbaw5ClJLQCSWN7gAFlMn7HjttAlhWQBpWphSa0khOG9unb+PuURsEH2 x7kwFLsdsONT6WlH71OHkUb4hn1wev1ukqWiTvjEzqW9Voktrnil9Yx2nyHBbsyje6K8 +yQ2yxGf9ExWvvufp767EuDxAoHZpmHl0qbLBNDEjj0LrC3rLBF5GnnDHVLYw9u3+kOP RbRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=DvF2Wvq0toPomhWIH3y37Yboy8t1QgpTrvmalMoQV9I=; b=rGpWTfr4vEr97WnZ61LQ6hsHIUyUbsJdNr1ka04C+etQDwE/q9fveMSrnygpWX2eIb qhJewqF6RKvbG0esoO6CcG5aVCATEG84w4h3MF3CM8ZsKrlxPtOhY7v0VmoQN9GDKQk6 HWlLogGTEyILo3fOHZdQZjvv23AHMbCmhdAeYjxOwz24eLFYXhb/bUxAHCf+JvlXi7Cd xTNz4m5IFKIUw8y4UuaywpHeqMf7PkjKdsw3lJs16B6TFkY5guhYT3fxfDnsHaFepQXe wd295XzMYJsMqbuvc6j5Mswv2i1ozqAuS0K1+/HdUYkvYEtKLS8L2H3lkcEmdB2Rr3ww 698Q== X-Gm-Message-State: AFqh2kqT4Q9IxIDgEm0j3Dk90BALk6fkhgLVGvTnx9qhjdNuHYB/7sFH 5JEGwnRhMO8lrMJrsHs2szQ9YtjXOWnYurbUxjMAH1GR X-Google-Smtp-Source: AA0mqf6w0gA7m37Esh9n60RMVJtcZ+40SRVsI36c8a0kqM3pHQoe707kH/uE8QWuC26Fr8TVm7efIyE5ZakJrNX4UjU= X-Received: by 2002:a05:6902:4a9:b0:731:7af4:cc3e with SMTP id r9-20020a05690204a900b007317af4cc3emr1851734ybs.368.1671503934321; Mon, 19 Dec 2022 18:38:54 -0800 (PST) MIME-Version: 1.0 From: Tom Gillespie Date: Mon, 19 Dec 2022 21:38:43 -0500 Message-ID: Subject: [PATCH] Fix missing null check for tangle links during export To: emacs-orgmode Content-Type: multipart/mixed; boundary="0000000000003faafc05f0395642" Received-SPF: pass client-ip=2607:f8b0:4864:20::b2c; envelope-from=tgbugs@gmail.com; helo=mail-yb1-xb2c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=gmail.com header.s=20210112 header.b="Q4iZzn/n"; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1671505431; a=rsa-sha256; cv=none; b=hQlUb/CVD5P381E1Y60LgZj6Ybjl5wpzBejSNItrQ0eIl6o9xzlXwgRIw57KxzqnjyEkLm iF9e4e+Z2bo8gWN++oPVIc7P/oigmMa1cf5W38rWbu1DxviBVY+aydB+06Nk8IW4JV0Oud p0Lzyqp56AiqTYJ2QHjodsKbRCmFwsMjGpSIZTCeDO8yqoY8ASC7XNP42la2a11gWq0U3Z N8KaEDJ0uAzdp3KMxxov/TdExfZLnt+cvIuPJCcoFOa+fjCcshRhmkVgeNn5tK91dNbeXh qTCqw2TEupgAXIVwH31Kzc8YpBUyhagSCG9nlr3ohc4t9s6EVzApsPDMwbLAwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1671505431; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=VuecuzjISnD+I9GVlriVv2HFOQ4K+Mnk0bGVZAMEpNk=; b=PMea5VtpnmCYfWKXPIlXUL+goqqNpnFr7oBH32Y9s2oMFNBRD/HYAqOc/7WmgKyE0oiTbS kvDWLEkMXoB3lhH426cY11Qc7rq2MvDrd3wnZLMEVeoSzwAjVy8DE99JL+O8y14frnsu2J JHPQwYpRwoaflKiLwtrjhmHT9JQEfLivZrLEmqsV+xeVUv+oCnJZf8oZkZC/+P5sRyiW6R rgWKJL5RoGwkShAXUTHL9LkmpCzyJnG4ftLLWoQ1yn2YGXZjnU5FQba9TG/VpS1hAlR0CI 4sQYaCN2Gt32khKN9d6f31qbdDpT/Gm/JwvUgXKaNU9YQFgmNE5byjrBgcbmFQ== X-Migadu-Spam: Yes X-Spam: Yes X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=gmail.com header.s=20210112 header.b="Q4iZzn/n"; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) X-Migadu-Spam-Score: 6.21 X-Spam-Score: 6.21 X-Migadu-Queue-Id: E17362DD55 X-TUID: Mf8Mu6rajNlR --0000000000003faafc05f0395642 Content-Type: multipart/alternative; boundary="0000000000003faaf905f0395640" --0000000000003faaf905f0395640 Content-Type: text/plain; charset="UTF-8" Hi, Here is a patch that fixes broken tangling during export. I don't have a simple reproduction, but was able to run git bisect to find the originating commit. The commit text explains the issue in detail. Best, Tom --0000000000003faaf905f0395640 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,
=C2=A0=C2=A0 Here is a patch that fixes= broken tangling during export. I don't have a simple reproduction, but= was able to run git bisect to find the originating commit. The commit text= explains the issue in detail. Best,
Tom
--0000000000003faaf905f0395640-- --0000000000003faafc05f0395642 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Fix-missing-null-check-for-tangle-links-during-expor.patch" Content-Disposition: attachment; filename="0001-Fix-missing-null-check-for-tangle-links-during-expor.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lbvm7q6d0 RnJvbSAwYjRlMzU0NTM4NzRkYjBhY2YwNDZlNDZjNTcxY2RlZjVmMzlmNTlhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUb20gR2lsbGVzcGllIDx0Z2J1Z3NAZ21haWwuY29tPgpEYXRl OiBNb24sIDE5IERlYyAyMDIyIDIxOjI1OjAyIC0wNTAwClN1YmplY3Q6IFtQQVRDSF0gRml4IG1p c3NpbmcgbnVsbCBjaGVjayBmb3IgdGFuZ2xlIGxpbmtzIGR1cmluZyBleHBvcnQKCiogbGlzcC9v Yi10YW5nbGUuZWwgKG9yZy1iYWJlbC10YW5nbGUtLXVuYnJhY2tldGVkLWxpbmspOiBBZGQgdGhl IGxldApib3VuZCB2YXJpYWJsZSBsIHRvIHRoZSBhbmQgc3RhdGVtZW50IHRvIHByZXZlbnQgbCBm cm9tIGJlaW5nIHBhc3NlZAp0byBgc3RyaW5nLW1hdGNoJyBpbiB0aGUgZXZlbnQgdGhhdCBpdCBp cyBuaWwuCgpXaGVuIHRhbmdsaW5nIG5lc3RlZCBub3dlYiBibG9ja3MgZHVyaW5nIGV4cG9ydCBp dCBpcyBwb3NzaWJsZSBmb3IgdGhlCnJlc3VsdHMgb2YgYG9yZy1zdG9yZS1saW5rJyB0byByZXR1 cm4gbmlsLiAgVGhpcyBjb21taXQgZW5zdXJlcyB0aGF0CnRoZSB2YWx1ZSByZXR1cm5lZCBmb3Ig bCBpcyBvbmx5IHBhc3NlZCB0byBgc3RyaW5nLW1hdGNoJyB3aGVuIGl0IGlzCm5vbi1uaWwsIGF2 b2lkaW5nIGEgYHdyb25nLXR5cGUtYXJndW1lbnQnIChzdHJpbmdwIG5pbCkgZXJyb3IuCgpIYW5k bGluZyBvZiBjb21tZW50cyBhbmQgbmVzdGluZyBvZiBiYWJlbCBibG9ja3MgaXMga25vd24gdG8g aGF2ZQppc3N1ZXMuICBUaGUgYnVnIGlzIGZyb20gOGE3ODFkMzVkYzY4ZjIwZmEyYTU1NDZjOThi YTNkOWI3N2VlM2NkYQp3aGVyZSBuZXcgY29kZSB3YXMgaW50cm9kdWNlZCB0byBvYnRhaW4gdGhl IHZhbHVlIGZvciBiYXJlIHdoaWNoIHdhcwpub3QgcHJlc2VudCBpbiBlYXJseSBjb2RlLiAgSSdt IGd1ZXNzaW5nIHRoYXQgdGhlIGJ1ZyBhcHBlYXJzIG5vdwpiZWNhdXNlIGBzdHJpbmctbWF0Y2gn IGlzIGNhbGxlZCBvbiBsIChha2EgbGluaykgYXQgYSBwb2ludCBpbiB0aW1lCndoZW4gaXQgd2Fz IG5ldmVyIHByZXZpb3VzbHkgY2FsbGVkIGFuZCBpdCB3YXMgdGh1cyBtYXNrZWQgYmVjYXVzZSBp bgp0aGUgb2xkIHZlcnNpb24gaXQgd2FzIGltcG9zc2libGUgdG8gY2FsbCBgc3RyaW5nLW1hdGNo JyB3aGVuIGBsaW5rJwp3YXMgbmlsIGJlY2F1c2UgYW5vdGhlciB2YXJpYWJsZSB3YXMgYWx3YXlz IG5pbCwgbWFza2luZyB0aGUgaXNzdWUuCi0tLQogbGlzcC9vYi10YW5nbGUuZWwgfCAzICsrLQog MSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdp dCBhL2xpc3Avb2ItdGFuZ2xlLmVsIGIvbGlzcC9vYi10YW5nbGUuZWwKaW5kZXggYmQxN2JkYTMy Li5mZDZiNmYzYjkgMTAwNjQ0Ci0tLSBhL2xpc3Avb2ItdGFuZ2xlLmVsCisrKyBiL2xpc3Avb2It dGFuZ2xlLmVsCkBAIC01MDAsNyArNTAwLDggQEAgVGhlIFBBUkFNUyBhcmUgdGhlIDNyZCBlbGVt ZW50IG9mIHRoZSBpbmZvIGZvciB0aGUgc2FtZSBzcmMgYmxvY2suIgogICAgICAgICAgICAgICAg ICAoY2wtbGV0ZiAoKChzeW1ib2wtZnVuY3Rpb24gJ29yZy1zdG9yZS1saW5rLWZ1bmN0aW9ucykK ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAobGFtYmRhICgpIG5pbCkpKQogICAgICAgICAg ICAgICAgICAgIChvcmctc3RvcmUtbGluayBuaWwpKSkpCi0gICAgICAgICAgICAgKGJhcmUgKGFu ZCAoc3RyaW5nLW1hdGNoIG9yZy1saW5rLWJyYWNrZXQtcmUgbCkKKyAgICAgICAgICAgICAoYmFy ZSAoYW5kIGwKKyAgICAgICAgICAgICAgICAgICAgICAgIChzdHJpbmctbWF0Y2ggb3JnLWxpbmst YnJhY2tldC1yZSBsKQogICAgICAgICAgICAgICAgICAgICAgICAgKG1hdGNoLXN0cmluZyAxIGwp KSkpCiAgICAgICAgICh3aGVuIGJhcmUKICAgICAgICAgICAoaWYgKGFuZCBvcmctYmFiZWwtdGFu Z2xlLXVzZS1yZWxhdGl2ZS1maWxlLWxpbmtzCi0tIAoyLjM4LjIKCg== --0000000000003faafc05f0395642--