From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sebastian Miele <sebastian.miele@gmail.com>
Subject: Re: [PATCH] ob-emacs-lisp: Set `lexical-binding' in source editing
 buffers
Date: Sat, 23 Feb 2019 08:11:50 +0100
Message-ID: <CA+ABrMynhdJFPP_RoCnuTZhiOFgetekFU9aFdODEGxJ1JozBvw@mail.gmail.com>
References: <CA+ABrMwUK6zx3s4cEEd2bzHFTr==TSMhE6qM4TC2_WevUHh7=A@mail.gmail.com>
	<87h8d94cw2.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([209.51.188.92]:47561)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sebastian.miele@gmail.com>) id 1gxRTj-0006qm-I7
	for emacs-orgmode@gnu.org; Sat, 23 Feb 2019 02:12:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sebastian.miele@gmail.com>) id 1gxRTh-0007As-Ff
	for emacs-orgmode@gnu.org; Sat, 23 Feb 2019 02:12:06 -0500
Received: from mail-qt1-x842.google.com ([2607:f8b0:4864:20::842]:44205)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <sebastian.miele@gmail.com>)
	id 1gxRTf-00078d-Nm
	for emacs-orgmode@gnu.org; Sat, 23 Feb 2019 02:12:04 -0500
Received: by mail-qt1-x842.google.com with SMTP id d2so5125114qti.11
	for <emacs-orgmode@gnu.org>; Fri, 22 Feb 2019 23:12:03 -0800 (PST)
In-Reply-To: <87h8d94cw2.fsf@nicolasgoaziou.fr>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: mail@nicolasgoaziou.fr
Cc: emacs-orgmode@gnu.org

On Tue, Feb 12, 2019 at 9:41 AM Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
>
> [...]
>
> Thank you! Some comments follow.
>
> > -`eval', which see.")
> > +`eval', which see. And it is used as the value for
> > +`lexical-binding' in buffers created by `org-edit-src-code'.")
>
> You need to add two spaces after full stops.
>
> > +(defun org-babel-emacs-lisp-lexical (lexical)
> > +  "Convert :lexical source block argument LEXICAL into the form
> > +appropriate for `lexical-binding' and the LEXICAL argument to
> > +`eval'."
>
> The first sentence in a docstring needs to fit on a single line.
>
> Could you add a test or two for that feature? Could you also add an
> ORG-NEWS entry?

I did all the changes you suggested. I will send the new patch after I
managed to setup and get acquainted with mail in Emacs (mu4e).