emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Sebastian Miele <sebastian.miele@gmail.com>
To: mail@nicolasgoaziou.fr
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] ob-emacs-lisp: Set `lexical-binding' in source editing buffers
Date: Sat, 23 Feb 2019 08:11:50 +0100	[thread overview]
Message-ID: <CA+ABrMynhdJFPP_RoCnuTZhiOFgetekFU9aFdODEGxJ1JozBvw@mail.gmail.com> (raw)
In-Reply-To: <87h8d94cw2.fsf@nicolasgoaziou.fr>

On Tue, Feb 12, 2019 at 9:41 AM Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
>
> [...]
>
> Thank you! Some comments follow.
>
> > -`eval', which see.")
> > +`eval', which see. And it is used as the value for
> > +`lexical-binding' in buffers created by `org-edit-src-code'.")
>
> You need to add two spaces after full stops.
>
> > +(defun org-babel-emacs-lisp-lexical (lexical)
> > +  "Convert :lexical source block argument LEXICAL into the form
> > +appropriate for `lexical-binding' and the LEXICAL argument to
> > +`eval'."
>
> The first sentence in a docstring needs to fit on a single line.
>
> Could you add a test or two for that feature? Could you also add an
> ORG-NEWS entry?

I did all the changes you suggested. I will send the new patch after I
managed to setup and get acquainted with mail in Emacs (mu4e).

      reply	other threads:[~2019-02-23  7:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-10 12:57 [PATCH] ob-emacs-lisp: Set `lexical-binding' in source editing buffers Sebastian Miele
2019-02-12  8:41 ` Nicolas Goaziou
2019-02-23  7:11   ` Sebastian Miele [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+ABrMynhdJFPP_RoCnuTZhiOFgetekFU9aFdODEGxJ1JozBvw@mail.gmail.com \
    --to=sebastian.miele@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).