From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: [PATCH] agenda startup: log-mode should be customizable as well Date: Thu, 14 May 2009 13:36:01 +0200 Message-ID: References: <87prec9w0y.fsf@in-ulm.de> Mime-Version: 1.0 (Apple Message framework v930.3) Content-Type: multipart/mixed; boundary="===============2036830066==" Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M4ZEb-0005wa-01 for emacs-orgmode@gnu.org; Thu, 14 May 2009 07:36:21 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M4ZEW-0005w1-Ib for emacs-orgmode@gnu.org; Thu, 14 May 2009 07:36:20 -0400 Received: from [199.232.76.173] (port=48956 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M4ZEW-0005vq-5B for emacs-orgmode@gnu.org; Thu, 14 May 2009 07:36:16 -0400 Received: from mail-ew0-f210.google.com ([209.85.219.210]:56754) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M4ZEV-0006aN-Ks for emacs-orgmode@gnu.org; Thu, 14 May 2009 07:36:15 -0400 Received: by ewy6 with SMTP id 6so1571674ewy.42 for ; Thu, 14 May 2009 04:36:14 -0700 (PDT) In-Reply-To: <87prec9w0y.fsf@in-ulm.de> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Benjamin Andresen Cc: emacs-orgmode@gnu.org --===============2036830066== Content-Type: multipart/alternative; boundary=Apple-Mail-2--146727086 --Apple-Mail-2--146727086 Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Applied, thanks. - Carsten On May 14, 2009, at 5:57 AM, Benjamin Andresen wrote: > Hey there, > > I was curious as to why a value such log-mode wasn't customizable > to be run on start-up as follow-mode and clock-report-mode are. > > If Carsten thinks this is a good idea, I've attached a patch that may > shave of 5 seconds of him adding it. It applies cleanly to current git > HEAD. > > br, > benny > > diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el > index 7622f6a..e52fdbc 100644 > --- a/lisp/org-agenda.el > +++ b/lisp/org-agenda.el > @@ -628,6 +628,7 @@ Needs to be set before org.el is loaded." > :group 'org-agenda-startup > :type 'boolean) > > + > (defvar org-agenda-include-inactive-timestamps nil > "Non-nil means, include inactive time stamps in agenda and > timeline.") > > @@ -789,6 +790,12 @@ agenda display." > :group 'org-agenda-daily/weekly > :type 'boolean) > > +(defcustom org-agenda-start-with-log-mode nil > + "The initial value of log-mode in a newly created agenda window." > + :group 'org-agenda-startup > + :group 'org-agenda-daily/weekly > + :type 'boolean) > + > (defcustom org-agenda-start-with-clockreport-mode nil > "The initial value of clockreport-mode in a newly created agenda > window." > :group 'org-agenda-startup > @@ -1252,7 +1259,7 @@ The following commands are available: > (unless org-agenda-keep-modes > (setq org-agenda-follow-mode org-agenda-start-with-follow-mode > org-agenda-clockreport-mode org-agenda-start-with-clockreport-mode > - org-agenda-show-log nil)) > + org-agenda-show-log org-agenda-start-with-log-mode)) > (easy-menu-change > '("Agenda") "Agenda Files" > (append > _______________________________________________ > Emacs-orgmode mailing list > Remember: use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode --Apple-Mail-2--146727086 Content-Type: text/html; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Applied, = thanks.

- Carsten

On May 14, = 2009, at 5:57 AM, Benjamin Andresen wrote:

Hey there,

I was curious as to why a value = such log-mode wasn't customizable
to be run on start-up as = follow-mode and clock-report-mode are.

If Carsten thinks this is = a good idea, I've attached a patch that may
shave of 5 seconds of him = adding it. It applies cleanly to current = git
HEAD.

br,
benny

diff --git a/lisp/org-agenda.el = b/lisp/org-agenda.el
index 7622f6a..e52fdbc 100644
--- = a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -628,6 +628,7 @@ = Needs to be set before org.el is loaded."
  :group = 'org-agenda-startup
  :type 'boolean)

+
(defvar = org-agenda-include-inactive-timestamps nil
  "Non-nil = means, include inactive time stamps in agenda and timeline.")

@@ = -789,6 +790,12 @@ agenda display."
  :group = 'org-agenda-daily/weekly
  :type = 'boolean)

+(defcustom org-agenda-start-with-log-mode nil
+ =  "The initial value of log-mode in a newly created agenda = window."
+  :group 'org-agenda-startup
+  :group = 'org-agenda-daily/weekly
+  :type 'boolean)
+
(defcustom = org-agenda-start-with-clockreport-mode nil
  "The initial = value of clockreport-mode in a newly created agenda window."
=   :group 'org-agenda-startup
@@ -1252,7 +1259,7 @@ The = following commands are available:
  (unless = org-agenda-keep-modes
    (setq = org-agenda-follow-mode org-agenda-start-with-follow-mode
=  org-agenda-clockreport-mode = org-agenda-start-with-clockreport-mode
-  org-agenda-show-log = nil))
+ =  org-agenda-show-log org-agenda-start-with-log-mode))
=   (easy-menu-change
   '("Agenda") "Agenda = Files"
=    (append
_____________________________________________= __
Emacs-orgmode mailing list
Remember: use `Reply All' to send = replies to the list.
Emacs-orgmode@gnu.org
http://= lists.gnu.org/mailman/listinfo/emacs-orgmode
<= br>
= --Apple-Mail-2--146727086-- --===============2036830066== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-orgmode mailing list Remember: use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode --===============2036830066==--