From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bernt Hansen Subject: Re: [PATCH 2/2] Keep window position in agenda when changing todo states Date: Sat, 14 Jun 2014 13:45:23 -0400 Message-ID: References: <1402757211-30510-1-git-send-email-bernt@norang.ca> <1402757211-30510-3-git-send-email-bernt@norang.ca> <87fvj78p70.fsf@bzg.ath.cx> Mime-Version: 1.0 (1.0) Content-Type: multipart/alternative; boundary=Apple-Mail-05FDDA39-5BE2-420E-9546-30F9D66DFECF Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60758) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wvs1D-000786-8p for emacs-orgmode@gnu.org; Sat, 14 Jun 2014 13:45:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wvs17-00043Y-N3 for emacs-orgmode@gnu.org; Sat, 14 Jun 2014 13:45:31 -0400 In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bastien Cc: "emacs-orgmode@gnu.org" --Apple-Mail-05FDDA39-5BE2-420E-9546-30F9D66DFECF Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Yes you are correct. This patch is no longer required. Please disregard this patch. Thanks, Bernt > On Jun 14, 2014, at 1:01 PM, Bernt Hansen wrote: > > Will check. Thanks. > > Bernt > >> On Jun 14, 2014, at 11:51 AM, Bastien wrote: >> >> Hi Bernt, >> >> Bernt Hansen writes: >> >>> Allow changing task state in agenda without moving point. I >>> use this when reviewing projects weekly and I need to change the >>> state of some of the tasks. I found jumping to the top of the >>> agenda after each state change especially annoying when it causes >>> the agenda to scroll. >> >> I think the bug this patches is supposed to fix (i.e. point jumping >> at the top when changing the state of an agenda item) does not exist >> anymore, neither in the maint branch nor in the master one. >> >> Can you double-check? >> >> Also, `save-window-excursion' is sort of a brute-force approach when >> we only need to save the point position in a window. There is a big >> warning in `save-window-excursion' docstring that I slowly learned to >> appreciate... >> >> Anyway, I just looked at it quickly, maybe that's a correct fix. >> Thanks for further confirmation. >> >> -- >> Bastien --Apple-Mail-05FDDA39-5BE2-420E-9546-30F9D66DFECF Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable

Yes you are correct. This patch is no l= onger required.

Please disregard this patch.

<= /div>

Thanks,
Bernt

On Jun 14, 2014, at 1:01 PM, Bernt Hansen <bernt@norang.ca> wrote:

Will check. Thanks.

Bernt

On Jun 14, 2014, at 11:51 AM, Bastien <bzg@gnu.org> wrote:

Hi Bernt,

Bernt H= ansen <bernt@norang.ca> writes:=

Allow changing t= ask state in agenda without moving point. I
use this when reviewing projects weekly and I n= eed to change the

sta= te of some of the tasks. I found jumping to the top of the
<= /blockquote>
agenda after each state change e= specially annoying when it causes
the agenda to scroll.

<= span>I think the bug this patches is supposed to fix (i.e. point jumping
at the top when changing the state of an agenda item) does not e= xist
anymore, neither in the maint branch nor in the master o= ne.

Can you double-check?
<= /span>
Also, `save-window-excursion' is sort of a brute-force appro= ach when
we only need to save the point position in a window= . There is a big
warning in `save-window-excursion' do= cstring that I slowly learned to
appreciate...

Anyway, I just looked at it quickly, maybe that's a corr= ect fix.
Thanks for further confirmation.

--
Bastien

= --Apple-Mail-05FDDA39-5BE2-420E-9546-30F9D66DFECF--