From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id vEbTF90A7WDwPAEAgWs5BA (envelope-from ) for ; Tue, 13 Jul 2021 04:56:29 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id eF74Et0A7WDSCAAAbx9fmQ (envelope-from ) for ; Tue, 13 Jul 2021 02:56:29 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E12591D034 for ; Tue, 13 Jul 2021 04:56:24 +0200 (CEST) Received: from localhost ([::1]:40056 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m38at-0007jp-8N for larch@yhetil.org; Mon, 12 Jul 2021 22:56:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47576) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m38aI-0007j0-MT for emacs-orgmode@gnu.org; Mon, 12 Jul 2021 22:55:46 -0400 Received: from mail-qt1-x82b.google.com ([2607:f8b0:4864:20::82b]:44736) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m38aH-0004xp-6g for emacs-orgmode@gnu.org; Mon, 12 Jul 2021 22:55:46 -0400 Received: by mail-qt1-x82b.google.com with SMTP id x24so15511836qts.11 for ; Mon, 12 Jul 2021 19:55:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Q/PHGsevokvljRLOeoI/Ic2C1PXsUuEJG2Nrkcijj2s=; b=WHTuAO4FOBJQBoMuwsGWMwLCU4zr99QK7wpASm6exQIqAYojgjUPzxQf5XEOpw4wH1 35LVsHjCinpXmnoIK0m1YpLRMWTo+UOpsnisiRHsDvLCWb/9XKkONNJN4uUw6gXLaAs/ Ldyn3kgJmviWS+43FyrzFXiBqE5e0pPZ89zJ4+Wrz3dZFwPBqjT+w+Cfksjv1IiaWFEt ScfEvfLQ1U1mCPFZxFD3GdQVp/d6UZopUy2RI9iV0jxlInZKtGEbNpaCBCtLBWPmXhfa +TtEIrV2dlGWM4ABclRcnxsL0TYcjWJGTb9fdPCX4HLf0szgNv9FMoKbKX5XZWea5iUc iJew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Q/PHGsevokvljRLOeoI/Ic2C1PXsUuEJG2Nrkcijj2s=; b=E95Q6eyyrV3+lcFDoyCgKvlkb94rluBWogZ9wjXadMJwbphuGf0GK7o3xb+z0o5gkN WcCBY15muB9Qtmnx9gXPqX/DSGyT/uXaeoB71U6TTDOwzh03RD6+L/U2gzf0xC3dUbRr ASxpIIAeJsnEAzeAN6+ZgjmMx1WalRYR1NYlQYvdTbJqbC60TaCAfW25dYUDvMJetrrO Dq64Byz2f+uqecg7ZsmhctDJkZnwqS0yB4VYqMhStS/yxJCgqk9iB6tW/xuv0GEf/5om FFVpHFNfB9oOYaVhqBiFiR/eHHC8DUHOEAopCkHRcijooFMAaFjLW8UayJwIJaB+f8g7 GuWg== X-Gm-Message-State: AOAM530i83X7HdQOQQd8h3wv17PSCqaFqZIv5tqsgxEo1ieYRERcl9WI o7y7x9EwnXOdGrYXdyvVfQzp59OafJSgSX5y X-Google-Smtp-Source: ABdhPJwhDqlnsasRI6CJQHAAJX5xYR2TVWc3Vtj8jooGwwh11cB3GapSP6SNPgfYH7KB6EW+j33cHA== X-Received: by 2002:ac8:670f:: with SMTP id e15mr1930674qtp.291.1626144943555; Mon, 12 Jul 2021 19:55:43 -0700 (PDT) Received: from [192.168.39.176] (107-209-232-207.lightspeed.tukrga.sbcglobal.net. [107.209.232.207]) by smtp.gmail.com with ESMTPSA id d24sm7338516qkk.61.2021.07.12.19.55.42 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Jul 2021 19:55:43 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\)) Subject: Re: [PATCH] Bug: Duplicate logbook entry for repeated tasks [9.4.6 (9.4.6-gab9f2a @ /home/gustavo/.emacs.d/elpa/org-9.4.6/)] From: Carlo Tambuatco In-Reply-To: Date: Mon, 12 Jul 2021 22:55:39 -0400 Content-Transfer-Encoding: quoted-printable Message-Id: References: <877diwbm6a.fsf@gmail.com> <87a6muwa93.fsf@localhost> <874kd1wsc6.fsf@localhost> <871r85wgqd.fsf@localhost> <87wnpxv1d8.fsf@localhost> To: Bhavin Gandhi X-Mailer: Apple Mail (2.3608.120.23.2.7) Received-SPF: pass client-ip=2607:f8b0:4864:20::82b; envelope-from=oraclmaster@gmail.com; helo=mail-qt1-x82b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Org-Mode Mailing List , Ihor Radchenko , Gustavo Barros Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1626144985; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=Q/PHGsevokvljRLOeoI/Ic2C1PXsUuEJG2Nrkcijj2s=; b=pkDRt1oxWGno8dhBukupfHU8fyDfheWuzdxMZ93fyWo/zNymARW6Ya5Opit2OSlUTMeAc3 7GPlsgKfR4TyFrZSFlofj/Ewy6LtoQTCSJJSqwQE13Zwr157+WtEFGmhgJDxeGxVCDFMWj 9FNSDRvIyvYe66XPmG3sltcMN0bxDKhi9h1hflrsn6/B01YCrOQ+u9dwQ6QGckBHsVwl4E hnYNM5D+bq812aCHmxG+G0xFYaheTDN5iQfFs2Jd5PWxe036VolumsoF9QTQxsxHc8bbLH u1b4nquqIcI8DKOgzMkFU8IIy2zDMV+Sm0kwAb4mL5wa/OWCnms9XRDHqfsP1A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1626144985; a=rsa-sha256; cv=none; b=JZWm9+cN2zuohD6DFxuNc+Eam+/EcQ029dg7zfJy53Dob2KdyTU3VYzLJZpJDG8b4u4ejm DGG7KcohCRFbsFRggj9u3DKID0EnAXdB1xfYuH+d4s2ZS2rBqqe9yk7rikkeDP7HEBaxJX lXLriqlWR4OxcaqNN4Nhq753ujjcI/AWUakbjnlhK0/1B4CBWBSJxiQD5o/yEBDDPffzGv 8D+s012NXduFyxV6kBZoZwvk5WqJf5b8LJmVR6SO2O8kU0fXYoRcS7T0SY5LTsgl/8tpUY 33G6OjkmUExFL8eDOqx3KT0FPLt4uBhslL/GcBWPReL6pxKHkv3CCmYXzjMPHg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=WHTuAO4F; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -0.81 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=WHTuAO4F; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: E12591D034 X-Spam-Score: -0.81 X-Migadu-Scanner: scn0.migadu.com X-TUID: YM+mndhklP8D Newbie question: what command do I use to apply the patch=E2=80=A6? > On Jul 12, 2021, at 1:50 PM, Bhavin Gandhi = wrote: >=20 > On Sun, 11 Jul 2021 at 06:59, Ihor Radchenko = wrote: >> You are right. I believe that I fixed the breakage in the attached >> patch. Also, I noticed that c67037 did not fix the original bug when >> state change requests interactive note. >=20 > Thanks! I tested your latest patch, and it is fixing both the original > issues which `c67037' solved as well as this one. >=20 > I was trying to understand your change. So, when we call > `org-agenda-todo', it calls `org-todo' which adds the > post-command-hook. This hook is supposed to run when `org-agenda-todo' > finishes, but instead of that we call it directly. This makes sure = that > the change is recorded in `buffer-undo-list'. >=20 > Sorry if that's too much to ask, but why don't we need something = similar > when org-log-note-how is 'note? Can you please help me understand = that? > I tried reading org-add-log-note and org-store-log-note, but I think = I'm > missing something basic here. >=20 > Also, should this line from org.el (org-store-log-note) be removed? >=20 > ;; Don't add undo information when called from `org-agenda-todo'. >=20