emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Carsten Dominik <carsten.dominik@gmail.com>
To: Ian Kelling <ianowl@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix incorrect time calculation for org-extend-today-until
Date: Thu, 17 Oct 2013 07:42:37 +0200	[thread overview]
Message-ID: <BCC4EB55-C4B0-4418-82BE-AD0FF41CDD54@gmail.com> (raw)
In-Reply-To: <525EE1EB.3060805@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1310 bytes --]

Hi Ian,

I must have missed this a month ago, sorry about this.  I applied the patch now
(by hand, git-am choked on it.)

Thank you!

- Carsten

On 16.10.2013, at 20:58, Ian Kelling <ianowl@gmail.com> wrote:

> I sent this patch a month ago, but it got no reply. Perhaps that I
> accidentally had html email format didn't help.
> 
> During the extra hours of org-extend-today-until, when
> org-clock-mode-line-total is 'today, the clocked time shown in the
> modeline is wrong. It ignores all previously clocked time, when it
> should add them starting from the past day beyond
> org-extend-today-until hours.  This also affects clock tables.
> 
> The problem can be reproduced in emacs -q with the following code,
> as long as the current time is not between 11 PM and 12 AM:
> 
>  (progn
>    (require 'org-clock)
>    (setq org-clock-mode-line-total 'today)
>    (setq org-extend-today-until 23)
>    (format-time-string "%a %D %l:%M %p" (org-clock-get-sum-start)))
> 
> expected result:
> A date of yesterday, time of 11:00 PM
> 
> Actual result:
> A date of today, time of 11:00 PM
> 
> Note this patch only fixes a bug where org-extend-today-until
> is already used.
> 
> 
> - Ian Kelling
> 
> <0001-Fix-incorrect-time-calculation-for-org-extend-today-.patch>


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

      reply	other threads:[~2013-10-17  6:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-15 16:37 [PATCH] Fix incorrect time calculation for org-extend-today-until Ian Kelling
2013-09-15 17:04 ` Ian Kelling
2013-10-16 18:58 ` Ian Kelling
2013-10-17  5:42   ` Carsten Dominik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BCC4EB55-C4B0-4418-82BE-AD0FF41CDD54@gmail.com \
    --to=carsten.dominik@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=ianowl@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).