From: Le Wang <l26wang@gmail.com>
To: Orgmode Mailing List <emacs-orgmode@gnu.org>
Subject: bug: org-sort-list, `f'
Date: Thu, 26 May 2011 13:38:06 +0800 [thread overview]
Message-ID: <BANLkTinyXxwDtGq4YyY0K+oV=dcJMeFKOA@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 139 bytes --]
patch fixes sorting lists with custom getkey-func. Bug was trying to
evaluate getkey-func while setting it, so it was always nil.
--
Le
[-- Attachment #2: org-list.el.diff --]
[-- Type: application/octet-stream, Size: 583 bytes --]
diff --git a/lisp/org-list.el b/lisp/org-list.el
index 38a62e2..5df25d7 100644
--- a/lisp/org-list.el
+++ b/lisp/org-list.el
@@ -2559,8 +2559,10 @@ compare entries."
(read-char-exclusive)))
(getkey-func (and (= (downcase sorting-type) ?f)
(org-icompleting-read "Sort using function: "
- obarray 'fboundp t nil nil)
- (intern getkey-func))))
+ obarray 'fboundp t nil nil))))
+
+ (when (stringp getkey-func)
+ (setq getkey-func (intern getkey-func)))
(message "Sorting items...")
(save-restriction
(narrow-to-region start end)
next reply other threads:[~2011-05-26 5:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-26 5:38 Le Wang [this message]
2011-05-26 15:51 ` bug: org-sort-list, `f' Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTinyXxwDtGq4YyY0K+oV=dcJMeFKOA@mail.gmail.com' \
--to=l26wang@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).