From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Brand Subject: "git describe" in version of info file with "make info_git_describe" Date: Thu, 2 Jun 2011 16:11:51 +0200 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: Received: from eggs.gnu.org ([140.186.70.92]:56993) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QS8cv-0007Xs-BP for emacs-orgmode@gnu.org; Thu, 02 Jun 2011 10:11:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QS8cr-0001Qa-BN for emacs-orgmode@gnu.org; Thu, 02 Jun 2011 10:11:56 -0400 Received: from mail-ew0-f41.google.com ([209.85.215.41]:42738) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QS8cr-0001QG-1o for emacs-orgmode@gnu.org; Thu, 02 Jun 2011 10:11:53 -0400 Received: by ewy9 with SMTP id 9so342855ewy.0 for ; Thu, 02 Jun 2011 07:11:51 -0700 (PDT) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bernt Hansen Cc: Org Mode Hi Bernt, hi all I appreciate that org-version adds the output of "git describe" to the org-version string if we are running from a git repository. Thanks to Bernt et al: http://thread.gmane.org/gmane.emacs.orgmode/16620 Now I suggest the same for the info file by using the new target "make info_git_describe" instead of "make info" for all who are running from a git repository and are not building a release. I am about to finish a patch for this but before posting it would like to know the reason for "(subst-char-in-string ?- ?. git-version t)" in org-version here: http://orgmode.org/w/?p=org-mode.git;a=blob;f=lisp/org.el;h=1ca03f48d86fac71837079f7c3219cb295a9c795;hb=HEAD#l217 Can I remove this substitution of "release_7.5-350-g3433" -> "release_7.5.350.g3433" from org-version in my patch or should "make info_git_describe" do the same and why? Michael