From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Brand <michael.ch.brand@gmail.com> Subject: Re: "git describe" in version of info file with "make info_git_describe" Date: Thu, 2 Jun 2011 17:05:42 +0200 Message-ID: <BANLkTi=QfRwsDJjBWzcyuEsi91Zdu3Pseg@mail.gmail.com> References: <BANLkTi=iqzrSHS6QKoehSyZToBzkqFC3HA@mail.gmail.com> <87fwnse1d8.fsf@norang.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org> Received: from eggs.gnu.org ([140.186.70.92]:55852) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <michael.ch.brand@gmail.com>) id 1QS9X4-0003WC-M2 for emacs-orgmode@gnu.org; Thu, 02 Jun 2011 11:09:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <michael.ch.brand@gmail.com>) id 1QS9X2-0004e9-AG for emacs-orgmode@gnu.org; Thu, 02 Jun 2011 11:09:58 -0400 Received: from mail-ey0-f169.google.com ([209.85.215.169]:59901) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <michael.ch.brand@gmail.com>) id 1QS9X1-0004e4-Tv for emacs-orgmode@gnu.org; Thu, 02 Jun 2011 11:09:56 -0400 Received: by eyd9 with SMTP id 9so361724eyd.0 for <emacs-orgmode@gnu.org>; Thu, 02 Jun 2011 08:09:55 -0700 (PDT) In-Reply-To: <87fwnse1d8.fsf@norang.ca> List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>, <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe> List-Archive: </archive/html/emacs-orgmode> List-Post: <mailto:emacs-orgmode@gnu.org> List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>, <mailto:emacs-orgmode-request@gnu.org?subject=subscribe> Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bernt Hansen <bernt@norang.ca> Cc: Org Mode <emacs-orgmode@gnu.org> On Thu, Jun 2, 2011 at 16:47, Bernt Hansen <bernt@norang.ca> wrote: > Michael Brand <michael.ch.brand@gmail.com> writes: >> Can I remove this substitution of "release_7.5-350-g3433" -> >> "release_7.5.350.g3433" from org-version in my patch or should "make >> info_git_describe" do the same and why? > > Hi Michael, > > This was purely cosmetic. =A0I didn't like the look of the mixed '.' and > '-' in the version number originally. ... and '_' ... :-) >=A0I think the two reported version > numbers should be consistent between the org-version function and the > documentation version function you are proposing. > > If you want to remove the substitution please also do so in the > org-version code so the reported numbers are consistent. Since I would like to give the more often used "git describe" precedence I will make org-version and "make info_git_describe" consistent with git. The ".dirty" postfix of org-version I will leave untouched in org-version of course and support also in "make info_git_describe". Michael