From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: [RFC] Change some defcustoms into defcont Date: Sun, 20 Oct 2013 20:23:37 +0200 Message-ID: References: <871u3g5nwx.fsf@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 6.6 \(1510\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59190) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VXxfI-0004hI-7E for emacs-orgmode@gnu.org; Sun, 20 Oct 2013 14:23:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VXxf9-000387-LU for emacs-orgmode@gnu.org; Sun, 20 Oct 2013 14:23:48 -0400 Received: from mail-we0-x22c.google.com ([2a00:1450:400c:c03::22c]:55133) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VXxf9-00037u-Dq for emacs-orgmode@gnu.org; Sun, 20 Oct 2013 14:23:39 -0400 Received: by mail-we0-f172.google.com with SMTP id q58so5705800wes.31 for ; Sun, 20 Oct 2013 11:23:38 -0700 (PDT) In-Reply-To: <871u3g5nwx.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Nicolas Goaziou Cc: Org Mode List Hi Nicolas, I think this change breaks user setups. I don't know how many people do change these keywords, but I know some do, if only for localization purposes. I myself have modified the archive keyword in some cases, if I use this feature for a different purpose. You probably want to do this to make Org syntax less fragile. A good goal. However, I think it can also be achieved by leaving these as defcustom and discouraging changes in the docstring with a standard sentence about about deprecation. Your most important argument to me seems about efficiency of cashing. We can fix this by providing :set methods for the customize entries that will trigger global cache erasing, so that you do not need to programmatically check this all the time. Regards - Carsten On 20.10.2013, at 10:47, Nicolas Goaziou wrote: > Hello, > > I'd like to suggest changing the following defcustom variables into > defconst: > > - org-deadline-string > - org-scheduled-string > - org-closed-string > - org-clock-string > - org-comment-string > - org-quote-string > - org-effort-property > - org-archive-tag > > There's no fundamental reason to change these, as they belong to Org > syntax, much like star character for headlines and ":END:" closing > string for drawers. > > They can also introduce bugs in code when modified (e.g. modifying > `org-effort-property' breaks `ox-taskjuggler'). Of course, this can be > avoided with careful checks, but this puts an extra burden on developers > for a tiny benefit for the user. > > Eventually, they can be costly, since changing any of them implies that > cache in every Org buffer must be erased. > > Allowing customization is generally good, but I think Org syntax should > never be a moving target. > > Note that this shouldn't introduce much backward incompatibility (unless > user changes them through customize interface) since a defconst can > still be setq'ed and variables will still be used in code base. > > Opinions? > > > Regards, > > -- > Nicolas Goaziou >