From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: tag or property names with dashes Date: Mon, 30 Aug 2010 10:34:57 +0200 Message-ID: References: <4C63A6F1-5F71-4569-A1C5-C2C137DDF65B@gmail.com> Mime-Version: 1.0 (Apple Message framework v936) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from [140.186.70.92] (port=59720 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oq2Fh-0003U4-CM for emacs-orgmode@gnu.org; Mon, 30 Aug 2010 07:10:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OpzpW-0004Ak-JD for emacs-orgmode@gnu.org; Mon, 30 Aug 2010 04:35:03 -0400 Received: from paard.ic.uva.nl ([145.18.40.182]:49201) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OpzpW-0004AB-9O for emacs-orgmode@gnu.org; Mon, 30 Aug 2010 04:35:02 -0400 In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Manish Cc: emacs-orgmode list Hi Manish, this looks pretty good. I just went over the patch and found something like 5 locations where you did not make the change, and I fixed those. Have you been testing your patch extensively? Some testing needs to be done before we can merge it. - Carsten On Aug 20, 2010, at 9:30 PM, Manish wrote: > On Sat, Aug 21, 2010 at 12:58 AM, Manish > wrote: >> On Fri, Aug 20, 2010 at 11:02 PM, Manish wrote: >>> On Fri, Aug 20, 2010 at 7:15 PM, Carsten Dominik wrote: >>>> >>>> On Aug 20, 2010, at 3:36 PM, Manish wrote: >>>> >> [snip: accepting -'s in properties (17 lines)] >>>>> >>>>> Are "#" and "%" are disallowed in the tags? Can they be made to >>>>> work >>>>> please? >>>> >>>> This is non-trivial and I shy away from the work for now. Make me a >>>> patch and I will look at it. >>> >>> Attempting something that /you/ call non-trivial is nigh impossible >>> for me. :( >>> >>> But even if I were to dare.. any hints where I could start? >>> >> >> Attaching a naive first attempt. With this patch, I have tested >> special >> behavior of ctrl-a/e respecting tags in org files, ascii and HTML >> exports, agenda, and tag filtering. LaTeX export was not working so >> could not test and do not have the setup for testing Docbook exports. >> Please do take a look -- I do not understand the larger >> repurcussions/side effects of the changes to all the regexes. >> >> Thanks >> -- Manish >> > > This time _with_ patch. > > -- Manish > <0001-Modified-regexes-to-accept-percent-and-hash-sign-as-.patch> - Carsten