emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Possible bug in TODO ALL agenda fast tag filter generation?
@ 2010-04-07  9:47 Tim O'Callaghan
  2010-04-07 10:20 ` Tim O'Callaghan
  0 siblings, 1 reply; 3+ messages in thread
From: Tim O'Callaghan @ 2010-04-07  9:47 UTC (permalink / raw)
  To: org-mode

Any idea why this is happening? I'm seeing it with the agenda t
(global todo all)

-----------
Global list of TODO items of type: ALL
Available with `N r': (0)ALL (1)TODO (2)NEXT (3)WAITING (4)APPT
(5)DONE (6)DEFERRED (7)CANCELLED (8)PROJECT (9)SOMEDAY (10)PROJDONE
(11)PROJCANC (12)TODO (13)NEXT (14)WAITING (15)APPT (16)DONE
(17)DEFERRED (18)CANCELLED (19)PROJECT (20)SOMEDAY (21)PROJDONE
(22)PROJCANC (23)TODO (24)NEXT (25)WAITING (26)APPT (27)DONE
(28)DEFERRED (29)CANCELLED (30)PROJECT (31)SOMEDAY (32)PROJDONE
(33)PROJCANC (34)TODO (35)NEXT (36)WAITING (37)APPT (38)DONE
(39)DEFERRED (40)CANCELLED (41)PROJECT (42)SOMEDAY (43)PROJDONE
(44)PROJCANC (45)TODO (46)NEXT (47)WAITING (48)APPT (49)DONE
(50)DEFERRED (51)CANCELLED (52)PROJECT (53)SOMEDAY (54)PROJDONE
(55)PROJCANC (56)TODO (57)NEXT (58)WAITING (59)APPT (60)DONE
(61)DEFERRED (62)CANCELLED (63)PROJECT (64)SOMEDAY (65)PROJDONE
(66)PROJCANC (67)TODO (68)NEXT (69)WAITING (70)APPT (71)DONE
(72)DEFERRED (73)CANCELLED (74)PROJECT (75)SOMEDAY (76)PROJDONE
(77)PROJCANC (78)TODO (79)NEXT (80)WAITING (81)APPT (82)DONE
(83)DEFERRED (84)CANCELLED (85)PROJECT (86)SOMEDAY (87)PROJDONE
(88)PROJCANC (89)TODO (90)NEXT (91)WAITING (92)APPT (93)DONE
(94)DEFERRED (95)CANCELLED (96)PROJECT (97)SOMEDAY (98)PROJDONE
(99)PROJCANC
-----------


My todo-keywords config is this:

(setq org-todo-keywords
      (quote
       ((sequence "TODO(1!)" "NEXT(2!/!)" "WAITING(3@/!)" "APPT(4@/!)"
                  "|" "DONE(0!/@!)" "DEFERRED(D@!/!)" "CANCELLED(C@!/!)")
        (type "PROJECT(P!/@!)" "SOMEDAY(S!/@!)" "|" "PROJDONE" "PROJCANC")
        ))
      org-todo-keyword-faces
      (quote
       (
        ("TODO" :foreground "orangered" :weight bold)
        ("NEXT" :foreground "gold" :weight bold)
        ("DONE" :foreground "forest green" :weight bold)
        ("WAITING" :foreground "orange" :weight bold)
        ("CANCELLED" :foreground "indianred" :weight bold)
        ;; project level todo indicators
        ("SOMEDAY" :foreground "orchid" :weight bold)
        ("PROJECT" :foreground "grey" :weight bold)
        ("PROJDONE" :foreground "forest green" :weight bold)
        ("PROJCANC" :foreground "indianred" :weight bold)
        )))


Using git emacs 23 org git source (both as of this morning)

Tim.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Possible bug in TODO ALL agenda fast tag filter generation?
  2010-04-07  9:47 Possible bug in TODO ALL agenda fast tag filter generation? Tim O'Callaghan
@ 2010-04-07 10:20 ` Tim O'Callaghan
  2010-04-07 11:41   ` Carsten Dominik
  0 siblings, 1 reply; 3+ messages in thread
From: Tim O'Callaghan @ 2010-04-07 10:20 UTC (permalink / raw)
  To: org-mode

The problem is that "org-todo-keywords-1" is set for each agenda file
parsed, and that list is appended onto the
"org-todo-keywords-for-agenda" without any de-duplication.
The patch below fixes the problem, but possibly not in the best way.

regards,

Tim.

diff --git a/lisp/org.el b/lisp/org.el
index d80bb91..6a663b3 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -14960,6 +14960,8 @@ When a buffer is unmodified, it is just
killed.  When modified, it is saved
                (add-text-properties
                 (match-beginning 0) (org-end-of-subtree t) pc)))
            (set-buffer-modified-p bmp)))))
+    (setq org-todo-keywords-for-agenda
+          (org-uniquify org-todo-keywords-for-agenda))
     (setq org-todo-keyword-alist-for-agenda
          (org-uniquify org-todo-keyword-alist-for-agenda)
          org-tag-alist-for-agenda (org-uniquify org-tag-alist-for-agenda))))


On 7 April 2010 11:47, Tim O'Callaghan <tim.ocallaghan@gmail.com> wrote:
> Any idea why this is happening? I'm seeing it with the agenda t
> (global todo all)
>
> -----------
> Global list of TODO items of type: ALL
> Available with `N r': (0)ALL (1)TODO (2)NEXT (3)WAITING (4)APPT
> (5)DONE (6)DEFERRED (7)CANCELLED (8)PROJECT (9)SOMEDAY (10)PROJDONE
> (11)PROJCANC (12)TODO (13)NEXT (14)WAITING (15)APPT (16)DONE
> (17)DEFERRED (18)CANCELLED (19)PROJECT (20)SOMEDAY (21)PROJDONE
> (22)PROJCANC (23)TODO (24)NEXT (25)WAITING (26)APPT (27)DONE
> (28)DEFERRED (29)CANCELLED (30)PROJECT (31)SOMEDAY (32)PROJDONE
> (33)PROJCANC (34)TODO (35)NEXT (36)WAITING (37)APPT (38)DONE
> (39)DEFERRED (40)CANCELLED (41)PROJECT (42)SOMEDAY (43)PROJDONE
> (44)PROJCANC (45)TODO (46)NEXT (47)WAITING (48)APPT (49)DONE
> (50)DEFERRED (51)CANCELLED (52)PROJECT (53)SOMEDAY (54)PROJDONE
> (55)PROJCANC (56)TODO (57)NEXT (58)WAITING (59)APPT (60)DONE
> (61)DEFERRED (62)CANCELLED (63)PROJECT (64)SOMEDAY (65)PROJDONE
> (66)PROJCANC (67)TODO (68)NEXT (69)WAITING (70)APPT (71)DONE
> (72)DEFERRED (73)CANCELLED (74)PROJECT (75)SOMEDAY (76)PROJDONE
> (77)PROJCANC (78)TODO (79)NEXT (80)WAITING (81)APPT (82)DONE
> (83)DEFERRED (84)CANCELLED (85)PROJECT (86)SOMEDAY (87)PROJDONE
> (88)PROJCANC (89)TODO (90)NEXT (91)WAITING (92)APPT (93)DONE
> (94)DEFERRED (95)CANCELLED (96)PROJECT (97)SOMEDAY (98)PROJDONE
> (99)PROJCANC
> -----------
>
>
> My todo-keywords config is this:
>
> (setq org-todo-keywords
>      (quote
>       ((sequence "TODO(1!)" "NEXT(2!/!)" "WAITING(3@/!)" "APPT(4@/!)"
>                  "|" "DONE(0!/@!)" "DEFERRED(D@!/!)" "CANCELLED(C@!/!)")
>        (type "PROJECT(P!/@!)" "SOMEDAY(S!/@!)" "|" "PROJDONE" "PROJCANC")
>        ))
>      org-todo-keyword-faces
>      (quote
>       (
>        ("TODO" :foreground "orangered" :weight bold)
>        ("NEXT" :foreground "gold" :weight bold)
>        ("DONE" :foreground "forest green" :weight bold)
>        ("WAITING" :foreground "orange" :weight bold)
>        ("CANCELLED" :foreground "indianred" :weight bold)
>        ;; project level todo indicators
>        ("SOMEDAY" :foreground "orchid" :weight bold)
>        ("PROJECT" :foreground "grey" :weight bold)
>        ("PROJDONE" :foreground "forest green" :weight bold)
>        ("PROJCANC" :foreground "indianred" :weight bold)
>        )))
>
>
> Using git emacs 23 org git source (both as of this morning)
>
> Tim.
>

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: Re: Possible bug in TODO ALL agenda fast tag filter generation?
  2010-04-07 10:20 ` Tim O'Callaghan
@ 2010-04-07 11:41   ` Carsten Dominik
  0 siblings, 0 replies; 3+ messages in thread
From: Carsten Dominik @ 2010-04-07 11:41 UTC (permalink / raw)
  To: Tim O'Callaghan; +Cc: org-mode

Applied, thanks.

- Carsten

On Apr 7, 2010, at 12:20 PM, Tim O'Callaghan wrote:

> The problem is that "org-todo-keywords-1" is set for each agenda file
> parsed, and that list is appended onto the
> "org-todo-keywords-for-agenda" without any de-duplication.
> The patch below fixes the problem, but possibly not in the best way.
>
> regards,
>
> Tim.
>
> diff --git a/lisp/org.el b/lisp/org.el
> index d80bb91..6a663b3 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -14960,6 +14960,8 @@ When a buffer is unmodified, it is just
> killed.  When modified, it is saved
>                (add-text-properties
>                 (match-beginning 0) (org-end-of-subtree t) pc)))
>            (set-buffer-modified-p bmp)))))
> +    (setq org-todo-keywords-for-agenda
> +          (org-uniquify org-todo-keywords-for-agenda))
>     (setq org-todo-keyword-alist-for-agenda
>          (org-uniquify org-todo-keyword-alist-for-agenda)
>          org-tag-alist-for-agenda (org-uniquify org-tag-alist-for- 
> agenda))))
>
>
> On 7 April 2010 11:47, Tim O'Callaghan <tim.ocallaghan@gmail.com>  
> wrote:
>> Any idea why this is happening? I'm seeing it with the agenda t
>> (global todo all)
>>
>> -----------
>> Global list of TODO items of type: ALL
>> Available with `N r': (0)ALL (1)TODO (2)NEXT (3)WAITING (4)APPT
>> (5)DONE (6)DEFERRED (7)CANCELLED (8)PROJECT (9)SOMEDAY (10)PROJDONE
>> (11)PROJCANC (12)TODO (13)NEXT (14)WAITING (15)APPT (16)DONE
>> (17)DEFERRED (18)CANCELLED (19)PROJECT (20)SOMEDAY (21)PROJDONE
>> (22)PROJCANC (23)TODO (24)NEXT (25)WAITING (26)APPT (27)DONE
>> (28)DEFERRED (29)CANCELLED (30)PROJECT (31)SOMEDAY (32)PROJDONE
>> (33)PROJCANC (34)TODO (35)NEXT (36)WAITING (37)APPT (38)DONE
>> (39)DEFERRED (40)CANCELLED (41)PROJECT (42)SOMEDAY (43)PROJDONE
>> (44)PROJCANC (45)TODO (46)NEXT (47)WAITING (48)APPT (49)DONE
>> (50)DEFERRED (51)CANCELLED (52)PROJECT (53)SOMEDAY (54)PROJDONE
>> (55)PROJCANC (56)TODO (57)NEXT (58)WAITING (59)APPT (60)DONE
>> (61)DEFERRED (62)CANCELLED (63)PROJECT (64)SOMEDAY (65)PROJDONE
>> (66)PROJCANC (67)TODO (68)NEXT (69)WAITING (70)APPT (71)DONE
>> (72)DEFERRED (73)CANCELLED (74)PROJECT (75)SOMEDAY (76)PROJDONE
>> (77)PROJCANC (78)TODO (79)NEXT (80)WAITING (81)APPT (82)DONE
>> (83)DEFERRED (84)CANCELLED (85)PROJECT (86)SOMEDAY (87)PROJDONE
>> (88)PROJCANC (89)TODO (90)NEXT (91)WAITING (92)APPT (93)DONE
>> (94)DEFERRED (95)CANCELLED (96)PROJECT (97)SOMEDAY (98)PROJDONE
>> (99)PROJCANC
>> -----------
>>
>>
>> My todo-keywords config is this:
>>
>> (setq org-todo-keywords
>>      (quote
>>       ((sequence "TODO(1!)" "NEXT(2!/!)" "WAITING(3@/!)" "APPT(4@/!)"
>>                  "|" "DONE(0!/@!)" "DEFERRED(D@!/!)"  
>> "CANCELLED(C@!/!)")
>>        (type "PROJECT(P!/@!)" "SOMEDAY(S!/@!)" "|" "PROJDONE"  
>> "PROJCANC")
>>        ))
>>      org-todo-keyword-faces
>>      (quote
>>       (
>>        ("TODO" :foreground "orangered" :weight bold)
>>        ("NEXT" :foreground "gold" :weight bold)
>>        ("DONE" :foreground "forest green" :weight bold)
>>        ("WAITING" :foreground "orange" :weight bold)
>>        ("CANCELLED" :foreground "indianred" :weight bold)
>>        ;; project level todo indicators
>>        ("SOMEDAY" :foreground "orchid" :weight bold)
>>        ("PROJECT" :foreground "grey" :weight bold)
>>        ("PROJDONE" :foreground "forest green" :weight bold)
>>        ("PROJCANC" :foreground "indianred" :weight bold)
>>        )))
>>
>>
>> Using git emacs 23 org git source (both as of this morning)
>>
>> Tim.
>>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

- Carsten

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-04-07 11:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-04-07  9:47 Possible bug in TODO ALL agenda fast tag filter generation? Tim O'Callaghan
2010-04-07 10:20 ` Tim O'Callaghan
2010-04-07 11:41   ` Carsten Dominik

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).