From: Puneeth Chaganti <punchagan@gmail.com>
To: Bastien <bastien.guerry@wikimedia.fr>
Cc: Jason Dunsmore <emacs-orgmode@dunsmor.com>,
Org-mode mailing list <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] [BUG] Timestamps surrounded by @@ in HTML export
Date: Wed, 2 Feb 2011 23:14:25 +0530 [thread overview]
Message-ID: <AANLkTin+5mFswzbNxF=QSfKXyMp0m4Ejk6UKtF-SLcX+@mail.gmail.com> (raw)
In-Reply-To: <87tygmd9u7.fsf@gnu.org>
On Wed, Feb 2, 2011 at 3:42 PM, Bastien <bastien.guerry@wikimedia.fr> wrote:
> Puneeth Chaganti <punchagan@gmail.com> writes:
>
>>>> I don't really understand what is going on here, but there was one @
>>>> still appearing after this patch was applied. I am sending a patch to
>>>> remove the one remaining @ symbol in the `org-html-handle-time-stamps`
>>>> function. I don't know if this breaks something else and why this was
>>>> left out by Jason.
>>>
>>> Better to test your own patch then ;) I did so, looks fine, I applied
>>> it. Thanks!
>>
>> :) I did test my patch and it worked.
>
> Ah okay, sorry for assuming otherwise!
>
>> But these @ seemed to have been put there for some reason, I wasn't
>> able to understand, in the quick look that I had. Anyway, thanks.
>
> It took me a while to understand this as well: when looking at
> org-export-as-html, you see some occurrences of "@<tag>". These
> org-specific @tags are escaped and will be taken care of in the
> rest of the function.
>
> But org-html-handle-time-stamps happens after these @tags have
> been taken care of, which means that no @ is necessary in this
> function.
>
> Hope this helps :)
Thanks for explaining this. :)
--
Puneeth
prev parent reply other threads:[~2011-02-02 17:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-01 15:37 [PATCH] [BUG] Timestamps surrounded by @@ in HTML export Jason Dunsmore
2011-02-01 16:48 ` Bastien
2011-02-01 18:50 ` Puneeth Chaganti
2011-02-02 9:48 ` Bastien
2011-02-02 9:55 ` Puneeth Chaganti
2011-02-02 10:12 ` Bastien
2011-02-02 17:44 ` Puneeth Chaganti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTin+5mFswzbNxF=QSfKXyMp0m4Ejk6UKtF-SLcX+@mail.gmail.com' \
--to=punchagan@gmail.com \
--cc=bastien.guerry@wikimedia.fr \
--cc=emacs-orgmode@dunsmor.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).