emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Puneeth Chaganti <punchagan@gmail.com>
To: Aankhen <aankhen@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: [PATCH] Missing prompt label in capture template expansion
Date: Fri, 25 Feb 2011 15:11:55 +0530	[thread overview]
Message-ID: <AANLkTikyfcK5TyG+D1C83LcUdi77nhRFqC-qTfVsWnZw@mail.gmail.com> (raw)

Hi,

Bar has the properties of a LINK associated with it and hence is not
being displayed in the mini-buffer.  Here is a possible fix, but I'm
not sure if it's the best fix.

HTH,
Puneeth

diff --git a/lisp/org-capture.el b/lisp/org-capture.el
index b5711f7..da21e89 100644
--- a/lisp/org-capture.el
+++ b/lisp/org-capture.el
@@ -1279,8 +1279,8 @@ The template may still contain \"%?\" for cursor
positioning."
       (while (re-search-forward "%^\\({\\([^}]*\\)}\\)?\\([gGtTuUCLp]\\)?"
 				nil t)
 	(unless (org-capture-escaped-%)
-	  (setq char (if (match-end 3) (match-string 3))
-		prompt (if (match-end 2) (match-string 2)))
+	  (setq char (if (match-end 3) (match-string-no-properties 3))
+		prompt (if (match-end 2) (match-string-no-properties 2)))
 	  (goto-char (match-beginning 0))
 	  (replace-match "")
 	  (setq completions nil default nil)

On Fri, Feb 25, 2011 at 12:41 PM, Aankhen <aankhen@gmail.com> wrote:
> Remember to cover the basics, that is, what you expected to happen and
> what in fact did happen.  You don't know how to make a good report?  See
>
>     http://orgmode.org/manual/Feedback.html#Feedback
>
> Your bug report will be posted to the Org-mode mailing list.
> ------------------------------------------------------------------------
>
> STEPS TO REPRODUCE:
> 1. Add this to the list of capture templates:
>    ("t" "Test" entry (file "z:/Temp/t.org")
>     "*** TODO %^{Foo} [[bar:%^{Bar}][Bar]]")
> 2. Run org-capture.
> 3. Fill in a value for “Foo” when prompted and press Enter.
>
> EXPECTED RESULTS:
> Prompted for second value, with label “Bar”.
>
> ACTUAL RESULTS:
> Prompted for second value, with label “ ” (single space).
>
> NOTES:
> I tried this using org-mode from git (commit id:
> b23d35de06c229db84472d893c8645c63896a6cd) after starting Emacs with
> ‘emacs -Q’ to ensure there was no interference.  A couple of
> variations on the template above work fine, correctly showing the
> label when prompting for a value:
>
> * No prompts before the one in the link: ("t" "Test" entry (file
> "z:/Temp/t.org") "*** TODO [[bar:%^{Bar}][Bar]]")
> * No link description: ("t" "Test" entry (file "z:/Temp/t.org") "***
> TODO [[bar:%^{Bar}][Bar]]")
>
> Config follows…
>
> Emacs  : GNU Emacs 24.0.50.1 (i386-mingw-nt6.1.7601)
>  of 2010-11-10 on SHAN-PC
> Package: Org-mode version 7.4
>
> current state:
> ==============
> (setq
>  org-export-latex-after-initial-vars-hook '(org-beamer-after-initial-vars)
>  org-speed-command-hook '(org-speed-command-default-hook
>                          org-babel-speed-command-hook)
>  org-metaup-hook '(org-babel-load-in-session-maybe)
>  org-capture-templates '(("t" "Test" entry (file "z:/Temp/t.org" "Media")
>                          "*** TODO %^{Foo} [[bar:%^{Bar}][Bar]]")
>                         )
>  org-after-todo-state-change-hook '(org-clock-out-if-current)
>  org-export-blocks-postblock-hook '(org-exp-res/src-name-cleanup)
>  org-export-latex-format-toc-function 'org-export-latex-format-toc-default
>  org-tab-first-hook '(org-hide-block-toggle-maybe
>                      org-src-native-tab-command-maybe
>                      org-babel-hide-result-toggle-maybe)
>  org-src-mode-hook '(org-src-babel-configure-edit-buffer
>                     org-src-mode-configure-edit-buffer)
>  org-confirm-shell-link-function 'yes-or-no-p
>  org-export-first-hook '(org-beamer-initialize-open-trackers)
>  org-agenda-before-write-hook '(org-agenda-add-entry-text)
>  org-babel-pre-tangle-hook '(save-buffer)
>  org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers
>                  org-cycle-show-empty-lines
>                  org-optimize-window-after-visibility-change)
>  org-export-preprocess-before-normalizing-links-hook
> '(org-remove-file-link-modifiers)
>  org-mode-hook '(#[nil "\300\301\302\303\304$\207"
>                   [org-add-hook change-major-mode-hook org-show-block-all
>                    append local]
>                   5]
>                 #[nil "\300\301\302\303\304$\207"
>                   [org-add-hook change-major-mode-hook
>                    org-babel-show-result-all append local]
>                   5]
>                 org-babel-result-hide-spec org-babel-hide-all-hashes)
>  org-ctrl-c-ctrl-c-hook '(org-babel-hash-at-point
>                          org-babel-execute-safely-maybe)
>  org-confirm-elisp-link-function 'yes-or-no-p
>  org-export-interblocks '((lob org-babel-exp-lob-one-liners)
>                          (src org-babel-exp-inline-src-blocks))
>  org-occur-hook '(org-first-headline-recenter)
>  org-export-preprocess-before-selecting-backend-code-hook
> '(org-beamer-select-beamer-code)
>  org-export-latex-final-hook '(org-beamer-amend-header org-beamer-fix-toc
>                               org-beamer-auto-fragile-frames
>                               org-beamer-place-default-actions-for-lists)
>  org-metadown-hook '(org-babel-pop-to-session-maybe)
>  org-export-blocks '((src org-babel-exp-src-block nil)
>                     (comment org-export-blocks-format-comment t)
>                     (ditaa org-export-blocks-format-ditaa nil)
>                     (dot org-export-blocks-format-dot nil))
>  )
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>



-- 
Puneeth

             reply	other threads:[~2011-02-25  9:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-25  9:41 Puneeth Chaganti [this message]
2011-02-25 15:32 ` [PATCH] Missing prompt label in capture template expansion Aankhen
2011-02-26 15:55 ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTikyfcK5TyG+D1C83LcUdi77nhRFqC-qTfVsWnZw@mail.gmail.com \
    --to=punchagan@gmail.com \
    --cc=aankhen@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).