From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guy Wiener Subject: Re: Bounce: Bug in iCal export? Date: Mon, 6 Sep 2010 17:01:04 +0300 Message-ID: References: <87bp8c116o.fsf@gnu.org> <87mxrwxaxv.wl%dmaus@ictsoc.de> <87fwxovsy0.fsf@gnu.org> <87aanvor7b.wl%dmaus@ictsoc.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1872853484==" Return-path: Received: from [140.186.70.92] (port=48887 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OscFv-0002Cm-Kl for emacs-orgmode@gnu.org; Mon, 06 Sep 2010 10:01:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OscFu-0008Ux-8U for emacs-orgmode@gnu.org; Mon, 06 Sep 2010 10:01:07 -0400 Received: from mail-qy0-f169.google.com ([209.85.216.169]:33749) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OscFu-0008Uk-52 for emacs-orgmode@gnu.org; Mon, 06 Sep 2010 10:01:06 -0400 Received: by qyk12 with SMTP id 12so2578749qyk.0 for ; Mon, 06 Sep 2010 07:01:04 -0700 (PDT) In-Reply-To: <87aanvor7b.wl%dmaus@ictsoc.de> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: David Maus Cc: emacs-orgmode@gnu.org, Bastien --===============1872853484== Content-Type: multipart/alternative; boundary=0015175cd686133372048f97b6dd --0015175cd686133372048f97b6dd Content-Type: text/plain; charset=UTF-8 Do you mind sending a patch just for that? I prefer to check it without switching to the development release. Thanks, Guy On Sun, Sep 5, 2010 at 11:44 PM, David Maus wrote: > Bastien wrote: > >David Maus writes: > > >> Uhh... Not really :/ It will still happens for TODO entries > > >Why? > > The headline information is fetched again (?) if > `org-icalendar-include-todo' is non-nil (line 474) and Org creates a > VTODO entity. Looks like the iCal export function could use some > refactoring -- I stumbled on this by accident because calling > `org-get-headline' with the NO-TAGS option didn't solve the problem > for a iCal entry with a TODO state and a tag. > > >> Do you mind if I revert the commit and check in a better solution? > > >Absolutely not! Thanks for asking > > Fine. My first git revert \o/ > > Best, > -- David > -- > OpenPGP... 0x99ADB83B5A4478E6 > Jabber.... dmjena@jabber.org > Email..... dmaus@ictsoc.de > --0015175cd686133372048f97b6dd Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Do you mind sending a patch just for that? I prefer to che= ck it without switching to the development release.

Than= ks,
=C2=A0=C2=A0Guy

On Sun, Sep= 5, 2010 at 11:44 PM, David Maus <dmaus@ictsoc.de> wrote:
Bastien wrote:
>David Maus <dmaus@ictsoc.de&g= t; writes:

>> Uhh... Not really :/ It will still happens for TODO entries

>Why?

The headline information is fetched again (?) if
`org-icalendar-include-todo' is non-nil (line 474) and Org creates a VTODO entity. =C2=A0Looks like the iCal export function could use some
refactoring -- I stumbled on this by accident because calling
`org-get-headline' with the NO-TAGS option didn't solve the problem=
for a iCal entry with a TODO state and a tag.

>> Do you mind if I revert the commit and check in a better solution?=

>Absolutely not! =C2=A0Thanks for asking

Fine. =C2=A0My first git revert \o/

Best,
=C2=A0-- David
--
OpenPGP... 0x99ADB83B5A4478E6
Jabber.... dmjena@jabber.org
Email..... dmaus@ictsoc.de

--0015175cd686133372048f97b6dd-- --===============1872853484== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode --===============1872853484==--