From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?Q?Valentin_W=C3=BCstholz?= <wuestholz@gmail.com>
Subject: Re: [PATCH] ASCII export: Fixed a bug.
Date: Tue, 15 Feb 2011 09:59:20 +0100
Message-ID: <AANLkTi=kvj7_mXYc1GaKf-qhxgQoOxgfSpQYY=jVsZn-@mail.gmail.com>
References: <AANLkTikw3vamENTzQ6hNKiWyOioT04O03dPqCs9DQdbz@mail.gmail.com>
	<87pqqw17mt.fsf@gnu.org>
	<AANLkTi=i7DpL+kVLq+gsrXMu2ZbpnQRmC-18S37nusj-@mail.gmail.com>
	<87y65hq5oy.fsf@gnu.org>
	<AANLkTinjcX2v770HOeV9Ut2-x25MbQ_3NWUF5HZGbchp@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from [140.186.70.92] (port=55353 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PpGl5-0002mR-78
	for emacs-orgmode@gnu.org; Tue, 15 Feb 2011 03:59:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <wuestholz@gmail.com>) id 1PpGl4-0004Ox-0Z
	for emacs-orgmode@gnu.org; Tue, 15 Feb 2011 03:59:43 -0500
Received: from mail-vw0-f41.google.com ([209.85.212.41]:51542)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wuestholz@gmail.com>) id 1PpGl3-0004OW-Ti
	for emacs-orgmode@gnu.org; Tue, 15 Feb 2011 03:59:41 -0500
Received: by vws10 with SMTP id 10so3521995vws.0
	for <emacs-orgmode@gnu.org>; Tue, 15 Feb 2011 00:59:41 -0800 (PST)
In-Reply-To: <AANLkTinjcX2v770HOeV9Ut2-x25MbQ_3NWUF5HZGbchp@mail.gmail.com>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Bastien <bastien.guerry@wikimedia.fr>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>

Hi Bastien,

I just noticed that the call to 'car' is missing:

------------------------------ lisp/org-ascii.el --------------------------=
----
index 3cc95e6..dd6f69b 100644
@@ -656 +656 @@ publishing directory."
-      		     (last org-export-ascii-underline)))
+      		     (car (last org-export-ascii-underline))))


Best regards,

Valentin


On Tue, Feb 15, 2011 at 7:58 AM, Valentin W=C3=BCstholz <wuestholz@gmail.co=
m> wrote:
> On Tue, Feb 15, 2011 at 5:31 AM, Bastien <bastien.guerry@wikimedia.fr> wr=
ote:
>> Hi Valentin,
>>
>> Valentin W=C3=BCstholz <wuestholz@gmail.com> writes:
>>
>>> thanks. Is there a reason for keeping the 'reverse' operation? The
>>> documentation for org-export-ascii-underline states that the
>>> characters are ordered by level (1, 2, ...). Why should they be
>>> accessed in reverse order then?
>>
>> The docstring didn't match the default value for the defcustom: now it
>> does. =C2=A0I also simplified `org-ascii-level-start' so that it use the
>> right level char.
>
> Sounds good!
>
> Thanks,
>
> Valentin
>