From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Brand Subject: Re: IMPORTANT Modified link escaping in Org mode Date: Sun, 13 Mar 2011 14:37:05 +0100 Message-ID: References: <87k4gysacq.wl%dmaus@ictsoc.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Return-path: Received: from [140.186.70.92] (port=38073 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PylTo-0003XL-Me for emacs-orgmode@gnu.org; Sun, 13 Mar 2011 09:37:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PylTn-0000wf-4t for emacs-orgmode@gnu.org; Sun, 13 Mar 2011 09:37:08 -0400 Received: from mail-iw0-f169.google.com ([209.85.214.169]:53066) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PylTm-0000wO-VS for emacs-orgmode@gnu.org; Sun, 13 Mar 2011 09:37:07 -0400 Received: by iwl42 with SMTP id 42so5379469iwl.0 for ; Sun, 13 Mar 2011 06:37:05 -0700 (PDT) In-Reply-To: <87k4gysacq.wl%dmaus@ictsoc.de> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: David Maus Cc: org-mode Hi David The current version of dmaus/org-check-percent-escapes from Worg http://orgmode.org/worg/org-hacks.html#check-old-link-escapes loops forever in the outer while when used on a one line Org buffer containing just [[http://www.orgmode.org]] except I hack something like (goto-char end) behind the inner while. What am I doing wrong? Did anybody else have this issue? Michael On Thu, Feb 17, 2011 at 20:57, David Maus wrote: > Hello everybody, > > I've just pushed a series of commits to current master that modifies > Org modes link escaping functions. > > Percent escaping is used in Org mode to escape certain characters in > links that would either break the parser (e.g. square brackets in link > target oder description) or are not allowed to appear in a particular > link type (e.g. non-ascii characters in a http: link). > > With this change in place Org will apply percent escaping and > unescaping more consistently especially for non-ascii characters. > Additionally some of the outstanding bugs or glitches concerning > percent escaped links are solved. > > However, this change has the potential to break existing links in your > documents in at least one case: Links that contain a literal percent > sign followed by two characters in [0-9a-fA-f] might break if this > sequence of characters is /not/ a percent escape. > > E.g. a link to a directory literally called "foo%45bar" will break > because the new unescaping function will happily interpret the "%45" > as a percent encoded letter "E". > > To detect at least some of such problematic links you can run the > attached command `dmaus/org-check-percent-escapes' in a Org mode > buffer. =A0It will scan all links in the buffer and issue a warning for > each link that contains a sequence that matches aformentioned pattern > and is not one of the escape sequences used by Org up to know. > > If you experience any problems with this change please don't forget to > Cc: me so the complaints will end up in my main mailbox. > > Best, > =A0-- David