emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: poverobuosodonati <poverobuosodonati@gmail.com>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: Leo Butler <Leo.Butler@umanitoba.ca>,
	emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: Language support for C# in org-babel
Date: Sun, 26 Jan 2025 20:05:54 +0100	[thread overview]
Message-ID: <9afcec0f-b392-4d22-8249-ffbd143db76d@gmail.com> (raw)
In-Reply-To: <878qrm33hi.fsf@localhost>

Thank you so much for your input and guidance.

I have put my "patch request" in a public repository. Please find it here
https://codeberg.org/buoso/csharp-babel

I've tried to document the incentive as well as the usage quite extensive.

I would like to propose to merge this as a maintainer as I'd like to 
take care of this library in future. That is, of course, if you think it 
is a useful addition and legitimate proposal.

I am very much looking forward to feedback on the code, the process in 
general, or anything beyond that.

Thanks again and

Best regards,
Max


On 07.01.25 19:04, Ihor Radchenko wrote:
> Buoso Donati <poverobuosodonati@gmail.com> writes:
>
>> Are there any objections against me trying to upstream this addition?
> C# is a popular language. I have no objections to adding it to the core.
>
>> ... I would go ahead and try to open a pull request following the
>> guidelines from this documentation
>> (https://orgmode.org/worg/org-contribute.html) if there are none. Or
>> is there a better way/no need for it in the first place?
> If you can, please do follow what is written in our contribution guide.
> But feel free to ask us anything if you encounter difficulties.
> You do not have to go through all the requirements alone.
>
>> In fact, I was most inspired by the existing ob-C.el and ob-java.el!
>>   From what I understand C# (in conjunction with csproj-files) is
>> "different enough" from C/C++ and Java (I don't feel particularly
>> comfortable judging the D language) that it somewhat makes sense to
>> create an individual file integrating it (as opposed to increase the
>> complexity with existing integrations).
>> I will however consider this and re-evaluate my initial concept with
>> your feedback.
> Generally, it only makes sense to extend an existing library if there is
> very significant code sharing. Otherwise, no need to complicate things.
>
> Also, before you proceed, note that there is ob-csharp in org-contrib
> repository:
> https://git.sr.ht/~bzg/org-contrib/tree/master/item/lisp/ob-csharp.el
> It is very simplistic though. Just letting you know so that you are
> aware.
>
> You do not need to reuse that file or anything like that - we *cannot*
> use that file because its author did not sign copyright papers. (BTW,
> you do need to do it - let me know if you need any assistance)
>
> After your future patch is accepted, we will likely remove ob-csharp
> from org-contrib. Which means that you should name the new library
> ob-csharp as well - it will serve as the replacement.
>


      reply	other threads:[~2025-01-26 19:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-06 17:44 Language support for C# in org-babel poverobuosodonati
2025-01-06 18:19 ` Leo Butler
2025-01-06 21:09   ` Buoso Donati
2025-01-07 18:04     ` Ihor Radchenko
2025-01-26 19:05       ` poverobuosodonati [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9afcec0f-b392-4d22-8249-ffbd143db76d@gmail.com \
    --to=poverobuosodonati@gmail.com \
    --cc=Leo.Butler@umanitoba.ca \
    --cc=emacs-orgmode@gnu.org \
    --cc=yantar92@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).