Re: Bug fix: org-mhe links don't work with mairix

[Carsten Dominik <carsten.dominik@gmail.com>]

I have applied the patch, thank you.

- Carsten

On May 15, 2008, at 5:31 AM, Nick Dokos wrote:

> Hi Carsten,
>
> Pete Phillips had run into a problem back in November 2007 with mhe
> links to emails not working (he was using mairix as the mh search
> method). I just sent a patch to Bill Wohler about the mh-e part (and
> copied both the mh-e list and the org list: the problem is described  
> in
> more detail there). Here is the org-mode patch.
>
> I've tested the patch both with the default "pick" search in mh-e and
> with "mairix" search. Pete Phillips also did some testing (I believe
> with mairix) - thanks Pete!
>
> I would feel better if there had been some swish++/namazu/etc  
> testing as
> well, but it's unlikely that I'll find the time in the foreseeable
> future. In particular, I'm not sure where the angle brackets are  
> needed:
> it's clear they are needed for the pick search and I've found out that
> they are *not* needed for mairix search, but if swish++ needs them,  
> that
> would complicate things. The patch assumes that they are not needed  
> for
> any search method, other than pick. If somebody on the list could  
> try it
> and report success/failure, I, for one, would appreciate it very much.
>
> If it looks OK to you, could you please apply it?
>
> Thanks very much,
> Nick
>
> --- a/lisp/org-mhe.el
> +++ b/lisp/org-mhe.el
> @@ -194,16 +194,16 @@ folders."
>   (mh-find-path)
>   (if (not article)
>       (mh-visit-folder (mh-normalize-folder-name folder))
> -    (setq article (org-add-angle-brackets article))
>     (mh-search-choose)
>     (if (equal mh-searcher 'pick)
>         (progn
> +          (setq article (org-add-angle-brackets article))
>           (mh-search folder (list "--message-id" article))
>           (when (and org-mhe-search-all-folders
>                      (not (org-mhe-get-message-real-folder)))
>             (kill-this-buffer)
>             (mh-search "+" (list "--message-id" article))))
> -      (mh-search "+" article))
> +      (mh-search "+" (funcall mh-search-regexp-builder (list (cons  
> 'message-id article)))))
>     (if (org-mhe-get-message-real-folder)
>         (mh-show-msg 1)
>       (kill-this-buffer)
>
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode