From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id COIPOBOG+WOBGAEAbAwnHQ (envelope-from ) for ; Sat, 25 Feb 2023 04:52:52 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id GAgrNxOG+WP7FAEAG6o9tA (envelope-from ) for ; Sat, 25 Feb 2023 04:52:51 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9836216A8D for ; Sat, 25 Feb 2023 04:52:51 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=kqUl21Kr; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1677297171; a=rsa-sha256; cv=none; b=Ly5/OeuEg4eGZh37wRyAC9phYJrddFs+IQGjCxogFXYsf9ROcnvWtawfWCx/KR17y0DIqt /KCC06pcVxSAfGBrB18niCVmz/l8BPGXNarmDCmnGBx8PCnCAQ9TThGM2TZWt5yO1cWzS6 ZeqHFoiEBLrHJDHgMSXJ3O1tEbu7mJW28H5JLuYEaG3ZC7ive1T1LwyrdiNdpepErBJIYe SD1nwbHRMfTMuFxkleuOhtgTlnBw6PJv+gT84aRzMoPd0VWfhCgb06owXmeUquzlr1q7Lk Tft68vuU7efzlEmIj+9Aig5Ca+t9kK4pOkojUU6O/3W3J7vkir6imsMS19vlYA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=kqUl21Kr; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1677297171; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=/VTTj30ODFd2BG2ShvxUQkr/Jqx6/CYgmkCdBhuyj88=; b=syeQRaUqmOfHKlv7HI9VcjDYIstgl8S2BF6Q0T4t49k0RaxAkUMlpEpo1gV/2hCfL50bi3 EkwgKwaa/TJyObaHcub9Ov0r8LJgImkYGfT3PKoyo0NuEzJcMaA8nDOOoYTkSr/uVP//Sv WPIo/W9E4IFW3OgttQZ8x5Ec5wxCYTcrK6YnBedYNWIVX5+F7AekASgg9Wx1S3wnHf6xGX gkmIaPL7Guor2JdoW7Nm14ZfNVPatIaj0lNpUmHeYFXZUwqdvaFhRr2kNo55RP88NztA0d wKYHxfUKpvXGyKVoByJEVLXx/aE1Z4raItlDhFyQyM5O4fwpWXUTKUs2q0KhWQ== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVlbC-0000Af-Cc; Fri, 24 Feb 2023 22:51:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVlbA-0000AT-6C for emacs-orgmode@gnu.org; Fri, 24 Feb 2023 22:51:48 -0500 Received: from mail-lf1-x131.google.com ([2a00:1450:4864:20::131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVlb8-000509-Fm for emacs-orgmode@gnu.org; Fri, 24 Feb 2023 22:51:47 -0500 Received: by mail-lf1-x131.google.com with SMTP id bp25so1764510lfb.0 for ; Fri, 24 Feb 2023 19:51:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:cc:to:references :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=/VTTj30ODFd2BG2ShvxUQkr/Jqx6/CYgmkCdBhuyj88=; b=kqUl21Kr5Pe86Lrn1L38jJSzBaUsC3t4kr4CpeaLWzFd7rbtQejy0W4guidkMOC7Io ZVbzKQfjR97Q79WQ74ZTkbTtYL6dBUts5WdjO4hH0ElddnqxD2iVQU5Brfb8l0gpUbG+ 3YuE5LiWZ/zCFDw5PEKGYExxHN6aTG4p7wtpQL8PI12ZY4yq8wZ80FJRPXILL/qs9djn ilUMDjwRggNn7cPLzfjlhT2eNrFvdmDWlgTtPwBff3OQ6SSpE55zb7jvGYDfhR7vz1uL UDnEC1+EyZ5PKgXr8b5LsRSIa8PeD0CME2IW1CcOeBfNXcK3+TrAR0npWg6a6kNa4e+a 90yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:cc:to:references :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/VTTj30ODFd2BG2ShvxUQkr/Jqx6/CYgmkCdBhuyj88=; b=kmq5pj9mUr/oOaxnn1K3WGz4XI1VWjLuOq2JMLV3Ta0VqTXlm5jZKBOe81nzOLmDmc MY2JzW+TPsR1cTo0dXEbTXtpwTYOpmaqM6eDFd1sCS+wqZkWzPtotmil5bZlcw7kYv+D 7sKRcaJY3vHwWKyvNyrA9t6WgTyn1wG9mUzts54dJUluSpEMUbxV6bgoxHOL1+cYfEjR +Jr+E5aoLkIOwiru1WzVYZfhbdXFw8Pt2Uog3a6A1sy4+nDKDz+yPFXmeEdQ7VcvOUqI OHlmtzYN40TJc7tRkaOu5hk/mTLSgQPAasoVYJAsjcFbu289woPpJ2jX1l7/GLL52vub UbdA== X-Gm-Message-State: AO0yUKVAzIoIvcuseP+l8j9WL1rQSW72sy3azX1GanyIHhQbLcn8WPaD WswJZnLq7T231fnLp/YmusRuslVPBkc= X-Google-Smtp-Source: AK7set8xo6rDzRAu8Ly3KC626TXLpx1K8JyhlDNm+2W0cqqJwKgCh9BmIE2vMTX7rxvRPmZMm5O/hA== X-Received: by 2002:ac2:5496:0:b0:4d8:764e:5cae with SMTP id t22-20020ac25496000000b004d8764e5caemr5945891lfk.48.1677297102992; Fri, 24 Feb 2023 19:51:42 -0800 (PST) Received: from [192.168.0.101] (nat-0-0.nsk.sibset.net. [5.44.169.188]) by smtp.googlemail.com with ESMTPSA id u15-20020a056512094f00b004db2c3b4ab5sm86285lft.296.2023.02.24.19.51.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Feb 2023 19:51:42 -0800 (PST) Message-ID: <96a91a35-eeb6-55d3-683d-5d51ff6d496e@gmail.com> Date: Sat, 25 Feb 2023 10:51:41 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] lisp/ob-screen.el: Support ~:var~ header args for babel blocks Content-Language: en-US References: <87pm9z8089.fsf@t480.home> <87y1om7w23.fsf@t480.home> To: emacs-orgmode@gnu.org Cc: Ken Mankoff From: Max Nikulin In-Reply-To: <87y1om7w23.fsf@t480.home> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::131; envelope-from=manikulin@gmail.com; helo=mail-lf1-x131.google.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, NICE_REPLY_A=-0.094, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: X-Migadu-Queue-Id: 9836216A8D X-Spam-Score: -0.88 X-Migadu-Spam-Score: -0.88 X-Migadu-Scanner: scn0.migadu.com List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-TUID: NM6WFjZ23MZ9 On 25/02/2023 01:33, Ken Mankoff wrote: > Subject: [PATCH] lisp/ob-screen.el: Support ~:var~ header args for babel > blocks Thank you for the patch. I suppose, suggestion to send patches as attachments is added mostly to prevent patches inside HTML message body. If a message could be feed to "git am" then it should be OK. I am unsure if Org markup is suitable for commit messages (~:var~) since it may appear in Emacs commit logs. > +++ b/lisp/ob-screen.el ... > +(defun org-babel-variable-assignments:screen (params) > + "Return list of shell statements assigning the block's variables." > + ;; From ob-shell but change function name from ":shell" to ":screen" ... > + (if (string-suffix-p "bash" shell-file-name) > + (org-babel--variable-assignments:bash The code still depends on on ob-shell. Is there a reason why calling `org-babel-variable-assignments:shell' is a worse variant than copy of the whole function body?