Re: [O] [PATCH] ob-eval: display error fix

[Andreas Gerler <baron@bundesbrandschatzamt.de>]

[-- Attachment #1.1: Type: text/plain, Size: 1 bytes --]



[-- Attachment #1.2: 0001-lisp-ob-eval.el-Display-error-fix.patch --]
[-- Type: application/octet-stream, Size: 1873 bytes --]

From db391f4123a62aa214741d6b1eb43b0a1e06f1b9 Mon Sep 17 00:00:00 2001
From: Andreas Gerler <baron@bundesbrandschatzamt.de>
Date: Sat, 7 Jan 2023 14:04:03 +0100
Subject: [PATCH] * lisp/ob-eval.el: Display error fix

* lisp/ob-eval.el: (org-babel-eval-error-notify): Display standard
error only if command exits non zero.

The problem is that sql connections might give warnings.
Now the information is available in the *Org-Babel Error* buffer
without displaying.
If you need always display toggle org-babel-eval-error-display-notify.

Signed-off-by: Andreas Gerler <baron@bundesbrandschatzamt.de>
---
 lisp/ob-eval.el | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/lisp/ob-eval.el b/lisp/ob-eval.el
index 6f6edb949..f4659fe96 100644
--- a/lisp/ob-eval.el
+++ b/lisp/ob-eval.el
@@ -36,6 +36,12 @@
 (defvar org-babel-error-buffer-name "*Org-Babel Error Output*")
 (declare-function org-babel-temp-file "ob-core" (prefix &optional suffix))
 
+(defcustom org-babel-eval-error-display-notify nil
+  "Display org-babel-eval-errors always or only if exit code is not 0."
+  :group 'org-babel
+  :version "29.1"
+  :type 'boolean)
+
 (defun org-babel-eval-error-notify (exit-code stderr)
   "Open a buffer to display STDERR and a message with the value of EXIT-CODE."
   (let ((buf (get-buffer-create org-babel-error-buffer-name)))
@@ -45,7 +51,10 @@
         (unless (bolp) (insert "\n"))
         (insert stderr)
         (insert (format "[ Babel evaluation exited with code %S ]" exit-code))))
-    (display-buffer buf))
+    (when (or org-babel-eval-error-display-notify
+            (or (not (numberp exit-code))
+            (> exit-code 0)))
+        (display-buffer buf)))
   (message "Babel evaluation exited with code %S" exit-code))
 
 (defun org-babel-eval (command query)
-- 
2.39.0


[-- Attachment #1.3: Type: text/plain, Size: 972 bytes --]



Hi Ruijie,

thanks for asking.
I combined them now and tested again all variants.

Andreas

> On 7. Jan 2023, at 22:33, Ruijie Yu via General discussions about Org-mode. <emacs-orgmode@gnu.org> wrote:
> 
> 
> Hi Andreas,
> 
> -    (display-buffer buf))
> +    (if org-babel-eval-error-display-notify
> +        (display-buffer buf)
> +      (if (or (not (numberp exit-code))
> +              (> exit-code 0))
> +          (display-buffer buf))))
> 
> Quick question, does it help or hurt readability if we change this
> nested `if' into a `cond' expression?
> 
> Or, alternatively, since both the outer then branch and the inner then
> branch are the same expression, maybe we can just combine all three
> conditions into a single `or' call?
> 
> Something like
> 
> (when (or org-babel-eval-error-display-notify
>          (not (numberp exit-code))
>          (> exit-code 0))
>  (display-buffer buf))
> 
> Best,
> 
> 
> RY
> 


[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 874 bytes --]