From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: [Bug] Slightly wrong org-tag fontification in agenda Date: Fri, 12 Feb 2010 18:58:29 +0100 Message-ID: <92220325-DA7F-4020-9666-35CE689C3439@gmail.com> References: <87d40a8u7o.fsf@thinkpad.tsdh.de> Mime-Version: 1.0 (Apple Message framework v936) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ng03h-0003L0-3h for emacs-orgmode@gnu.org; Fri, 12 Feb 2010 13:16:05 -0500 Received: from [140.186.70.92] (port=43956 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ng03f-0003JX-PI for emacs-orgmode@gnu.org; Fri, 12 Feb 2010 13:16:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Ng03f-0001oA-DM for emacs-orgmode@gnu.org; Fri, 12 Feb 2010 13:16:03 -0500 Received: from mail-ew0-f228.google.com ([209.85.219.228]:60148) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ng03f-0001kg-2d for emacs-orgmode@gnu.org; Fri, 12 Feb 2010 13:16:03 -0500 Received: by mail-ew0-f228.google.com with SMTP id 28so1486718ewy.8 for ; Fri, 12 Feb 2010 10:16:02 -0800 (PST) In-Reply-To: <87d40a8u7o.fsf@thinkpad.tsdh.de> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Tassilo Horn Cc: emacs-orgmode@gnu.org Hi Tassilo, On Feb 12, 2010, at 2:22 PM, Tassilo Horn wrote: > Hi all, > > it seems that org fontifies everything in the agenda following the > heading using the org-tag face. Basically, that's ok *unless* you > don't > use a special background color for tags. Then it looks wrong. > > Here's a screenshot showing the fontification. > > I'm using a current git version (Org-mode version 6.34trans > (release_6.34c.67.g25f76f)). > > I had a quick look at the code, and it seems the problem is in > `org-agenda-align-tags'. Yes, I think it is fixed now. > > BTW: Is it really a good decision to propertize the text > algorithmically > in the functions building the agenda? I'm not sure, but it might be > easier to define some `org-agenda-font-lock-keywords' like it's done > for > org files, too. That is a good question. I do, however, not believe that it would be easy to define font lock keywords which can handle the agenda. For example, when an item changes state, its face is changed, to something with depends on where the item comes from and, for example, how close the deadline is. And more stuff like that. So font-lock regexp matching is now enough here. Yes, it would be enough for tags, but not for other stuff. - Carsten