From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id SFheMyiz7WAg/AAAgWs5BA (envelope-from ) for ; Tue, 13 Jul 2021 17:37:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id EMQuLyiz7WCqdgAAB5/wlQ (envelope-from ) for ; Tue, 13 Jul 2021 15:37:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A01064B15 for ; Tue, 13 Jul 2021 17:37:11 +0200 (CEST) Received: from localhost ([::1]:44452 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m3KT8-0000FO-5P for larch@yhetil.org; Tue, 13 Jul 2021 11:37:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56088) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3KSk-0000F0-1b for emacs-orgmode@gnu.org; Tue, 13 Jul 2021 11:36:46 -0400 Received: from virgo.ocssolutions.com ([67.43.1.28]:39976) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3KSi-00021M-8Z for emacs-orgmode@gnu.org; Tue, 13 Jul 2021 11:36:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ristow.info ; s=default; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=aE+UwUCuojL2pfXwgEGps63RYyGkTJHFHIvjW1Tty3Y=; b=e9XY7jfXXK2uNLdg6y5MqsGUJk viWqZyr8FfNx6ZmLKJcYvwfdtRH9L4v6YcHBgJviIdbfJ1GHtuAmEbcThMDEbWF3mlU6uIjGQ+DiH VA5+/KTHQYPTiDEdGJxjl3EYzszZIlb3JHcOEMWIJFySwZSc5Pp9FnY1IH8g7ImE7CrE/wgXt2eN3 3Xe+JXSjoAo4G1aq7GG3Px7HhQJwmwgzECiRg13ijTIW0Xy6Drw2ER7xs6Ld8b92uVsvyN3RVDaWW gG8HDTEVqCfDKr62k0X+wgcOJxwZXfK8QS28yZ5jxLQGgSeoA4sVWqRpcmiVzi6uBYiMSqy/NN5kT nwrFDMPg==; Received: from [88.162.227.118] (port=52336 helo=[192.168.0.177]) by virgo.ocssolutions.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1m3KS0-000OVC-Cq; Tue, 13 Jul 2021 10:36:00 -0500 Subject: Re: [PATCH] Bug: Duplicate logbook entry for repeated tasks [9.4.6 (9.4.6-gab9f2a @ /home/gustavo/.emacs.d/elpa/org-9.4.6/)] To: Carlo Tambuatco , Bhavin Gandhi References: <877diwbm6a.fsf@gmail.com> <87a6muwa93.fsf@localhost> <874kd1wsc6.fsf@localhost> <871r85wgqd.fsf@localhost> <87wnpxv1d8.fsf@localhost> From: Alan Ristow Message-ID: <907e39a9-75fa-a99f-7237-a754a8d795f7@ristow.info> Date: Tue, 13 Jul 2021 17:35:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - virgo.ocssolutions.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - ristow.info X-Get-Message-Sender-Via: virgo.ocssolutions.com: authenticated_id: alan@ristow.info X-Authenticated-Sender: virgo.ocssolutions.com: alan@ristow.info X-Source: X-Source-Args: X-Source-Dir: Received-SPF: pass client-ip=67.43.1.28; envelope-from=alan@ristow.info; helo=virgo.ocssolutions.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.368, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Org-Mode Mailing List , Ihor Radchenko , Gustavo Barros Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1626190632; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=aE+UwUCuojL2pfXwgEGps63RYyGkTJHFHIvjW1Tty3Y=; b=qyLDMXsn3l45alw8pRswInHHnT3yaor31/vqO/3h/daOmRQRh/N8/0UgAQTzj1e3WFENvw SoV1SZtkgSs2TxGviQB+em2SdMK3zfnFkinvGougJ4h3+durdRyONFqWWvZWtmen9gQbYV eQ77vWqjYDfczKIxsrygOgLbBHt3aumRDbp+QW0p/NnknTtJyV6zyHfx7qSiggJb7RQyvp KqjQdSBo9DgohfyPLjKXqhMxxsL71X+FcPpt+CaR+UzZDll5fURaj3KP1mNYb1NI1G6nwn 3B5kXlBevJGIAmfC/USsXQ/NIwZvihG2XvhlwJ1IPgib92Uxlbc26SWd6C4T9A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1626190632; a=rsa-sha256; cv=none; b=tNNHWudGtp4QwSariBVBmrQ9vjtYP5+ZMCs3qG5APxBNhlvRIbz4FTFaa8WdiF/VCdSpUx yAJyekaKLanDCi9EfAG/Xt0JRbvg/WCzw+F3LsByaFGnIf03zsGivby2zBg0L3blWcIfGU ePda+dRZcZgb4XF2ax+UJqNd2JuhWbwFS9zDj56W9KRaljLXoC+Ox7o0p0llsz3HoQ42hN wbXfJhXlcL936HsI7r8AncRTUYGQf633+msEb5bRtEElJBAJ5ttqJwltyGjETBubgQx4mr ZXseDdWvx06SRgN5m8JfUvqZVUAM2sH+PzD2TmHGMiyCBzEso7DFWB2WUpgNWQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=ristow.info header.s=default header.b=e9XY7jfX; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: 0.10 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=ristow.info header.s=default header.b=e9XY7jfX; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: A01064B15 X-Spam-Score: 0.10 X-Migadu-Scanner: scn0.migadu.com X-TUID: Jewjfu0l4sEW On 7/13/21 4:55 AM, Carlo Tambuatco wrote: > Newbie question: what command do I use to apply the patch…? I can tell you what worked for me. I think you probably need to have cloned org using git for it to work, but I am far from being a git wiz so there could be a workaround I don't know about in the case that you have it installed by a more conventional method. First, I saved the patch file to the same directory where I have org cloned (for me, that is ~/.emacs.d/straight/repos/org). Then I opened a terminal and ran: git apply --check 0001-Fix-duplicate-logbook-entry-for-repeated-tasks.patch to do a dry run and make sure I had saved the patch file in the right place that "git apply" would run correctly. It returned nothing, which is good, so then I ran: git apply --check 0001-Fix-duplicate-logbook-entry-for-repeated-tasks.patch to apply the patch. Since I'm using straight.el as my package manager, I then opened Emacs and ran "M-x straight-rebuild-all". Also, thanks to Ihor and Bhavin for your work on this. Prior to applying the patch, I was noticing new bizarre behavior relating to recurring tasks. I haven't been running the patched org very long yet, but so far, so good. Finally, as a newbie here myself, I have a naïve question of my own: Provided the patch proves successful, how/when is it applied to the official org repo? Is it up to Ihor (or somebody else) to make a pull request, for example? Best regards, Alan