emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Carsten Dominik <carsten.dominik@gmail.com>
To: John J Foerch <jjfoerch@earthlink.net>
Cc: emacs-orgmode@gnu.org, emacs-devel@gnu.org
Subject: Re: [Orgmode] patch to outline.el concerning isearch
Date: Thu, 14 Dec 2006 18:54:45 +0100	[thread overview]
Message-ID: <8b0f2e638ee24e1c20681a0b7b293574@science.uva.nl> (raw)
In-Reply-To: <87bqm7yvyw.fsf@earthlink.net>

I strongly support this proposal, this is a feature that would be
very valuable.

- Carsten

On Dec 14, 2006, at 4:53, John J Foerch wrote:

> Hello,
>
> I want to implement a particular feature in org-mode that depends upon 
> some
> functionality being added to outline-mode.  (org-mode is derived from
> outline-mode.)  The feature concerns display of ancestor and sibling 
> headings
> when an isearch has come to successful completion in a hidden part of 
> the
> file.  The function whose job it is to decide what to display when an 
> isearch
> has completed is called `outline-isearch-open-invisible'.  Currently, 
> it
> simply calls `(show-entry)'.  The following patch changes that 
> function, and
> adds a new variable, to allow derived modes or motivated users to 
> implement
> alternate behavior.  The default behavior remains the same, but can 
> more
> easily be reprogrammed by a derived mode.
>
> Please comment, criticize, or enlighten.  Thank you,
>
> John Foerch
>
> Index: lisp/outline.el
> ===================================================================
> RCS file: /cvsroot/emacs/emacs/lisp/outline.el,v
> retrieving revision 1.24
> diff -r1.24 outline.el
> 745a746,757
>> (defvar outline-isearch-open-invisible-fun
>>   'outline-isearch-open-invisible-show-entry
>>   "Function that will be called when a successful isearch
>>   finishes in an invisible overylay.  The overlay will be passed
>>   to the function as its sole argument.")
>>
>> ;; Default function for outline-isearch-open-invisible-fun.  Makes 
>> only the
>> ;; single entry containing point visible.
>> (defun outline-isearch-open-invisible-show-entry (overlay)
>>   ;; We rely on the fact that isearch places point on the matched 
>> text.
>>   (show-entry))
>>
> 751c763,764
> <   (show-entry))
> ---
>>   (if outline-isearch-open-invisible-fun
>>       (funcall outline-isearch-open-invisible-fun overlay)))
> _______________________________________________
> Emacs-orgmode mailing list
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>

--
Carsten Dominik
Sterrenkundig Instituut "Anton Pannekoek"
Universiteit van Amsterdam
Kruislaan 403
NL-1098SJ Amsterdam
phone: +31 20 525 7477

  reply	other threads:[~2006-12-14 17:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-14  3:53 patch to outline.el concerning isearch John J Foerch
2006-12-14 17:54 ` Carsten Dominik [this message]
2006-12-15 12:17   ` Tim O'Callaghan
2006-12-15 13:14     ` Carsten Dominik
2006-12-14 21:28 ` John J Foerch
2006-12-16  1:03 ` Kim F. Storm
2006-12-16 16:32   ` John J Foerch
2006-12-17  0:49     ` Kim F. Storm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8b0f2e638ee24e1c20681a0b7b293574@science.uva.nl \
    --to=carsten.dominik@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=jjfoerch@earthlink.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).