From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: [PATCH v2] org.el: Don't flyspell check within source code blocks Date: Sat, 1 Jun 2013 08:15:12 +0200 Message-ID: <893F368F-3E66-4905-B51C-01C8CDCF1CE5@gmail.com> References: <1369466635-8217-1-git-send-email-trevor.m.murphy@gmail.com> <1369874995-24158-1-git-send-email-trevor.m.murphy@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 6.3 \(1503\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34775) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uif5w-0003qf-QB for emacs-orgmode@gnu.org; Sat, 01 Jun 2013 02:15:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uif5v-0005qr-RB for emacs-orgmode@gnu.org; Sat, 01 Jun 2013 02:15:16 -0400 Received: from mail-we0-x229.google.com ([2a00:1450:400c:c03::229]:54911) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uif5v-0005qD-LD for emacs-orgmode@gnu.org; Sat, 01 Jun 2013 02:15:15 -0400 Received: by mail-we0-f169.google.com with SMTP id w61so315933wes.0 for ; Fri, 31 May 2013 23:15:15 -0700 (PDT) In-Reply-To: <1369874995-24158-1-git-send-email-trevor.m.murphy@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Trevor Murphy Cc: emacs-orgmode@gnu.org Hi Trevor, have you noticed an impact of this patch on normal typing performance? This is something we need to be extremely careful about. - Carsten On 30.5.2013, at 02:49, Trevor Murphy wrote: > * lisp/org.el (org-mode-flyspell-verify): Add check for > `org-in-src-block-p'. >=20 > TINYCHANGE > --- > lisp/org.el | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/lisp/org.el b/lisp/org.el > index 94078f9..77de2d7 100644 > --- a/lisp/org.el > +++ b/lisp/org.el > @@ -23596,7 +23596,8 @@ To get rid of the restriction, use = \\[org-agenda-remove-restriction-lock]." > (not (member-ignore-case word (org-get-export-keywords))) > (not (member-ignore-case > word (mapcar 'car org-element-block-name-alist))) > - (not (member-ignore-case word '("BEGIN" "END" "ATTR")))))) > + (not (member-ignore-case word '("BEGIN" "END" "ATTR"))) > + (not (org-in-src-block-p))))) >=20 > (defun org-remove-flyspell-overlays-in (beg end) > "Remove flyspell overlays in region." > --=20 > 1.8.3 >=20 >=20