From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Maus Subject: Re: Bug: Getting property ALLTAGS always returns nil [6.33trans (release_6.33f.130.gb8e0)] Date: Sun, 17 Jan 2010 23:03:31 +0100 Message-ID: <87zl4c75jg.wl%maus.david@gmail.com> References: <873a248mf0.wl%maus.david@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: multipart/mixed; boundary="===============1774863863==" Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NWdDn-0000Yb-0c for emacs-orgmode@gnu.org; Sun, 17 Jan 2010 17:03:47 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NWdDi-0000Vt-Md for emacs-orgmode@gnu.org; Sun, 17 Jan 2010 17:03:46 -0500 Received: from [199.232.76.173] (port=60171 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NWdDi-0000Vi-Fo for emacs-orgmode@gnu.org; Sun, 17 Jan 2010 17:03:42 -0500 Received: from mail-fx0-f228.google.com ([209.85.220.228]:34805) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NWdDh-0003gO-E6 for emacs-orgmode@gnu.org; Sun, 17 Jan 2010 17:03:41 -0500 Received: by fxm28 with SMTP id 28so349451fxm.26 for ; Sun, 17 Jan 2010 14:03:36 -0800 (PST) In-Reply-To: <873a248mf0.wl%maus.david@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: David Maus Cc: emacs-orgmode@gnu.org --===============1774863863== Content-Type: multipart/signed; boundary="pgp-sign-Multipart_Sun_Jan_17_23:03:28_2010-1"; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit --pgp-sign-Multipart_Sun_Jan_17_23:03:28_2010-1 Content-Type: multipart/mixed; boundary="Multipart_Sun_Jan_17_23:03:28_2010-1" --Multipart_Sun_Jan_17_23:03:28_2010-1 Content-Type: text/plain; charset=US-ASCII And replying to myself: The problem seems to be that some if-clauses in `org-entry-properties' are not right: - when requesting the ALLTAGS property, the code that adds its value to the alist did not check if the variable `specific' is "ALLTAGS", but "TAGS" - when requesting the BLOCKED property, the code that adds its value to the alist did not check if the variable `specific' is "BLOCKED", but "TAGS" So requesting one of those properties explicitly didn't work. I attached three patches for org.el. Patch 0001 fixes a type in the docstring of `org-entry-properties', patch 0002 modifies the if-clause for the ALLTAGS property to check if `special' is "ALLTAGS" and patch 0003 modifies the if-clause for the BLOCKED property and adds BLOCKED to the list of properties that are excluded if user requests all or standard properties. Hope I got it right and understood the logic in this function. -- David -- OpenPGP... 0x99ADB83B5A4478E6 Jabber.... dmjena@jabber.org Email..... maus.david@gmail.com --Multipart_Sun_Jan_17_23:03:28_2010-1 Content-Type: application/octet-stream; type=patch Content-Disposition: attachment; filename="0001-fix-typo-in-docstring-of-org-entry-properties.patch" Content-Transfer-Encoding: base64 RnJvbSAxNGY2NGVkMTk2NWQ0MTA1OTdhMjJiYzVlMjJjMjY4NmU4NTQ1NjVlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZpZCBNYXVzIDxtYXVzLmRhdmlkQGdtYWlsLmNvbT4KRGF0 ZTogU3VuLCAxNyBKYW4gMjAxMCAyMjo0Mjo1OSArMDEwMApTdWJqZWN0OiBbUEFUQ0ggMS8zXSBm aXggdHlwbyBpbiBkb2NzdHJpbmcgb2YgYG9yZy1lbnRyeS1wcm9wZXJ0aWVzJwoKLS0tCiBsaXNw L29yZy5lbCB8ICAgIDIgKy0KIDEgZmlsZXMgY2hhbmdlZCwgMSBpbnNlcnRpb25zKCspLCAxIGRl bGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3Avb3JnLmVsIGIvbGlzcC9vcmcuZWwKaW5kZXgg ZWU4MWM0ZC4uOTY0ZGEzZiAxMDA2NDQKLS0tIGEvbGlzcC9vcmcuZWwKKysrIGIvbGlzcC9vcmcu ZWwKQEAgLTEyNTA5LDcgKzEyNTA5LDcgQEAgaWYgdGhlIHByb3BlcnR5IGtleSB3YXMgdXNlZCBz ZXZlcmFsIHRpbWVzLgogUE9NIG1heSBhbHNvIGJlIG5pbCwgaW4gd2hpY2ggY2FzZSB0aGUgY3Vy cmVudCBlbnRyeSBpcyB1c2VkLgogSWYgV0hJQ0ggaXMgbmlsIG9yIGBhbGwnLCBnZXQgYWxsIHBy b3BlcnRpZXMuICBJZiBXSElDSCBpcwogYHNwZWNpYWwnIG9yIGBzdGFuZGFyZCcsIG9ubHkgZ2V0 IHRoYXQgc3ViY2xhc3MuICBJZiBXSElDSAotaXMgYSBzdHJpbmcgb25seSBnZXQgZXhhY3RseSB0 aGlzIHByb3BlcnR5LiAgU3BlY2lmaWMgY2FuIGJlIGEgc3RpbmcsIHRoZQoraXMgYSBzdHJpbmcg b25seSBnZXQgZXhhY3RseSB0aGlzIHByb3BlcnR5LiAgU3BlY2lmaWMgY2FuIGJlIGEgc3RyaW5n LCB0aGUKIHNwZWNpZmljIHByb3BlcnR5IHdlIGFyZSBpbnRlcmVzdGVkIGluLiAgU3BlY2lmeWlu ZyBpdCBjYW4gc3BlZWQKIHRoaW5ncyB1cCBiZWNhdXNlIHRoZW4gdW5uZWNlc3NhcnkgcGFyc2lu ZyBpcyBhdm9pZGVkLiIKICAgKHNldHEgd2hpY2ggKG9yIHdoaWNoICdhbGwpKQotLSAKMS42LjUK Cg== --Multipart_Sun_Jan_17_23:03:28_2010-1 Content-Type: application/octet-stream; type=patch Content-Disposition: attachment; filename="0002-return-special-property-ALLTAGS-if-requested-so.patch" Content-Transfer-Encoding: base64 RnJvbSA2MWMyZDQ0NGE0MDUyOWEyYWJmZmI0NjZhNjdmZTY5MGVhNmMxOWI0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZpZCBNYXVzIDxtYXVzLmRhdmlkQGdtYWlsLmNvbT4KRGF0 ZTogU3VuLCAxNyBKYW4gMjAxMCAyMjo0NzozNSArMDEwMApTdWJqZWN0OiBbUEFUQ0ggMi8zXSBy ZXR1cm4gc3BlY2lhbCBwcm9wZXJ0eSBBTExUQUdTIGlmIHJlcXVlc3RlZCBzby4KCnRoZSBpZi1j bGF1c2UgdGhhdCB3b3VsZCBhZGQgdGhlIGNvbnMgZm9yIHRoZSBBTExUQUdTIHByb3BlcnR5IG5v dwpjaGVja3MgaWYgdXNlciByZXF1ZXN0ZWQgdGhpcyBwYXJ0aWN1bGFyIHByb3BlcnRpZXMgaW5z dGVhZCBvZgpjaGVja2luZyBmb3IgYSByZXF1ZXN0IG9mIHRoZSBUQUdTIHByb3BlcnR5LgotLS0K IGxpc3Avb3JnLmVsIHwgICAgMiArLQogMSBmaWxlcyBjaGFuZ2VkLCAxIGluc2VydGlvbnMoKyks IDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9vcmcuZWwgYi9saXNwL29yZy5lbApp bmRleCA5NjRkYTNmLi4yYWZlYzYwIDEwMDY0NAotLS0gYS9saXNwL29yZy5lbAorKysgYi9saXNw L29yZy5lbApAQCAtMTI1NDAsNyArMTI1NDAsNyBAQCB0aGluZ3MgdXAgYmVjYXVzZSB0aGVuIHVu bmVjZXNzYXJ5IHBhcnNpbmcgaXMgYXZvaWRlZC4iCiAJCSAgICAgICAoc2V0cSB2YWx1ZSAob3Jn LWdldC10YWdzLXN0cmluZykpCiAJCSAgICAgICAoc3RyaW5nLW1hdGNoICJcXFMtIiB2YWx1ZSkp CiAJICAgICAgKHB1c2ggKGNvbnMgIlRBR1MiIHZhbHVlKSBwcm9wcykpCi0JICAgICh3aGVuIChh bmQgKG9yIChub3Qgc3BlY2lmaWMpIChzdHJpbmc9IHNwZWNpZmljICJUQUdTIikpCisJICAgICh3 aGVuIChhbmQgKG9yIChub3Qgc3BlY2lmaWMpIChzdHJpbmc9IHNwZWNpZmljICJBTExUQUdTIikp CiAJCSAgICAgICAoc2V0cSB2YWx1ZSAob3JnLWdldC10YWdzLWF0KSkpCiAJICAgICAgKHB1c2gg KGNvbnMgIkFMTFRBR1MiIChjb25jYXQgIjoiIChtYXBjb25jYXQgJ2lkZW50aXR5IHZhbHVlICI6 IikKIAkJCQkJICAgICI6IikpCi0tIAoxLjYuNQoK --Multipart_Sun_Jan_17_23:03:28_2010-1 Content-Type: application/octet-stream; type=patch Content-Disposition: attachment; filename="0003-return-special-property-BLOCKED-if-requested-so.patch" Content-Transfer-Encoding: base64 RnJvbSA1OTRlOWRmNzUxZTJhNzEwZjg4ZThiNmEwMGMxODI2ODlkNzQzZDZkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZpZCBNYXVzIDxtYXVzLmRhdmlkQGdtYWlsLmNvbT4KRGF0 ZTogU3VuLCAxNyBKYW4gMjAxMCAyMjo1MToyNiArMDEwMApTdWJqZWN0OiBbUEFUQ0ggMy8zXSBy ZXR1cm4gc3BlY2lhbCBwcm9wZXJ0eSBCTE9DS0VEIGlmIHJlcXVlc3RlZCBzby4KCnRoZSBpZi1j bGF1c2Ugbm93IGNoZWNrcyBpZiB1c2VyIHNwZWNpZmljYWxseSByZXF1ZXN0ZWQgdGhlIHZhbHVl IG9mCnRoZSBCTE9DS0VEIHByb3BlcnR5LgotLS0KIGxpc3Avb3JnLmVsIHwgICAgNCArKy0tCiAx IGZpbGVzIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1n aXQgYS9saXNwL29yZy5lbCBiL2xpc3Avb3JnLmVsCmluZGV4IDJhZmVjNjAuLjQ0MTUyNDAgMTAw NjQ0Ci0tLSBhL2xpc3Avb3JnLmVsCisrKyBiL2xpc3Avb3JnLmVsCkBAIC0xMjUxNSw3ICsxMjUx NSw3IEBAIHRoaW5ncyB1cCBiZWNhdXNlIHRoZW4gdW5uZWNlc3NhcnkgcGFyc2luZyBpcyBhdm9p ZGVkLiIKICAgKHNldHEgd2hpY2ggKG9yIHdoaWNoICdhbGwpKQogICAob3JnLXdpdGgtcG9pbnQt YXQgcG9tCiAgICAgKGxldCAoKGNsb2Nrc3RyIChzdWJzdHJpbmcgb3JnLWNsb2NrLXN0cmluZyAw IC0xKSkKLQkgIChleGNsdWRlZCAnKCJUT0RPIiAiVEFHUyIgIkFMTFRBR1MiICJQUklPUklUWSIp KQorCSAgKGV4Y2x1ZGVkICcoIlRPRE8iICJUQUdTIiAiQUxMVEFHUyIgIlBSSU9SSVRZIiAiQkxP Q0tFRCIpKQogCSAgKGNhc2UtZm9sZC1zZWFyY2ggbmlsKQogCSAgYmVnIGVuZCByYW5nZSBwcm9w cyBzdW0tcHJvcHMga2V5IHZhbHVlIHN0cmluZyBjbG9ja3N1bSkKICAgICAgIChzYXZlLWV4Y3Vy c2lvbgpAQCAtMTI1NDUsNyArMTI1NDUsNyBAQCB0aGluZ3MgdXAgYmVjYXVzZSB0aGVuIHVubmVj ZXNzYXJ5IHBhcnNpbmcgaXMgYXZvaWRlZC4iCiAJICAgICAgKHB1c2ggKGNvbnMgIkFMTFRBR1Mi IChjb25jYXQgIjoiIChtYXBjb25jYXQgJ2lkZW50aXR5IHZhbHVlICI6IikKIAkJCQkJICAgICI6 IikpCiAJCSAgICBwcm9wcykpCi0JICAgICh3aGVuIChvciAobm90IHNwZWNpZmljKSAoc3RyaW5n PSBzcGVjaWZpYyAiVEFHUyIpKQorCSAgICAod2hlbiAob3IgKG5vdCBzcGVjaWZpYykgKHN0cmlu Zz0gc3BlY2lmaWMgIkJMT0NLRUQiKSkKIAkgICAgICAocHVzaCAoY29ucyAiQkxPQ0tFRCIgKGlm IChvcmctZW50cnktYmxvY2tlZC1wKSAidCIgIiIpKSBwcm9wcykpCiAJICAgICh3aGVuIChvciAo bm90IHNwZWNpZmljKQogCQkgICAgICAobWVtYmVyIHNwZWNpZmljIG9yZy1hbGwtdGltZS1rZXl3 b3JkcykKLS0gCjEuNi41Cgo= --Multipart_Sun_Jan_17_23:03:28_2010-1-- --pgp-sign-Multipart_Sun_Jan_17_23:03:28_2010-1 Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iF4EABEIAAYFAktTiTMACgkQma24O1pEeOYx1wEAvx4YVmFhh4ESAEh9MDxZI9pp EcBagUn/VnLj6V7c3fMBAN0NRuuD1cZC0favKpW9mCo0sFg3tb9Kl/cAwecTafVu =UqwS -----END PGP SIGNATURE----- --pgp-sign-Multipart_Sun_Jan_17_23:03:28_2010-1-- --===============1774863863== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode --===============1774863863==--