From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Eric Schulte" Subject: Re: Re: A request: Moving away from ChangeLog Date: Fri, 21 May 2010 10:32:48 -0600 Message-ID: <87zkztz03z.fsf@gmail.com> References: <2151275B-C80E-4B40-9022-8C9054020163@gmail.com> <469766F9-7C25-4792-A203-B241C22E2ED5@gmail.com> <94D31A4E-B262-4E06-AE2A-9C3D43145CAC@gmail.com> <7D47FD95-8C8D-4540-864A-D2C76B998A52@gmail.com> <87wruxicy4.fsf@thinkpad.tsdh.de> <32B3D851-51FA-43FA-8B14-594597FB42A1@gmail.com> <87tyq12ri9.fsf@gollum.intra.norang.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from [140.186.70.92] (port=53992 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OFV9b-0006ZV-Vo for emacs-orgmode@gnu.org; Fri, 21 May 2010 12:32:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OFV9Y-0004iz-JC for emacs-orgmode@gnu.org; Fri, 21 May 2010 12:32:55 -0400 Received: from mail-pv0-f169.google.com ([74.125.83.169]:63971) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OFV9Y-0004il-DJ for emacs-orgmode@gnu.org; Fri, 21 May 2010 12:32:52 -0400 Received: by pvg2 with SMTP id 2so854437pvg.0 for ; Fri, 21 May 2010 09:32:51 -0700 (PDT) In-Reply-To: <87tyq12ri9.fsf@gollum.intra.norang.ca> (Bernt Hansen's message of "Fri, 21 May 2010 11:39:42 -0400") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bernt Hansen Cc: Tassilo Horn , emacs-orgmode@gnu.org Bernt Hansen writes: > John Wiegley writes: > >> On May 21, 2010, at 9:47 AM, Tassilo Horn wrote: >> >>> I think it would be better if line 3+ would be exact ChangeLog entries >>> format-wise, so that you can still use emacs' ChangeLog facilities >>> (`add-change-log-entry'). I don't really want to write the changed file >>> and function names on my own, and adding them correctly is exactly what >>> that function does very well. >> >> This ends up looking rather ugly in the history, and I would hate to >> see VCS history bent merely to conform to tools usage. >> >> Rather, the history should be as clean and exact as possible. If >> elisp functions need to be written to convert ChangeLog entries to a >> suitable format, I can do that. >> >> Also, in magit if you press 'C' on any diff hunk, it auto-generates a >> properly formatted ChangeLog-style comment into the current commit >> log. > > I also prefer descriptive and succinct commit messages. > > It should be possible to automatically retrieve function information and > other items from the source based on hunk line information and the > source code in a tool that builds the Changelog. > Yes, `which-function' should be sufficient for collecting the names of modified functions. > > I make most of my git commits (including org-mode) in vim which is > kicked off from raw command-line git. I normally make multiple changes > at once and then build separate commits by using git's editing hunk > features from 'git add -p'. I don't think that functionality is > available in magit yet. > > Requiring an elisp-only solution for making commits isn't ideal -- the > tools should be as flexible as possible. > > I have no issue with the maintainers rejecting patches and requesting > changes to the commit messages so that they can be applied to the > project but I wouldn't want to require the use of a specific tool to do > the job. > I think this could be a good candidate for a user-end pre-commit hook. Since everyone on this project can be assumed to have a working Emacs instillation it should be possible for git to run an elisp function (through emacs --batch) before every commit which make the necessary changelog changes (and possibly adds some key to the commit message which could be checked by a gatekeeper commit-hook on the remote repository to ensure compliance). > > Regards, > Bernt > > _______________________________________________ > Emacs-orgmode mailing list > Please use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode