emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Sebastian Rose <sebastian_rose@gmx.de>
To: Emacs-orgmode mailing list <emacs-orgmode@gnu.org>
Subject: Re: [Patch] file protocol in HTML links
Date: Wed, 26 May 2010 11:51:42 +0200	[thread overview]
Message-ID: <87zkznkn2p.fsf@gmx.de> (raw)
In-Reply-To: <874ohvm2bk.fsf@gmx.de> (Sebastian Rose's message of "Wed, 26 May 2010 11:37:03 +0200")

Sebastian Rose <sebastian_rose@gmx.de> writes:
> The appended patch removes the protocol part from link URIs, if the
> protocol is file. Neccessary, to show images again and make links work.
>
>
> diff --git a/lisp/org-html.el b/lisp/org-html.el
> index d5f4775..8f7d0f3 100644
> --- a/lisp/org-html.el
> +++ b/lisp/org-html.el
> @@ -640,7 +640,7 @@ MAY-INLINE-P allows inlining it as an image."
>  	 (setq thefile 
>  	    (let
>  	       ((str (org-export-html-format-href thefile)))
> -	       (if type
> +	       (if (and type (not (string= "file" type)))
>  		  (concat type ":" str)
>  		  str)))

Hi,


I just pulled and saw it was fixed already - but in a wrong way, I
believe. How  about an absolute link URL with a different protocol like
gopher?

I think adding the protocol should be done, if the protocol is different
from that used to deliver the file which contains the link.

There's no need to add the protocol to an absolute path.



  Sebastian

  reply	other threads:[~2010-05-26  9:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-26  9:37 [Patch] file protocol in HTML links Sebastian Rose
2010-05-26  9:51 ` Sebastian Rose [this message]
2010-05-27  8:57   ` Carsten Dominik
2010-05-27 21:34     ` Sebastian Rose
2010-05-27 21:51       ` Carsten Dominik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zkznkn2p.fsf@gmx.de \
    --to=sebastian_rose@gmx.de \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).