emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: aaronecay@gmail.com
To: "Thomas S. Dye" <tsd@tsdye.com>
Cc: Org-mode <emacs-orgmode@gnu.org>, Nicolas Goaziou <n.goaziou@gmail.com>
Subject: Re: [BUG] attr_latex in new exporter
Date: Fri, 08 Mar 2013 12:38:17 -0500	[thread overview]
Message-ID: <87zjydkd12.fsf@gmail.com> (raw)
In-Reply-To: <m1obetbz8d.fsf@tsdye.com>

Hi Thomas,

I think the following patch (on top of current master) will fix the
problem:
-----cut-here-----
diff --git c/lisp/ox-latex.el w/lisp/ox-latex.el
index d17dd60..eefb272 100644
--- c/lisp/ox-latex.el
+++ w/lisp/ox-latex.el
@@ -1811,9 +1811,9 @@ used as a communication channel."
 	 ;; It is possible to specify width and height in the
 	 ;; ATTR_LATEX line, and also via default variables.
 	 (width (format "%s" (cond ((plist-get attr :width))
-				   ((eq float 'figure) "0.7\\textwidth")
+                                   ((plist-get attr :height) "")
+                                   ((eq float 'figure) "0.7\\textwidth")
 				   ((eq float 'wrap) "0.48\\textwidth")
-				   ((plist-get attr :height) "")
 				   (t org-latex-image-default-width))))
 	 (height (format "%s" (cond ((plist-get attr :height))
 				    ((or (plist-get attr :width)
-----cut-here-----

Nicolas, I’m not sure I understand the logic behind (memq float '(figure
wrap)) in the cond for setting height.  I think that it would be very
rare for someone to set the default height to something other than "",
but in the event that the user does so I don’t see why it shoudl make a
difference whether the image is floating or not.

-- 
Aaron Ecay

  reply	other threads:[~2013-03-08 17:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-08  4:25 [BUG] attr_latex in new exporter Thomas S. Dye
2013-03-08 10:34 ` Nicolas Goaziou
2013-03-08 17:03   ` Thomas S. Dye
2013-03-08 17:38     ` aaronecay [this message]
2013-03-08 21:40       ` Nicolas Goaziou
2013-03-09 18:25         ` Thomas S. Dye

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zjydkd12.fsf@gmail.com \
    --to=aaronecay@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=n.goaziou@gmail.com \
    --cc=tsd@tsdye.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).