From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Schulte Subject: Re: [PATCH] Don't ask "File changed on disk" in org-babel-post-tangle-hook Date: Fri, 07 Jun 2013 07:23:41 -0600 Message-ID: <87zjv2uk9u.fsf@gmail.com> References: <878v2omz5g.fsf@krugs.de> <51af4bfd.0c95ec0a.2372.097e@mx.google.com> <87ehcf6xey.fsf@gmail.com> <87ehcewdye.fsf@krugs.de> <87wqq6uxrg.fsf@krugs.de> <87fvwufat5.fsf_-_@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51583) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ukwef-0008PM-7L for emacs-orgmode@gnu.org; Fri, 07 Jun 2013 09:24:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ukwed-0008Ea-OC for emacs-orgmode@gnu.org; Fri, 07 Jun 2013 09:24:33 -0400 Received: from mail-pb0-x232.google.com ([2607:f8b0:400e:c01::232]:32888) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ukwed-0008EF-BJ for emacs-orgmode@gnu.org; Fri, 07 Jun 2013 09:24:31 -0400 Received: by mail-pb0-f50.google.com with SMTP id wy17so4630398pbc.23 for ; Fri, 07 Jun 2013 06:24:30 -0700 (PDT) In-Reply-To: <87fvwufat5.fsf_-_@gmail.com> (Vitalie Spinu's message of "Fri, 07 Jun 2013 12:57:10 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Vitalie Spinu Cc: Rainer M Krug , emacs-orgmode@gnu.org Vitalie Spinu writes: > The problem with org-babel-post-tangle-hook is that user is always asked > yes-or-no-p for file reversion. Calling auto revert (as Rainer tried) > will not help. > > The problem is in find-file-noselect in org-babel-find-file-noselect-refresh. > > The following patch fixes it by silencing find-file-noselect. Besides > reversion question, there are a couple of other warning/questions that > are silenced, but given that org-babel-find-file-noselect-refresh is > used only for reverting tangled files, this is probably not an issue. > Applied. Thanks, > > Vitalie > > > From 2f408019b940c7e3b742dd2941f725f97645b868 Mon Sep 17 00:00:00 2001 > From: Vitalie Spinu > Date: Fri, 7 Jun 2013 12:43:55 +0200 > Subject: [PATCH] avoid file warnings in org-babel-post-tangle-hook > > * lisp/ob-tangle.el (org-babel-find-file-noselect-refresh): call > find-file-noselect with 'nowarn argument to surpress yes-or-no-p > reversion message. > --- > lisp/ob-tangle.el | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lisp/ob-tangle.el b/lisp/ob-tangle.el > index 95d518a..82f2c10 100644 > --- a/lisp/ob-tangle.el > +++ b/lisp/ob-tangle.el > @@ -114,7 +114,7 @@ result. The default value is `org-babel-trim'." > (defun org-babel-find-file-noselect-refresh (file) > "Find file ensuring that the latest changes on disk are > represented in the file." > - (find-file-noselect file) > + (find-file-noselect file 'nowarn) > (with-current-buffer (get-file-buffer file) > (revert-buffer t t t))) -- Eric Schulte http://cs.unm.edu/~eschulte