From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <n.goaziou@gmail.com>
Subject: Re: [PATCH (v3)][ox-latex.el] Allow AUTO argument to
 org-latex-guess-babel-language.
Date: Sun, 09 Jun 2013 09:55:03 +0200
Message-ID: <87zjuzvhuw.fsf@gmail.com>
References: <87sj12bwzj.fsf@pank.eu> <8661xvprju.fsf@somewhere.org>
	<87ehcj9uh7.fsf@pank.eu> <8638sz1e3b.fsf@somewhere.org>
	<87obbn8c36.fsf@pank.eu> <86wqqae5n4.fsf@somewhere.org>
	<87ppw26xe2.fsf_-_@pank.eu> <87y5aollyh.fsf@gmail.com>
	<87txlbylja.fsf_-_@pank.eu> <87r4gew128.fsf@gmail.com>
	<8738sux7pw.fsf@pank.eu>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43518)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1UlaSn-0006CL-A1
	for emacs-orgmode@gnu.org; Sun, 09 Jun 2013 03:54:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1UlaSl-0005S4-L0
	for emacs-orgmode@gnu.org; Sun, 09 Jun 2013 03:54:57 -0400
Received: from mail-wg0-x236.google.com ([2a00:1450:400c:c00::236]:49808)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1UlaSl-0005Rs-Ec
	for emacs-orgmode@gnu.org; Sun, 09 Jun 2013 03:54:55 -0400
Received: by mail-wg0-f54.google.com with SMTP id j13so4033889wgh.21
	for <emacs-orgmode@gnu.org>; Sun, 09 Jun 2013 00:54:54 -0700 (PDT)
In-Reply-To: <8738sux7pw.fsf@pank.eu> (rasmus@gmx.us's message of "Fri, 07 Jun
	2013 17:26:35 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Rasmus <rasmus@gmx.us>
Cc: emacs-orgmode@gnu.org

Hello,

Rasmus <rasmus@gmx.us> writes:

> Nicolas Goaziou <n.goaziou@gmail.com> writes:
>  
>> It is, thank you. Here is another round of comments.
>
> v4 attached.

Thank you.

The patch looks good, but the feature needs to be documented. I think
you could add a paragraph in `org-latex-classes' docstring, below the
first reference to "AUTO".

> Subject: [PATCH] Allow AUTO argument to org-latex-guess-babel-language.
>
> * ox-latex.el (org-latex-guess-babel-language): replace AUTO with
>   language if AUTO is the option of the LaTeX package Babel.
>
> * ox-latex.el (org-latex-guess-babel-language): retain case in final
> replace-match of the function.

You don't need to make two entries for the same function.


Regards,

-- 
Nicolas Goaziou