From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <n.goaziou@gmail.com>
Subject: Re: Add figure/table numbers to HTML captions
Date: Sat, 29 Jun 2013 10:02:07 +0200
Message-ID: <87zju9pcow.fsf@gmail.com>
References: <87li5vsjb8.fsf@gmail.com>
	<20130628.101530.1683355082328893107.nom@quickhack.net>
	<87ppv6r3ky.fsf@gmail.com>
	<20130629.160115.263707471452837649.nom@quickhack.net>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49493)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1Usq6X-0000CW-BO
	for emacs-orgmode@gnu.org; Sat, 29 Jun 2013 04:01:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1Usq6W-0000f3-Eu
	for emacs-orgmode@gnu.org; Sat, 29 Jun 2013 04:01:57 -0400
Received: from mail-wi0-x22a.google.com ([2a00:1450:400c:c05::22a]:37562)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1Usq6W-0000er-9D
	for emacs-orgmode@gnu.org; Sat, 29 Jun 2013 04:01:56 -0400
Received: by mail-wi0-f170.google.com with SMTP id ey16so2473848wid.1
	for <emacs-orgmode@gnu.org>; Sat, 29 Jun 2013 01:01:55 -0700 (PDT)
In-Reply-To: <20130629.160115.263707471452837649.nom@quickhack.net> (Yoshinari
	Nomura's message of "Sat, 29 Jun 2013 16:01:15 +0900 (JST)")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Yoshinari Nomura <nom@quickhack.net>
Cc: emacs-orgmode@gnu.org

Hello,

Yoshinari Nomura <nom@quickhack.net> writes:

> I've split my work into these three commits:
>   0001-ox-html-add-figure-and-table-numbers-to-HTML-caption.patch
>   0002-ox-add-dictionary-entry-for-numbered-figures.patch
>   0003-ox-add-Japanese-translations-for-figures-and-tables.patch
>   (enclosed in the attachments)

Thanks for your work. Some minor comments below.

> commit a82e712c3d60d8b58e2cffe13d5cbcdfa25ede24
> Author: Yoshinari Nomura <nom@quickhack.net>
> Date:   Sat Jun 29 15:06:49 2013 +0900
>
>     ox: add Japanese translations for figures and tables
>     
>     * lisp/ox.el: (org-export-dictionary): Add Japanese translations for
>     figures and tables

You need to add TINYCHANGE at the end of your commit messages, since,
AFAIK, you haven't signed FSF papers yet.

> -	   (let ((path (org-export-solidify-link-text path)) number)
> +	   (let* ((path (org-export-solidify-link-text path)) number
> +		  (caption-predicate
> +		   (if (org-html--has-caption-p destination)
> +		       'org-html--has-caption-p))

You can remove this. Just use `org-html--has-caption-p' and replaces
references to `caption-predicate' below with it.

Otherwise, the patch looks good. Could you send the files as an
attachment? It will be easier for me to apply them.


Regards,

-- 
Nicolas Goaziou