From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?utf-8?Q?=C3=98yvind?= Stegard <oyvinst@ifi.uio.no>
Subject: Re: [PATCH] org-contacts: Update contacts cache if it contains
 markers with no buffer
Date: Wed, 17 Jul 2013 09:36:51 +0200
Message-ID: <87zjtlwsbw.fsf.rednorrock@ifi.uio.no>
References: <878v1cdoke.fsf.rednorrock@ifi.uio.no> <87fvvexvtl.fsf@tanger.home>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46822)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <oyvind.stegard@ifi.uio.no>) id 1UzMIJ-00023r-Ch
	for emacs-orgmode@gnu.org; Wed, 17 Jul 2013 03:37:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <oyvind.stegard@ifi.uio.no>) id 1UzMIB-0003t9-UD
	for emacs-orgmode@gnu.org; Wed, 17 Jul 2013 03:37:03 -0400
Received: from mail-out4.uio.no ([129.240.10.15]:39225)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <oyvind.stegard@ifi.uio.no>) id 1UzMIB-0003sJ-Nu
	for emacs-orgmode@gnu.org; Wed, 17 Jul 2013 03:36:55 -0400
Received: from mail-mx4.uio.no ([129.240.10.45])
	by mail-out4.uio.no with esmtp (Exim 4.80.1)
	(envelope-from <oyvind.stegard@ifi.uio.no>) id 1UzMI8-0004Yc-BG
	for emacs-orgmode@gnu.org; Wed, 17 Jul 2013 09:36:52 +0200
Received: from 1x-193-157-249-34.uio.no ([193.157.249.34]
	helo=rednorrock.local)
	by mail-mx4.uio.no with esmtpsa (TLSv1.2:DHE-RSA-AES128-SHA:128)
	user oyvinst (Exim 4.80) (envelope-from <oyvind.stegard@ifi.uio.no>)
	id 1UzMI7-0004oh-T7
	for emacs-orgmode@gnu.org; Wed, 17 Jul 2013 09:36:52 +0200
In-Reply-To: <87fvvexvtl.fsf@tanger.home> (daimrod@gmail.com's message of
	"Tue, 16 Jul 2013 19:23:50 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: emacs-orgmode@gnu.org

Daimrod <daimrod@gmail.com> writes:

[...]

> Thanks for the bug report!
>
> Don't you think that checking if one of the buffer would be enough and
> faster?
> With something like (every #'get-file-buffer org-contacts-files)

Hi,

I thought about that, yes. But what about when an org-contacts buffer is
killed and subsequently re-opened (like using `find-alternate-file' with
same file name). Then the buffer will exist for the file, but it will be
a new instance, and the markers in org-contacts-db will still be dead.
That's why I decided to just check the markers instead.


Regards,

=C3=98yvind
--=20
< =C3=98yvind Stegard
 < http://stegard.net/