tiny patch for org-expiry

tiny patch for org-expiry

[Alan Schmitt]

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

Hello,

I'm trying to write some code to schedule reviews of projects, and I'm
basing it on org-expiry. I found a couple of tiny bugs with it, which
may be fixed with this patch.

Best,

Alan


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Org-expiry-make-code-and-doc-consistent.patch --]
[-- Type: text/x-patch, Size: 1379 bytes --]

From f38fe30c5c6115d33755a1c9f052cb01d1434d79 Mon Sep 17 00:00:00 2001
From: Alan Schmitt <alan.schmitt@polytechnique.org>
Date: Sat, 12 Apr 2014 12:32:42 +0200
Subject: [PATCH] Org-expiry: make code and doc consistent

* contrib/lisp/org-expiry.el (org-expiry-expired-p): make code and doc
string consistent.
---
 contrib/lisp/org-expiry.el | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/contrib/lisp/org-expiry.el b/contrib/lisp/org-expiry.el
index d58043f..33f8ea1 100644
--- a/contrib/lisp/org-expiry.el
+++ b/contrib/lisp/org-expiry.el
@@ -218,11 +218,12 @@ Return nil if the entry is not expired.  Otherwise return the
 amount of time between today and the expiry date.
 
 If there is no creation date, use `org-expiry-created-date'.
-If there is no expiry date, use `org-expiry-expiry-date'."
+If there is no expiry date, use `org-expiry-wait'."
   (let* ((ex-prop org-expiry-expiry-property-name)
 	 (cr-prop org-expiry-created-property-name)
 	 (ct (current-time))
-	 (cr (org-read-date nil t (or (org-entry-get (point) cr-prop t) "+0d")))
+	 (cr (org-read-date nil t (or (org-entry-get (point) cr-prop t) 
+				      org-expiry-created-date)))
 	 (ex-field (or (org-entry-get (point) ex-prop t) org-expiry-wait))
 	 (ex (if (string-match "^[ \t]?[+-]" ex-field)
 		 (time-add cr (time-subtract (org-read-date nil t ex-field) ct))
-- 
1.8.5.3

Re: tiny patch for org-expiry

[Bastien]

Hi Alan,

Alan Schmitt <alan.schmitt@polytechnique.org> writes:

> I'm trying to write some code to schedule reviews of projects, and I'm
> basing it on org-expiry. I found a couple of tiny bugs with it, which
> may be fixed with this patch.

I Now Pronounce You Maintainer of Org Expiry :)

Joke aside, I haven't touch the code since long, so please go ahead
with bugfixes by committing them directly, unless there is something
you're unsure about.

Thanks!

-- 
 Bastien

Re: tiny patch for org-expiry

[Alan Schmitt]

On 2014-04-13 00:11, Bastien <bzg@gnu.org> writes:

> Hi Alan,
>
> Alan Schmitt <alan.schmitt@polytechnique.org> writes:
>
>> I'm trying to write some code to schedule reviews of projects, and I'm
>> basing it on org-expiry. I found a couple of tiny bugs with it, which
>> may be fixed with this patch.
>
> I Now Pronounce You Maintainer of Org Expiry :)
>
> Joke aside, I haven't touch the code since long, so please go ahead
> with bugfixes by committing them directly, unless there is something
> you're unsure about.

Will do.

Thanks,

Alan