From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Seeger Subject: [PATCH] Reverse capture finalize and refile, hack buffer killing. Date: Mon, 28 Sep 2015 10:06:58 +0200 Message-ID: <87zj07klwd.wl-jan.seeger@thenybble.de> References: <87io71qrbt.wl-jan.seeger@thenybble.de> <87twqjk06p.fsf@nicolasgoaziou.fr> <5F2C244C-C240-4956-9479-7D3301709B47@thenybble.de> <871tdmene3.fsf@nicolasgoaziou.fr> <871tdmmyqy.wl-jan.seeger@thenybble.de> <8737y2cfd5.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44630) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZgTSs-0007My-Nl for emacs-orgmode@gnu.org; Mon, 28 Sep 2015 04:07:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZgTSn-0003z5-Ng for emacs-orgmode@gnu.org; Mon, 28 Sep 2015 04:07:14 -0400 Received: from [2a01:488:66:1000:57e6:57cd:0:1] (port=44714 helo=eins.thenybble.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZgTSn-0003ws-DJ for emacs-orgmode@gnu.org; Mon, 28 Sep 2015 04:07:09 -0400 In-Reply-To: <8737y2cfd5.fsf@nicolasgoaziou.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Jan Seeger , emacs-orgmode@gnu.org * org-capture.el (org-capture-refile): Call finalize first, then refile. If the capture buffer needs to be killed afterwards, kill after refiling. Refiling before finalizing led to an incorrect cursor position during refile. Since adjusting the buffer position and bounds for the refiled entry is difficult, I reverted the org-capture-refile function to its original order of finalizing and then refiling. However, this leads to a bug with killing the buffer on capture, described in http://permalink.gmane.org/gmane.emacs.orgmode/78027/. To work around this, now the :kill-buffer flag is cleared before calling finalize, and the capture buffer is killed after org-refile is called. TINYCHANGE --- lisp/org-capture.el | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lisp/org-capture.el b/lisp/org-capture.el index 67dc319..b1cda3d 100644 --- a/lisp/org-capture.el +++ b/lisp/org-capture.el @@ -792,7 +792,10 @@ already gone. Any prefix argument will be passed to the refile command." "Refiling from a capture buffer makes only sense for `entry'-type templates")) (let ((pos (point)) (base (buffer-base-buffer (current-buffer))) - (org-refile-for-capture t)) + (org-refile-for-capture t) + (kill-buffer (org-capture-get :kill-buffer 'local))) + (org-capture-put :kill-buffer nil) + (org-capture-finalize) (save-window-excursion (with-current-buffer (or base (current-buffer)) (save-excursion @@ -800,7 +803,7 @@ already gone. Any prefix argument will be passed to the refile command." (widen) (goto-char pos) (call-interactively 'org-refile))))) - (org-capture-finalize))) + (when kill-buffer (kill-buffer base)))) (defun org-capture-kill () "Abort the current capture process." -- 2.4.9