From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Malakhovski Subject: Re: [PATCH 9/9] ob-calc: don't leave garbage on the stack Date: Wed, 04 Nov 2015 15:24:36 +0000 Message-ID: <87ziytlrd7.fsf@yin.lan> References: <1446581747-1960-1-git-send-email-oxij@oxij.org> <1446581747-1960-10-git-send-email-oxij@oxij.org> <87fv0mvw5k.fsf@gmail.com> <87a8qum14d.fsf@yin.lan> <87y4edvncd.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52812) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtzvX-0003Ay-Pk for emacs-orgmode@gnu.org; Wed, 04 Nov 2015 10:24:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZtzvT-0003ZZ-T6 for emacs-orgmode@gnu.org; Wed, 04 Nov 2015 10:24:43 -0500 Received: from fujibayashi-1-pt.tunnel.tserv10.par1.ipv6.he.net ([2001:470:1f12:446::2]:46831 helo=tricoro.koumakan.jp) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtzvT-0003ZR-N0 for emacs-orgmode@gnu.org; Wed, 04 Nov 2015 10:24:39 -0500 In-Reply-To: <87y4edvncd.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Aaron Ecay , emacs-orgmode@gnu.org Aaron Ecay writes: > Ok. Then: > 1. The indentation is wrong, because (calc-pop 1) is the second argument > to calc-eval. > 2. The prog1 form is not needed, because it only wraps a single form > (the calc-eval call). > > This looks wrong to me, so please double-check. Ah, I misunderstood. You are correct about parens indeed. Fixed, ok. Why it wored as expected I have no idea.