From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: Patch for ox-confluence.el
Date: Thu, 17 Mar 2016 12:26:03 +0100
Message-ID: <87zitxmjlg.fsf@nicolasgoaziou.fr>
References: <CADK98M2GKNNSY0y_27MukDD=u_Kp+44RMzpABuDowsHgMvfLUA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44297)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1agW21-0003Qz-Gj
	for emacs-orgmode@gnu.org; Thu, 17 Mar 2016 07:24:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1agW20-0002M8-Ly
	for emacs-orgmode@gnu.org; Thu, 17 Mar 2016 07:23:57 -0400
Received: from relay3-d.mail.gandi.net ([2001:4b98:c:538::195]:35411)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1agW20-0002M2-Fz
	for emacs-orgmode@gnu.org; Thu, 17 Mar 2016 07:23:56 -0400
In-Reply-To: <CADK98M2GKNNSY0y_27MukDD=u_Kp+44RMzpABuDowsHgMvfLUA@mail.gmail.com>
	(Paul Schorfheide's message of "Wed, 09 Mar 2016 16:42:33 +0000")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Paul Schorfheide <pschorf2@gmail.com>
Cc: emacs-orgmode@gnu.org

Hello,

Paul Schorfheide <pschorf2@gmail.com> writes:

> I made a small change to ox-confluence.el to support additional language
> name mappings. Can someone please review it?

Thank you for the patch.

AFAIU, "ox-confluence.el" doesn't have a maintainer anymore, in case you
feel like doing the job. 

The library could also be moved to ELPA, IMO.

> +(defvar org-confluence-lang-alist
> +  '(("sh" . "bash"))
> +  "Map from org-babel language name to confluence wiki language name")

What about making it a defcustom?

>  ;; All the functions we use
>  (defun org-confluence-bold (bold contents info)
>    (format "*%s*" contents))
> @@ -111,8 +115,9 @@
>  (defun org-confluence-src-block (src-block contents info)
>    ;; FIXME: provide a user-controlled variable for theme
>    (let* ((lang (org-element-property :language src-block))
> -         (language (if (string= lang "sh") "bash" ;; FIXME: provide a mapping of some sort
> -                     lang))
> +         (language (if (assoc lang org-confluence-lang-alist)
> +		       (cdr (assoc lang org-confluence-lang-alist))
> +                       lang))

Nitpick:

  (or (cdr (assoc lang org-confluence-lang-alist) lang))
  

Regards,

-- 
Nicolas Goaziou