emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* HTML width attribute gets added to a href instead of img
@ 2017-01-06 17:19 Kaushal Modi
  2017-01-07 14:50 ` Nicolas Goaziou
  0 siblings, 1 reply; 3+ messages in thread
From: Kaushal Modi @ 2017-01-06 17:19 UTC (permalink / raw)
  To: emacs-org list

[-- Attachment #1: Type: text/plain, Size: 1732 bytes --]

Hello,

I am using the devel versions of org and emacs.

Org mode version 9.0.3 (release_9.0.3-180-g0d3683 @
/home/kmodi/usr_local/apps/6/emacs/master/share/emacs/site-lisp/org/)

Emacs version: GNU Emacs 26.0.50.4 (x86_64-unknown-linux-gnu, GTK+ Version
2.24.23)
 of 2017-01-06, built using commit 8f0376309ee37e4f1da21d78971c4df2df5fd7b6.

I believe that after this commit, the width attribute doesn't get added to
img tag as expected:
http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=5ffb373a2ca6833617e344154c3dc1b877ec4784

Here is a MWE:

=====
Below works as expected
#+ATTR_HTML: :width 10px
[[http://orgmode.org/img/org-mode-unicorn-logo.png]]

Below does not where the image is added as /link description/.
#+ATTR_HTML: :width 10px
[[http://orgmode.org][http://orgmode.org/img/org-mode-unicorn-logo.png]]
=====

Here is just the body of the exported html for brevity:

=====
<body>
<div id="content">
<p>
Below works as expected
</p>

<div class="figure">
<p><img src="http://orgmode.org/img/org-mode-unicorn-logo.png"
alt="org-mode-unicorn-logo.png" width="10px" />
</p>
</div>

<p>
Below does not where the image is added as <i>link description</i>.
</p>

<div class="figure">
<p><a href="http://orgmode.org" width="10px"><img src="
http://orgmode.org/img/org-mode-unicorn-logo.png"
alt="org-mode-unicorn-logo.png" /></a>
</p>
</div>
</div>
<div id="postamble" class="status">
Exported using <div style="display: inline" class="creator"><a href="
http://www.gnu.org/software/emacs/">Emacs</a> 26.0.50.4 (<a href="
http://orgmode.org">Org</a> mode 9.0.3)</div> by Kaushal.Modi.
</div>
</body>
=====

Note that in the latter case, the width property gets added to 'a' tag
instead of to the 'img' tag.
-- 

Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 3314 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: HTML width attribute gets added to a href instead of img
  2017-01-06 17:19 HTML width attribute gets added to a href instead of img Kaushal Modi
@ 2017-01-07 14:50 ` Nicolas Goaziou
  2017-01-07 15:17   ` Kaushal Modi
  0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Goaziou @ 2017-01-07 14:50 UTC (permalink / raw)
  To: Kaushal Modi; +Cc: emacs-org list

Hello,

Kaushal Modi <kaushal.modi@gmail.com> writes:

> I believe that after this commit, the width attribute doesn't get added to
> img tag as expected:
> http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=5ffb373a2ca6833617e344154c3dc1b877ec4784
>
> Here is a MWE:
>
> =====
> Below works as expected
> #+ATTR_HTML: :width 10px
> [[http://orgmode.org/img/org-mode-unicorn-logo.png]]
>
> Below does not where the image is added as /link description/.
> #+ATTR_HTML: :width 10px
> [[http://orgmode.org][http://orgmode.org/img/org-mode-unicorn-logo.png]]
> =====
>
> Here is just the body of the exported html for brevity:
>
> =====
> <body>
> <div id="content">
> <p>
> Below works as expected
> </p>
>
> <div class="figure">
> <p><img src="http://orgmode.org/img/org-mode-unicorn-logo.png"
> alt="org-mode-unicorn-logo.png" width="10px" />
> </p>
> </div>
>
> <p>
> Below does not where the image is added as <i>link description</i>.
> </p>
>
> <div class="figure">
> <p><a href="http://orgmode.org" width="10px"><img src="
> http://orgmode.org/img/org-mode-unicorn-logo.png"
> alt="org-mode-unicorn-logo.png" /></a>
> </p>
> </div>
> </div>
> <div id="postamble" class="status">
> Exported using <div style="display: inline" class="creator"><a href="
> http://www.gnu.org/software/emacs/">Emacs</a> 26.0.50.4 (<a href="
> http://orgmode.org">Org</a> mode 9.0.3)</div> by Kaushal.Modi.
> </div>
> </body>
> =====
>
> Note that in the latter case, the width property gets added to 'a' tag
> instead of to the 'img' tag.

Fixed. Thank you.


Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: HTML width attribute gets added to a href instead of img
  2017-01-07 14:50 ` Nicolas Goaziou
@ 2017-01-07 15:17   ` Kaushal Modi
  0 siblings, 0 replies; 3+ messages in thread
From: Kaushal Modi @ 2017-01-07 15:17 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: emacs-org list

[-- Attachment #1: Type: text/plain, Size: 1808 bytes --]

Thank you!

On Sat, Jan 7, 2017, 9:50 AM Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:

> Hello,
>
> Kaushal Modi <kaushal.modi@gmail.com> writes:
>
> > I believe that after this commit, the width attribute doesn't get added
> to
> > img tag as expected:
> >
> http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=5ffb373a2ca6833617e344154c3dc1b877ec4784
> >
> > Here is a MWE:
> >
> > =====
> > Below works as expected
> > #+ATTR_HTML: :width 10px
> > [[http://orgmode.org/img/org-mode-unicorn-logo.png]]
> >
> > Below does not where the image is added as /link description/.
> > #+ATTR_HTML: :width 10px
> > [[http://orgmode.org][http://orgmode.org/img/org-mode-unicorn-logo.png]]
> > =====
> >
> > Here is just the body of the exported html for brevity:
> >
> > =====
> > <body>
> > <div id="content">
> > <p>
> > Below works as expected
> > </p>
> >
> > <div class="figure">
> > <p><img src="http://orgmode.org/img/org-mode-unicorn-logo.png"
> > alt="org-mode-unicorn-logo.png" width="10px" />
> > </p>
> > </div>
> >
> > <p>
> > Below does not where the image is added as <i>link description</i>.
> > </p>
> >
> > <div class="figure">
> > <p><a href="http://orgmode.org" width="10px"><img src="
> > http://orgmode.org/img/org-mode-unicorn-logo.png"
> > alt="org-mode-unicorn-logo.png" /></a>
> > </p>
> > </div>
> > </div>
> > <div id="postamble" class="status">
> > Exported using <div style="display: inline" class="creator"><a href="
> > http://www.gnu.org/software/emacs/">Emacs</a> 26.0.50.4 (<a href="
> > http://orgmode.org">Org</a> mode 9.0.3)</div> by Kaushal.Modi.
> > </div>
> > </body>
> > =====
> >
> > Note that in the latter case, the width property gets added to 'a' tag
> > instead of to the 'img' tag.
>
> Fixed. Thank you.
>
>
> Regards,
>
> --
> Nicolas Goaziou
>
-- 

Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 5045 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-01-07 15:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-06 17:19 HTML width attribute gets added to a href instead of img Kaushal Modi
2017-01-07 14:50 ` Nicolas Goaziou
2017-01-07 15:17   ` Kaushal Modi

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).