From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Marc Ihm <marc@ihm.name>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] lisp/org-el: Fix explanation, if state change is blocked by contained checkboxes
Date: Mon, 17 Apr 2017 10:39:05 +0200 [thread overview]
Message-ID: <87ziffmnrq.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <867f2ndm5d.fsf@ihm.name> (Marc Ihm's message of "Fri, 14 Apr 2017 17:49:50 +0200")
Hello,
Marc Ihm <marc@ihm.name> writes:
> The patch below fixes a minor problem:
>
> Consider a node, which contains unchecked checkboxes; if you have set
> org-enforce-todo-checkbox-dependencies and try to change the node to
> DONE, you will be denied with a message explaining why. However in this
> special case the explanation would be wrong in talking of an unrelated
> node instead of the checkboxes.
>
> The fix uses the already existing variable org-blocked-by-checkboxes
> (which is handled in org-block-todo-from-checkboxes). Similar code is
> already present in org-agenda-dim-blocked-tasks within org-agenda.el.
>
>
> Please review the patch and let me know, if you have any comments or
> questions.
Applied. Thank you.
Regards,
--
Nicolas Goaziou
prev parent reply other threads:[~2017-04-17 8:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-14 15:49 [PATCH] lisp/org-el: Fix explanation, if state change is blocked by contained checkboxes Marc Ihm
2017-04-17 8:39 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ziffmnrq.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=marc@ihm.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).